Linux-i2c Archive mirror
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Piyush Malgujar <pmalgujar@marvell.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	 sgarapati@marvell.com, cchavva@marvell.com,
	jannadurai@marvell.com
Subject: Re: [PATCH v6 4/4] i2c: thunderx: Adding ioclk support
Date: Thu, 18 Apr 2024 21:14:34 +0200	[thread overview]
Message-ID: <3yapowxkxgsd2iq33trm7blpacmehmrbpk2jcffte7supz6ugd@lnsmw5wfj3nc> (raw)
In-Reply-To: <20240402134018.2686919-5-pmalgujar@marvell.com>

Hi Piyush,

On Tue, Apr 02, 2024 at 06:40:14AM -0700, Piyush Malgujar wrote:
> Read the ioclk property as reference clock if sclk not present in acpi
> table to make it SOC agnostic.
> In case, it's not populated from dts/acpi table, use the default clock
> of 800 MHz which is optimal in either case of sclk/ioclk.
> 
> Signed-off-by: Piyush Malgujar <pmalgujar@marvell.com>

just acking as a reminder to myself:

Acked-by: Andi Shyti <andi.shyti@kernel.org>

Everything looks good, if you manage to split patch 2 in two
different patches, then I think it's good to go.

Thanks,
Andi

      reply	other threads:[~2024-04-18 19:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 13:40 [PATCH v6 0/4] i2c: thunderx: Marvell thunderx i2c changes Piyush Malgujar
2024-04-02 13:40 ` [PATCH v6 1/4] i2c: thunderx: Clock divisor logic changes Piyush Malgujar
2024-04-16 13:08   ` Piyush Malgujar
2024-04-18 19:07     ` Andi Shyti
2024-04-02 13:40 ` [PATCH v6 2/4] i2c: thunderx: Support for High speed mode Piyush Malgujar
2024-04-18 19:12   ` Andi Shyti
2024-04-02 13:40 ` [PATCH v6 3/4] i2c: octeon: Handle watchdog timeout Piyush Malgujar
2024-04-02 13:40 ` [PATCH v6 4/4] i2c: thunderx: Adding ioclk support Piyush Malgujar
2024-04-18 19:14   ` Andi Shyti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3yapowxkxgsd2iq33trm7blpacmehmrbpk2jcffte7supz6ugd@lnsmw5wfj3nc \
    --to=andi.shyti@kernel.org \
    --cc=cchavva@marvell.com \
    --cc=jannadurai@marvell.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmalgujar@marvell.com \
    --cc=sgarapati@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).