From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Andi Shyti <andi.shyti@kernel.org>
Subject: Re: i2c: designware: unhandled interrupt on N100 lpss channel 0
Date: Wed, 20 Mar 2024 22:26:06 +0100 [thread overview]
Message-ID: <6d0b7ab5-7864-49f9-92ca-f3413fe6e1f9@gmail.com> (raw)
In-Reply-To: <ZftQKXWBKPj3ztYM@smile.fi.intel.com>
On 20.03.2024 22:07, Andy Shevchenko wrote:
> On Wed, Mar 20, 2024 at 09:21:34PM +0100, Heiner Kallweit wrote:
>> On 20.03.2024 16:59, Andy Shevchenko wrote:
>>> On Wed, Mar 20, 2024 at 03:56:29PM +0100, Heiner Kallweit wrote:
>
> ...
>
>>> grep 0000001b /sys/kernel/debug/pinctrl/*/pins
>>
>> pin 3 (GPPC_B_3) 3:INTC1057:00 GPIO 0x80100102 0x0000001b 0x00000000 [LOCKED tx]
>> pin 82 (GPP_F_7_EMMC_CMD) 135:INTC1057:00 GPIO 0x44000300 0x0000001b 0x00000000 [LOCKED full, ACPI]
>> pin 182 (GPPC_C_13) 269:INTC1057:00 GPIO 0x44000300 0x0000001b 0x00000000 [LOCKED full, ACPI]
>
> I was not correct, the value to grep is '0000[0-3][0-9a-f]1b' as there pull
> up/down can be enabled.
>
Result is the same
> Nevertheless from the above the pin 3 is one that is enabled as GPIO input with
> RTE 27 and direct IRQ. If it's a culprit, try to add in the pinctrl-intel.c at
> the end of .probe:
>
> {
> void __iomem *padcfg0;
> u32 value;
>
> padcfg0 = intel_get_padcfg(pctrl, 3, PADCFG0);
>
> value = readl(padcfg0);
> value |= PADCFG0_GPIOTXDIS;
> value |= PADCFG0_GPIORXDIS;
> writel(value, padcfg0);
> }
>
> If it helps, it will show the BIOS bug (likely).
>
Wow, this indeed fixes the issue for me. Thanks a lot!
For my understanding: Shall we (kernel driver) rely on the BIOS to configure
GPIO's properly? Or better assume that GPIO's are in an unknown state on
driver load and configure them for our needs?
IOW: If we assume that other systems may have similar issues, should "some driver"
use e.g. the pinctrl API to configure relevant pins?
next prev parent reply other threads:[~2024-03-20 21:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 21:11 i2c: designware: unhandled interrupt on N100 lpss channel 0 Heiner Kallweit
2024-03-20 12:27 ` Heiner Kallweit
2024-03-20 13:37 ` Jarkko Nikula
2024-03-20 14:15 ` Andy Shevchenko
2024-03-20 14:56 ` Heiner Kallweit
2024-03-20 15:59 ` Andy Shevchenko
2024-03-20 20:21 ` Heiner Kallweit
2024-03-20 21:07 ` Andy Shevchenko
2024-03-20 21:21 ` Andy Shevchenko
2024-03-20 21:26 ` Heiner Kallweit [this message]
2024-03-20 21:28 ` Heiner Kallweit
2024-03-21 11:20 ` Andy Shevchenko
2024-03-21 11:59 ` Heiner Kallweit
2024-03-21 17:33 ` Andy Shevchenko
2024-03-21 21:00 ` Heiner Kallweit
2024-03-22 16:18 ` Andy Shevchenko
2024-03-22 19:28 ` Heiner Kallweit
2024-04-02 20:46 ` Andy Shevchenko
2024-04-05 16:01 ` Andy Shevchenko
2024-04-05 19:21 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d0b7ab5-7864-49f9-92ca-f3413fe6e1f9@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).