From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>,
Wolfram Sang <wsa@the-dreams.de>,
Peter Korsgaard <peter.korsgaard@barco.com>,
Peter Rosin <peda@axentia.se>,
Guenter Roeck <linux@roeck-us.net>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH 4/4] i2c: Remove I2C_CLASS_SPD
Date: Wed, 17 Apr 2024 12:27:22 +0200 [thread overview]
Message-ID: <CAFSsGVvnESmed5oGNAJoLv7rxj61QJEn6WvkdLVyhNi-sen-RQ@mail.gmail.com> (raw)
In-Reply-To: <7qmjriqdfhbi6mkegcxu3cfpi4j4mw3qynz3byujgg2uzl2lrh@5amydhvwcytj>
On Wed, Apr 17, 2024 at 10:05 AM Andi Shyti <andi.shyti@kernel.org> wrote:
>
> Hi Heiner and Guenter,
>
> On Mon, Apr 15, 2024 at 10:50:27PM +0200, Heiner Kallweit wrote:
> > Remove this class after all users have been gone.
> >
> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> > ---
> > include/linux/i2c.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> > index 5e6cd43a6..970953737 100644
> > --- a/include/linux/i2c.h
> > +++ b/include/linux/i2c.h
> > @@ -852,7 +852,6 @@ static inline void i2c_mark_adapter_resumed(struct i2c_adapter *adap)
> >
> > /* i2c adapter classes (bitmask) */
> > #define I2C_CLASS_HWMON (1<<0) /* lm_sensors, ... */
> > -#define I2C_CLASS_SPD (1<<7) /* Memory modules */
>
> I missed the fact that we need some synchronization, as I'm
> getting a build failure.
>
> I will revert this and apply it after Guenter has merged his part
> into the mainline.
>
In order to cope with this dependency I proposed in the cover letter
to handle the full series via i2c tree. With Guenter's Ab for the
hwmon patch. Maybe this can still be done as an alternative.
Whatever is easier for both of you.
> Guenter, if you have a spare Post-it, could you please note to CC
> me when this part is sent as a pull request?
>
> Andi
>
> > /* Warn users that the adapter doesn't support classes anymore */
> > #define I2C_CLASS_DEPRECATED (1<<8)
> >
> > --
> > 2.44.0
> >
> >
next prev parent reply other threads:[~2024-04-17 10:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 20:47 [PATCH 0/4] i2c: Remove I2C_CLASS_SPD Heiner Kallweit
2024-04-15 20:47 ` [PATCH 1/4] i2c: i801: Remove usage of I2C_CLASS_SPD Heiner Kallweit
2024-04-15 20:48 ` [PATCH 2/4] i2c: mux: gpio: remove support for class-based device instantiation Heiner Kallweit
2024-04-15 20:49 ` [PATCH 3/4] hwmon: jc42: Remove I2C_CLASS_SPD support Heiner Kallweit
2024-04-15 21:43 ` Guenter Roeck
2024-04-15 20:50 ` [PATCH 4/4] i2c: Remove I2C_CLASS_SPD Heiner Kallweit
2024-04-17 8:05 ` Andi Shyti
2024-04-17 10:27 ` Heiner Kallweit [this message]
2024-04-16 22:46 ` (subset) [PATCH 0/4] " Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFSsGVvnESmed5oGNAJoLv7rxj61QJEn6WvkdLVyhNi-sen-RQ@mail.gmail.com \
--to=hkallweit1@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peda@axentia.se \
--cc=peter.korsgaard@barco.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).