From: Rob Herring <robh@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Rob Herring <robh@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-i3c@lists.infradead.org,
linux-sound@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: Remove obsolete i2c.txt
Date: Fri, 23 Feb 2024 09:55:40 -0700 [thread overview]
Message-ID: <CAL_JsqKpn6jqktRLQUx7HMrJG0PZeiOZ=hQnHpZK6AHcM22CLQ@mail.gmail.com> (raw)
In-Reply-To: <ZdemsdGQE0RtilCd@shikoro>
On Thu, Feb 22, 2024 at 12:55 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> On Thu, Feb 22, 2024 at 10:43:42AM -0700, Rob Herring wrote:
> > Everything in i2c.txt is covered by schemas/i2c/i2c-controller.yaml in
> > dtschema project, so remove i2c.txt and update links to it in the tree.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Differences to i2c.txt:
Thanks
> * In the schema, "clock-frequency" has a minimum of 1kHz and a maximum
> of 3MHz. Why? The specs do not say anything about a minimum freq and
> fastest speed mentioned in the docs is 5Mhz (Ultra fast mode).
IIRC, the high speed mode originally topped out at 3MHz. I guess
that's been revised.
We can drop the minimum.
> * new binding "i2c-scl-clk-low-timeout-us" has a description which I do
> not understand. What is a waiting state?
Shrug. May have to look at the MPC h/w that uses the property.
>
> * new binding "no-detect" is broken. At the least, it should be named
> something like "bus-fully-described" and then the OS can decide to
> leave out auto-detection mechanisms. If you are interested in the
> latter, you can simply disable class based instantiation on the host
> controller. No need to describe this in DT.
I've reverted the property now.
Rob
next prev parent reply other threads:[~2024-02-23 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 17:43 [PATCH] dt-bindings: i2c: Remove obsolete i2c.txt Rob Herring
2024-02-22 17:48 ` Mark Brown
2024-02-22 19:55 ` Wolfram Sang
2024-02-23 16:55 ` Rob Herring [this message]
2024-02-23 22:34 ` Wolfram Sang
2024-02-27 13:26 ` Rob Herring
2024-02-27 17:04 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKpn6jqktRLQUx7HMrJG0PZeiOZ=hQnHpZK6AHcM22CLQ@mail.gmail.com' \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=thierry.reding@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).