From: "Sabau, Radu bogdan" <Radu.Sabau@analog.com>
To: Rob Herring <robh@kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: RE: [PATCH v3 1/2] dt-bindings: hwmon: pmbus: adp1050: add bindings
Date: Thu, 21 Mar 2024 14:17:21 +0000 [thread overview]
Message-ID: <SA1PR03MB6499E2601776F43AA42BFB72F7322@SA1PR03MB6499.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20240321140017.GA1644231-robh@kernel.org>
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Thursday, March 21, 2024 4:00 PM
> To: Sabau, Radu bogdan <Radu.Sabau@analog.com>
> Cc: Jean Delvare <jdelvare@suse.com>; Guenter Roeck <linux@roeck-us.net>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>;
> Conor Dooley <conor+dt@kernel.org>; Jonathan Corbet <corbet@lwn.net>; Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>; linux-
> hwmon@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-doc@vger.kernel.org; linux-
> i2c@vger.kernel.org
> Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: pmbus: adp1050: add bindings
>
> [External]
>
> On Wed, Mar 20, 2024 at 02:57:11PM +0200, Radu Sabau wrote:
> > Add dt-bindings for adp1050 digital controller for isolated power supply
> > with pmbus interface voltage, current and temperature monitor.
> >
> > Signed-off-by: Radu Sabau <radu.sabau@analog.com>
> > ---
> > v3:
> > *Remove extra line before '$id'.
> > *Remove 'address-cells' and 'size-cells' from adp1050 node.
> > *Rename adp1050 node to generic name.
> > *Fix typo from 'adress-cells' to 'address-cells' causing errors in the
> > dt-bindings build.
> > v2:
> > *Fix identation for example.
> > *Remove 'adi,vin-scale-monitor' and 'iin-scale-monitor' since they are not used
> > anymore.
> > *Fix typo for 'compatbile' to 'compatible'.
> > *Add blank line under datasheet link.
> > ---
> > .../bindings/hwmon/pmbus/adi,adp1050.yaml | 49 +++++++++++++++++++
> > MAINTAINERS | 7 +++
> > 2 files changed, 56 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml
> b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml
> > new file mode 100644
> > index 000000000000..42cafd8fec25
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: https://urldefense.com/v3/__https://devicetree.org/schemas/hwmon/pmbus/adi,adp1050.yaml*__;Iw!!A3Ni8CS0y2Y!-
> 8d2ef4ArhRTDUHLiMXbulDz4xJmONqhQqWKLN35O7oIBsTYAjH2h1LFAT8T03nuAi97Q_kk4D5m$
> > +$schema: https://urldefense.com/v3/__https://devicetree.org/meta-schemes/core.yaml*__;Iw!!A3Ni8CS0y2Y!-
> 8d2ef4ArhRTDUHLiMXbulDz4xJmONqhQqWKLN35O7oIBsTYAjH2h1LFAT8T03nuAi97Qy7d7HZZ$
>
> Your issues are here. It's "http" and "meta-schemas". This is mostly
> copy-n-paste, so how did you get it wrong I wonder...
>
I ran the build one more time yesterday and noticed that there were typos
in the links, I guess it's because I decided for some reason to write them
by hand (don't know why because it doesn't make any sense).
> Rob
prev parent reply other threads:[~2024-03-21 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 12:57 [PATCH v3 1/2] dt-bindings: hwmon: pmbus: adp1050: add bindings Radu Sabau
2024-03-20 12:57 ` [PATCH v3 2/2] hwmon: pmbus: adp1050: Add driver support Radu Sabau
2024-03-20 13:05 ` [PATCH v3 1/2] dt-bindings: hwmon: pmbus: adp1050: add bindings Sabau, Radu bogdan
2024-03-20 14:19 ` Krzysztof Kozlowski
2024-03-21 14:00 ` Rob Herring
2024-03-21 14:17 ` Sabau, Radu bogdan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR03MB6499E2601776F43AA42BFB72F7322@SA1PR03MB6499.namprd03.prod.outlook.com \
--to=radu.sabau@analog.com \
--cc=Delphine_CC_Chiu@wiwynn.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).