From: Andi Shyti <andi.shyti@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Naveen Krishna Ch <ch.naveen@samsung.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@axis.com
Subject: Re: [PATCH v3] i2c: exynos5: Init data before registering interrupt handler
Date: Wed, 6 Mar 2024 23:00:16 +0100 [thread overview]
Message-ID: <aw7v5lu3ufutytrosjuzwnws7vg5uqlhs6bwinaibusl762ef4@5eeqvsxo3fp3> (raw)
In-Reply-To: <5a2d1071-5410-4c91-adfd-3d6384c74f94@linaro.org>
Hi Krzysztof,
On Wed, Mar 06, 2024 at 04:14:30PM +0100, Krzysztof Kozlowski wrote:
> On 06/03/2024 12:55, Andi Shyti wrote:
> > Hi
> >
> > On Tue, 05 Mar 2024 11:50:00 +0100, Jesper Nilsson wrote:
> >> devm_request_irq() is called before we initialize the "variant"
> >> member variable from of_device_get_match_data(), so if an interrupt
> >> is triggered inbetween, we can end up following a NULL pointer
> >> in the interrupt handler.
> >>
> >> This problem was exposed when the I2C controller in question was
> >> (mis)configured to be used in both secure world and Linux.
> >>
> >> [...]
> >
> > Applied to i2c/i2c-host-fixes on
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git
>
> If for any reason this is going to fixes, which marks its importance as
> fix, then it should go to stable as well. Please always cc-stable for
> such cases.
yes, thank you! I should have checked that, as well.
Andi
next prev parent reply other threads:[~2024-03-06 22:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240305105548eucas1p110f1ecf1570ff69a618ca86297eeba89@eucas1p1.samsung.com>
2024-03-05 10:50 ` [PATCH v3] i2c: exynos5: Init data before registering interrupt handler Jesper Nilsson
2024-03-06 11:55 ` Andi Shyti
2024-03-06 15:14 ` Krzysztof Kozlowski
2024-03-06 22:00 ` Andi Shyti [this message]
2024-03-07 11:41 ` Marek Szyprowski
2024-03-07 11:47 ` Krzysztof Kozlowski
2024-03-07 13:29 ` Markus Reichl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aw7v5lu3ufutytrosjuzwnws7vg5uqlhs6bwinaibusl762ef4@5eeqvsxo3fp3 \
--to=andi.shyti@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=ch.naveen@samsung.com \
--cc=jesper.nilsson@axis.com \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).