From: Bryan O'Donoghue <pure.logic@nexus-software.ie>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Robert Foss <rfoss@kernel.org>,
Loic Poulain <loic.poulain@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Wolfram Sang <wsa@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] Revert "Revert "dt-bindings: i2c: qcom-cci: Document sc8280xp compatible""
Date: Thu, 11 Apr 2024 11:24:34 +0100 [thread overview]
Message-ID: <d6a92b15-f68e-4e01-aad1-6483d53b9ad9@nexus-software.ie> (raw)
In-Reply-To: <7ef1c0e0-bd28-43f1-a46e-4fa551714e82@linaro.org>
On 11/04/2024 11:18, Krzysztof Kozlowski wrote:
> On 11/04/2024 12:16, Krzysztof Kozlowski wrote:
>> On 11/04/2024 12:12, Bryan O'Donoghue wrote:
>>> On 11/04/2024 10:36, Krzysztof Kozlowski wrote:
>>>> On 11/04/2024 10:52, Vladimir Zapolskiy wrote:
>>>>> This reverts commit 3e383dce513f426b7d79c0e6f8afe5d22a581f58.
>>>>>
>>>>> The commit ae2a1f0f2cb5 ("dt-bindings: i2c: qcom-cci: Document sc8280xp compatible")
>>>>> was correct apparently, it is required to describe the sc8280xp-cci
>>>>> controller properly, as well it eliminates dtbs_check warnings.
>>>>>
>>>>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>>>>
>>>> I am lost. Not on your patch, because it looks reasonable, but on entire
>>>> history.
>>>>
>>>> Can anyone explain me why original commit was reverted?
>>>>
>>>> https://lore.kernel.org/all/767bc246-a0a0-4dad-badc-81ed50573832@linaro.org/
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>>
>>> https://patchwork.ozlabs.org/project/devicetree-bindings/cover/20231006120159.3413789-1-bryan.odonoghue@linaro.org/#3195094
>>>
>>> We can you sm8250-cci instead, so dropped the additional compat.
>>
>> I am sorry, but that links point to cover letter and actually the same
>> thread as I linked. What does it prove?
>>
>
> And just to remind because you bring some discussions from driver: we
> talk here *only* about bindings patch. Not driver.
https://patchwork.ozlabs.org/project/devicetree-bindings/cover/20231006120159.3413789-1-bryan.odonoghue@linaro.org/#3195327
Konrad pointed out we don't need a new compat because the sm8250 compat
string could be reused.
So, I don't believe this revert should be reverted and I do believe Vlad
needs his own compat string because his clock list isn't supported.
---
bod
next prev parent reply other threads:[~2024-04-11 10:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 8:52 [PATCH] Revert "Revert "dt-bindings: i2c: qcom-cci: Document sc8280xp compatible"" Vladimir Zapolskiy
2024-04-11 9:36 ` Krzysztof Kozlowski
2024-04-11 10:12 ` Bryan O'Donoghue
2024-04-11 10:16 ` Krzysztof Kozlowski
2024-04-11 10:18 ` Krzysztof Kozlowski
2024-04-11 10:24 ` Bryan O'Donoghue [this message]
2024-04-11 10:28 ` Krzysztof Kozlowski
2024-04-11 11:57 ` Bryan O'Donoghue
2024-04-11 12:01 ` Bryan O'Donoghue
2024-04-11 12:02 ` Krzysztof Kozlowski
2024-04-11 12:03 ` Krzysztof Kozlowski
2024-04-11 12:21 ` Bryan O'Donoghue
2024-04-11 12:36 ` Krzysztof Kozlowski
2024-04-11 13:20 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6a92b15-f68e-4e01-aad1-6483d53b9ad9@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).