From: Andi Shyti <andi.shyti@kernel.org>
To: marc.ferland@gmail.com
Cc: michal.simek@amd.com, linux-arm-kernel@lists.infradead.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Marc Ferland <marc.ferland@sonatest.com>
Subject: Re: [PATCH] i2c: xiic: print error code when xiic_start_xfer fails
Date: Wed, 8 May 2024 14:51:34 +0200 [thread overview]
Message-ID: <h6mggdcri53rq65jzi5ov6n7oqdvaldtpofh6eina6gos2wyyw@crjmnmfpynw4> (raw)
In-Reply-To: <20240506154520.3886867-1-marc.ferland@sonatest.com>
Hi Marc,
On Mon, May 06, 2024 at 11:45:20AM -0400, marc.ferland@gmail.com wrote:
> From: Marc Ferland <marc.ferland@sonatest.com>
>
> xiic_start_xfer can fail for different reasons:
>
> - EBUSY: bus is busy or i2c messages still in tx_msg or rx_msg
> - ETIMEDOUT: timed-out trying to clear the RX fifo
Wolfram has recently removed all the error printouts caused by
etimedout.
> - EINVAL: wrong clock settings
>
> Printing the error code helps identifying the root cause.
>
> Signed-off-by: Marc Ferland <marc.ferland@sonatest.com>
> ---
> drivers/i2c/busses/i2c-xiic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index 71391b590ada..73729f0180a1 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -1165,7 +1165,7 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
>
> err = xiic_start_xfer(i2c, msgs, num);
> if (err < 0) {
> - dev_err(adap->dev.parent, "Error xiic_start_xfer\n");
> + dev_err(adap->dev.parent, "Error xiic_start_xfer: %d\n", err);
I don't see the end user being interested in having the error
number printed in the dmesg. In fact, I doubt the end user is
interested in this message at all.
We could print the debug messages (or warnings) where the actual
failure occurs. For example, in the setclk case, a warning is
already being printed, and I don't see why we should also print
an error here.
Does that make sense?
Andi
> goto out;
> }
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-05-08 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 15:45 [PATCH] i2c: xiic: print error code when xiic_start_xfer fails marc.ferland
2024-05-08 12:51 ` Andi Shyti [this message]
2024-05-08 13:47 ` Marc Ferland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=h6mggdcri53rq65jzi5ov6n7oqdvaldtpofh6eina6gos2wyyw@crjmnmfpynw4 \
--to=andi.shyti@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.ferland@gmail.com \
--cc=marc.ferland@sonatest.com \
--cc=michal.simek@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).