From: Jiri Kosina <jikos@kernel.org>
To: Christina Quast <contact@christina-quast.de>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-i2c@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, equinox@diac24.net,
Daniel Beer <daniel.beer@igorinstitute.com>,
Michael Zaidman <michael.zaidman@gmail.com>
Subject: Re: [PATCH v5] hid-ft260: Add serial driver
Date: Wed, 3 Apr 2024 13:34:50 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2404031332560.20263@cbobk.fhfr.pm> (raw)
In-Reply-To: <20240216-ft260_review5-v5-1-36db44673ac7@christina-quast.de>
On Fri, 16 Feb 2024, Christina Quast wrote:
> Adds the serial driver for FT260 USB HID devices, providing direct and
> simplified access to UART functionality without the need for FT260 HID
> report format knowledge.
>
> This chip implements an UART and I2C interface, but only the latter was
> previously supported with a kernel driver. For the UART interface, only
> FTDI example code using hidraw from userspace was available.
>
> This commit adds a serial interface /dev/ttyFTx (FT as in FT260), which
> implements tty serial driver ops, facilitating baudrate configuration,
> data transmission and reception, termios settings.
I don't see a dependency on CONFIG_TTY being added, and I believe it
should be there (even though !CONFIG_TTY configurations are likely
super-rare).
Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2024-04-03 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 15:03 [PATCH v5] hid-ft260: Add serial driver Christina Quast
2024-04-03 11:34 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2404031332560.20263@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=contact@christina-quast.de \
--cc=daniel.beer@igorinstitute.com \
--cc=equinox@diac24.net \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.zaidman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).