From: Andi Shyti <andi.shyti@kernel.org>
To: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
Cc: konrad.dybcio@linaro.org, andersson@kernel.org, vkoul@kernel.org,
wsa@kernel.org, linux-arm-msm@vger.kernel.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, quic_vdadhani@quicinc.com
Subject: Re: [PATCH v3] i2c: i2c-qcom-geni: Parse Error correctly in i2c GSI mode
Date: Fri, 8 Mar 2024 13:00:53 +0100 [thread overview]
Message-ID: <tbbpjk7ddpqnbtdu26pdcj3kzpanbih7cnok6vudbjq32qeoly@rrdsi2mgfsfp> (raw)
In-Reply-To: <6bacd2be-14d4-49cc-9c98-7010a5f9f9bc@quicinc.com>
Hi Mukesh,
> > > > > Fixes: d8703554f4de ("i2c: qcom-geni: Add support for GPI DMA")
> > > >
> > > > I still don't understand what's the fix here. You are making a
> > > > generic DMA error to be more specific... where is the bug? What
> > > > exactly is broken now?
> > > >
> > > This is about being particular while reporting specific error.
> > > Like i mentioned, instead of generic DMA transfer error, it should be
> > > particular error 1) NACK 2) BUT_PROTO 3)ARB_LOST.
> > > Ofcourse when data transfer via DMA fails, it can be considered as
> > > DMA Txfer fail.
> > > In summary so far driver was considering all failure as txfer failure,
> > > but i2c has errors which are kind of response/condition on the bus.
> >
> > I understand that, but what I need to know is: does the system
> > crash? does the system act in unexpected way?
> >
> > Moving from "you received an error" to "you received a nack" is
> > not a fix, it's an improvement and it should not have the Fixes
> > tag.
> >
> > Having the Fixes tag decides which path this patch will take to
> > to reach upstream. It's important because after it gets to
> > upstream other people will take your patch and backport it older
> > kernels.
> >
> > I want to avoid this extra work when not necessary.
> >
>
> Sure, then i think i should be removing fixes tag. It's not a crash but
> it's an improvement. That being said, i think don't need to CC stable kernel
> list and i should remove fixes tag ?
yes, don't need to do anything else, I will take care of
everything from now on. If Wolfram accepts a last minute pull
request, I can queue this up for 6.9.
Thank you,
Andi
next prev parent reply other threads:[~2024-03-08 12:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 20:55 [PATCH v3] i2c: i2c-qcom-geni: Parse Error correctly in i2c GSI mode Mukesh Kumar Savaliya
2024-03-07 21:24 ` Dmitry Baryshkov
2024-03-07 22:58 ` Andi Shyti
2024-03-08 5:43 ` Mukesh Kumar Savaliya
2024-03-08 7:02 ` Andi Shyti
2024-03-08 8:31 ` Mukesh Kumar Savaliya
2024-03-08 12:00 ` Andi Shyti [this message]
2024-03-08 22:56 ` Andi Shyti
2024-03-12 9:20 ` Wolfram Sang
2024-03-12 10:49 ` Andi Shyti
2024-03-13 5:35 ` Mukesh Kumar Savaliya
2024-03-13 19:46 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tbbpjk7ddpqnbtdu26pdcj3kzpanbih7cnok6vudbjq32qeoly@rrdsi2mgfsfp \
--to=andi.shyti@kernel.org \
--cc=andersson@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=vkoul@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).