From: Andi Shyti <andi.shyti@kernel.org>
To: Hans Hu <hanshu-oc@zhaoxin.com>
Cc: linux-i2c@vger.kernel.org, wsa@kernel.org, cobechen@zhaoxin.com,
hanshu@zhaoxin.com
Subject: Re: [PATCH v10 0/6] i2c: add zhaoxin i2c controller driver
Date: Mon, 29 Apr 2024 02:20:01 +0200 [thread overview]
Message-ID: <x25mr2pv4atl3gdxyrirenuw7kxb4bkltupp2cksjjekys3ckw@5epxael2alol> (raw)
In-Reply-To: <cover.1712479417.git.hanshu-oc@zhaoxin.com>
Hi Hans,
With the small change I announced in patch 1, I have applied the
patches to i2c/i2c-host on:
git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git
Thank you,
Andi
Patches applied
===============
[1/6] i2c: wmt: create wmt_i2c_init for general init
commit: 526a34e7cf93806305b9fd91a5ff7a7d17901b9b
[2/6] i2c: wmt: split out common files
commit: 9743b438b7177178c7783877c5416e845b23c06d
[3/6] i2c: wmt: rename something
commit: 185df2a0f3c45b477d6833fbc3ac57b8ef336352
[4/6] i2c: wmt: fix a bug when thread blocked
commit: b538a9ab48414ddae46aec07939c575f8c5b43c2
[5/6] i2c: wmt: add platform type VIAI2C_PLAT_WMT
commit: b28d202ef30163a32e61af4cdbf19dbeded05698
[6/6] i2c: add zhaoxin i2c controller driver
commit: d103b529c3b75168e79eae8134ade797126a6a98
On Mon, Apr 08, 2024 at 10:54:42AM +0800, Hans Hu wrote:
> v9->v10:
> * fixed style issues that were checked out by checkpatch.pl.
> * In Patch 3 in wmt_i2c_write() function, deleted the log
> when received nack.
> * In Patch 4 in viai2c_irq_xfer() function, return 1 for
> I2C_SMBUS_QUICK access.
> * In Patch 6 in zxi2c_get_bus_speed() function, adjusted
> the log when firmware gives inappropriate parameters.
> Link: https://lore.kernel.org/all/20240306212413.1850236-1-andi.shyti@kernel.org/
>
> v8->v9:
> * In Patch 1 in probe() do not return at the
> i2c_add_adapter(), but call clk_disable_unprepare()
> in case of failure.
> * In Patch 2 fix the conflict when i2c-wmt.c is removed.
> * In Patch 2 in wmt_i2c_probe() function, call
> clk_disable_unprepare() in case of failure. While at
> it, add a comment to explain the reason.
> * When renaming i2c_dev to i2c, change also the reference
> in clk_disable_unprepare().
> Link: https://lore.kernel.org/all/20240306212413.1850236-1-andi.shyti@kernel.org/
>
> v7->v8:
> * move per-msg handling to interrupt context
> * add private struct viai2c_zhaoxin to handle zhaoxin specific things
> * fixed some other formatting issues
> Link: https://lore.kernel.org/all/cover.1704440251.git.hanshu-oc@zhaoxin.com/
>
> v6->v7:
> * adjust the patch sequence
> * put those renaming related patches in 1 patch file
> * rename i2c-*-plt.c to i2c-viai2c-*.c
> * Some other adjustments suggested by Andi
> For more details, see the comment in each patch please.
> Link: https://lore.kernel.org/all/cover.1703830854.git.hanshu-oc@zhaoxin.com/
>
> v5->v6:
> * fix build warnning reported by kernel test robot.
> Link: https://lore.kernel.org/all/202312291225.cWVt6YF9-lkp@intel.com/
> Link: https://lore.kernel.org/all/cover.1703733126.git.hanshu-oc@zhaoxin.com/
>
> v4->v5:
> * fix 1 build error.
> Link: https://lore.kernel.org/all/ZYx0VPVmyQhtG+B9@shikoro/1-a.txt
> Link: https://lore.kernel.org/all/cover.1703647471.git.hanshu-oc@zhaoxin.com/
>
> v3->v4:
> * Some adjustments as suggested by Wolfram.
> * rebase patch on top of for-next branch.
> Link: https://lore.kernel.org/all/cover.1698889581.git.hanshu-oc@zhaoxin.com/
>
> v2->v3:
> * Split the number of patches from 2 to 12. Make it easier to review.
> Link: https://lore.kernel.org/all/cover.1691999569.git.hanshu-oc@zhaoxin.com/
>
> v1->v2:
> * Fixed some bugs I found myself.
> Link: https://lore.kernel.org/all/cover.1691030850.git.hanshu-oc@zhaoxin.com/
>
> Old version:
> This patch has already gone through a round of reviews.
> The difference from the first round is that it reuses
> the i2c-wmt driver.
> Link: https://lore.kernel.org/all/20230614094858.317652-1-hanshu-oc@zhaoxin.com/
>
> Signed-off-by: Hans Hu <hanshu-oc@zhaoxin.com>
>
> Hans Hu (6):
> i2c: wmt: create wmt_i2c_init for general init
> i2c: wmt: split out common files
> i2c: wmt: rename something
> i2c: wmt: fix a bug when thread blocked
> i2c: wmt: add platform type VIAI2C_PLAT_WMT
> i2c: add zhaoxin i2c controller driver
>
> MAINTAINERS | 10 +-
> drivers/i2c/busses/Kconfig | 10 +
> drivers/i2c/busses/Makefile | 3 +
> drivers/i2c/busses/i2c-viai2c-common.c | 256 ++++++++++++++
> drivers/i2c/busses/i2c-viai2c-common.h | 85 +++++
> drivers/i2c/busses/i2c-viai2c-wmt.c | 148 +++++++++
> drivers/i2c/busses/i2c-viai2c-zhaoxin.c | 298 +++++++++++++++++
> drivers/i2c/busses/i2c-wmt.c | 421 ------------------------
> 8 files changed, 809 insertions(+), 422 deletions(-)
> create mode 100644 drivers/i2c/busses/i2c-viai2c-common.c
> create mode 100644 drivers/i2c/busses/i2c-viai2c-common.h
> create mode 100644 drivers/i2c/busses/i2c-viai2c-wmt.c
> create mode 100644 drivers/i2c/busses/i2c-viai2c-zhaoxin.c
> delete mode 100644 drivers/i2c/busses/i2c-wmt.c
>
> --
> 2.34.1
>
prev parent reply other threads:[~2024-04-29 0:20 UTC|newest]
Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 2:53 [PATCH v3 00/12] i2c: add zhaoxin i2c controller driver Hans Hu
2023-11-02 2:53 ` [PATCH v3 01/12] i2c: wmt: Reduce redundant: bus busy check Hans Hu
2023-12-22 9:33 ` Wolfram Sang
2023-11-02 2:53 ` [PATCH v3 02/12] i2c: wmt: Reduce redundant: wait event complete Hans Hu
2023-12-22 9:34 ` Wolfram Sang
2023-11-02 2:53 ` [PATCH v3 03/12] i2c: wmt: Reduce redundant: clock mode setting Hans Hu
2023-12-22 9:36 ` Wolfram Sang
2023-11-02 2:53 ` [PATCH v3 04/12] i2c: wmt: Reduce redundant: REG_CR setting Hans Hu
2023-12-22 9:38 ` Wolfram Sang
2023-12-22 10:15 ` Wolfram Sang
2023-11-02 2:53 ` [PATCH v3 05/12] i2c: wmt: Reduce redundant: function parameter Hans Hu
2023-12-22 9:48 ` Wolfram Sang
2023-11-02 2:53 ` [PATCH v3 06/12] i2c: wmt: delete .remove_new Hans Hu
2023-12-22 9:51 ` Wolfram Sang
2023-11-02 2:53 ` [PATCH v3 07/12] i2c: wmt: create wmt_i2c_init for general init Hans Hu
2023-12-22 10:26 ` Wolfram Sang
2023-12-22 10:55 ` Hans Hu
2023-12-22 11:00 ` Wolfram Sang
2023-11-02 2:53 ` [PATCH v3 08/12] i2c: wmt: rename marcos with prefix WMTI2C_ Hans Hu
2023-11-02 2:53 ` [PATCH v3 09/12] i2c: wmt: adjust line length to meet style Hans Hu
2023-11-02 2:54 ` [PATCH v3 10/12] i2c: wmt: split out common files Hans Hu
2023-11-02 2:54 ` [PATCH v3 11/12] i2c: via-common: add zhaoxin platform Hans Hu
2023-11-02 2:54 ` [PATCH v3 12/12] i2c: add zhaoxin i2c controller driver Hans Hu
2023-11-08 9:50 ` [PATCH v3 00/12] " Wolfram Sang
2023-12-27 4:39 ` [PATCH v4 0/8] " Hans Hu
2023-12-27 4:39 ` [PATCH v4 1/8] i2c: wmt: create wmt_i2c_init for general init Hans Hu
2023-12-27 19:00 ` Wolfram Sang
2023-12-28 2:05 ` Hans Hu
2023-12-27 4:39 ` [PATCH v4 2/8] i2c: wmt: rename marcos with prefix WMTI2C_ Hans Hu
2023-12-27 4:39 ` [PATCH v4 3/8] i2c: wmt: adjust line length to meet style Hans Hu
2023-12-27 4:39 ` [PATCH v4 4/8] i2c: wmt: split out common files Hans Hu
2023-12-27 4:39 ` [PATCH v4 5/8] i2c: wmt: rename with prefix VIAI2C_ and viai2c_ Hans Hu
2023-12-27 4:39 ` [PATCH v4 6/8] i2c: wmt: fix a bug when thread blocked Hans Hu
2023-12-27 4:39 ` [PATCH v4 7/8] i2c: wmt: add platform type VIAI2C_PLAT_WMT Hans Hu
2023-12-27 4:39 ` [PATCH v4 8/8] i2c: add zhaoxin i2c controller driver Hans Hu
2023-12-28 3:17 ` [PATCH v5 0/8] " Hans Hu
2023-12-28 3:17 ` [PATCH v5 1/8] i2c: wmt: create wmt_i2c_init for general init Hans Hu
2023-12-28 3:17 ` [PATCH v5 2/8] i2c: wmt: rename marcos with prefix WMTI2C_ Hans Hu
2023-12-28 3:17 ` [PATCH v5 3/8] i2c: wmt: adjust line length to meet style Hans Hu
2023-12-28 3:17 ` [PATCH v5 4/8] i2c: wmt: split out common files Hans Hu
2023-12-28 3:17 ` [PATCH v5 5/8] i2c: wmt: rename with prefix VIAI2C_ and viai2c_ Hans Hu
2023-12-28 3:17 ` [PATCH v5 6/8] i2c: wmt: fix a bug when thread blocked Hans Hu
2023-12-28 3:17 ` [PATCH v5 7/8] i2c: wmt: add platform type VIAI2C_PLAT_WMT Hans Hu
2023-12-28 3:17 ` [PATCH v5 8/8] i2c: add zhaoxin i2c controller driver Hans Hu
2023-12-29 5:17 ` kernel test robot
2023-12-29 6:30 ` [PATCH v6 0/8] " Hans Hu
2023-12-29 6:30 ` [PATCH v6 1/8] i2c: wmt: create wmt_i2c_init for general init Hans Hu
2024-01-03 12:56 ` Andi Shyti
2024-01-04 1:44 ` Hans Hu
2023-12-29 6:30 ` [PATCH v6 2/8] i2c: wmt: rename marcos with prefix WMTI2C_ Hans Hu
2024-01-03 13:29 ` Andi Shyti
2023-12-29 6:30 ` [PATCH v6 3/8] i2c: wmt: adjust line length to meet style Hans Hu
2024-01-03 16:52 ` Andi Shyti
2024-01-04 1:49 ` Hans Hu
2023-12-29 6:30 ` [PATCH v6 4/8] i2c: wmt: split out common files Hans Hu
2024-01-03 17:21 ` Andi Shyti
2024-01-04 2:04 ` Hans Hu
2024-01-04 9:22 ` Andi Shyti
2024-01-04 9:45 ` Hans Hu
2024-01-04 12:36 ` Andi Shyti
2023-12-29 6:30 ` [PATCH v6 5/8] i2c: wmt: rename with prefix VIAI2C_ and viai2c_ Hans Hu
2024-01-03 18:45 ` Andi Shyti
2024-01-04 2:12 ` Hans Hu
2023-12-29 6:30 ` [PATCH v6 6/8] i2c: wmt: fix a bug when thread blocked Hans Hu
2024-01-03 19:39 ` Andi Shyti
2024-01-04 2:30 ` Hans Hu
2024-01-04 9:18 ` Andi Shyti
2024-01-04 10:02 ` Hans Hu
2024-01-04 12:37 ` Andi Shyti
2023-12-29 6:30 ` [PATCH v6 7/8] i2c: wmt: add platform type VIAI2C_PLAT_WMT Hans Hu
2023-12-29 6:30 ` [PATCH v6 8/8] i2c: add zhaoxin i2c controller driver Hans Hu
2024-01-03 20:02 ` Andi Shyti
2024-01-04 2:40 ` Hans Hu
2024-01-03 20:03 ` [PATCH v6 0/8] " Andi Shyti
2024-01-05 7:51 ` [PATCH v7 0/6] " Hans Hu
2024-01-05 7:51 ` [PATCH v7 1/6] i2c: wmt: create wmt_i2c_init for general init Hans Hu
2024-01-15 15:17 ` Krzysztof Kozlowski
2024-01-16 1:43 ` Hans Hu
2024-01-21 23:56 ` Andi Shyti
2024-02-21 12:10 ` Wolfram Sang
2024-01-05 7:51 ` [PATCH v7 2/6] i2c: wmt: split out common files Hans Hu
2024-02-21 12:19 ` Wolfram Sang
2024-01-05 7:51 ` [PATCH v7 3/6] i2c: wmt: rename something Hans Hu
2024-02-21 12:34 ` Wolfram Sang
2024-01-05 7:51 ` [PATCH v7 4/6] i2c: wmt: fix a bug when thread blocked Hans Hu
2024-02-21 12:37 ` Wolfram Sang
2024-02-22 9:03 ` Hans Hu
2024-02-22 9:37 ` Wolfram Sang
2024-02-22 10:42 ` Hans Hu
2024-02-22 17:26 ` Wolfram Sang
2024-01-05 7:51 ` [PATCH v7 5/6] i2c: wmt: add platform type VIAI2C_PLAT_WMT Hans Hu
2024-02-21 12:39 ` Wolfram Sang
2024-02-22 8:50 ` Hans Hu
2024-01-05 7:51 ` [PATCH v7 6/6] i2c: add zhaoxin i2c controller driver Hans Hu
2024-02-21 12:44 ` Wolfram Sang
2024-02-22 8:49 ` Hans Hu
2024-02-27 6:36 ` [PATCH v8 0/6] " Hans Hu
2024-02-27 6:36 ` [PATCH v8 1/6] i2c: wmt: create wmt_i2c_init for general init Hans Hu
2024-02-27 6:36 ` [PATCH v8 2/6] i2c: wmt: split out common files Hans Hu
2024-02-27 6:36 ` [PATCH v8 3/6] i2c: wmt: rename something Hans Hu
2024-02-27 6:36 ` [PATCH v8 4/6] i2c: wmt: fix a bug when thread blocked Hans Hu
2024-03-04 9:41 ` Wolfram Sang
2024-02-27 6:36 ` [PATCH v8 5/6] i2c: wmt: add platform type VIAI2C_PLAT_WMT Hans Hu
2024-03-04 9:46 ` Wolfram Sang
2024-02-27 6:36 ` [PATCH v8 6/6] i2c: add zhaoxin i2c controller driver Hans Hu
2024-03-04 9:49 ` Wolfram Sang
2024-03-04 23:01 ` [SPAM] " Andi Shyti
2024-03-05 2:45 ` Hans Hu
2024-03-06 11:50 ` Andi Shyti
2024-03-06 16:54 ` Wolfram Sang
2024-03-06 21:24 ` [PATCH v9 0/6] " Andi Shyti
2024-03-06 21:24 ` [PATCH v9 1/6] i2c: wmt: create wmt_i2c_init for general init Andi Shyti
2024-03-06 21:24 ` [PATCH v9 2/6] i2c: wmt: split out common files Andi Shyti
2024-03-06 21:24 ` [PATCH v9 3/6] i2c: wmt: rename something Andi Shyti
2024-03-06 21:24 ` [PATCH v9 4/6] i2c: wmt: fix a bug when thread blocked Andi Shyti
2024-03-06 21:24 ` [PATCH v9 5/6] i2c: wmt: add platform type VIAI2C_PLAT_WMT Andi Shyti
2024-03-06 21:24 ` [PATCH v9 6/6] i2c: add zhaoxin i2c controller driver Andi Shyti
2024-03-08 1:22 ` [PATCH v9 0/6] " Hans Hu
2024-03-08 12:30 ` Andi Shyti
2024-04-03 23:29 ` Andi Shyti
2024-04-07 1:36 ` Hans Hu
2024-04-08 2:54 ` [PATCH v10 " Hans Hu
2024-04-08 2:54 ` [PATCH v10 1/6] i2c: wmt: create wmt_i2c_init for general init Hans Hu
2024-04-23 11:23 ` Andi Shyti
2024-04-08 2:54 ` [PATCH v10 2/6] i2c: wmt: split out common files Hans Hu
2024-04-08 2:54 ` [PATCH v10 3/6] i2c: wmt: rename something Hans Hu
2024-04-23 11:54 ` Andi Shyti
2024-04-08 2:54 ` [PATCH v10 4/6] i2c: wmt: fix a bug when thread blocked Hans Hu
2024-04-08 2:54 ` [PATCH v10 5/6] i2c: wmt: add platform type VIAI2C_PLAT_WMT Hans Hu
2024-04-08 2:54 ` [PATCH v10 6/6] i2c: add zhaoxin i2c controller driver Hans Hu
2024-04-23 12:02 ` [PATCH v10 0/6] " Andi Shyti
2024-04-23 12:16 ` Hans Hu
2024-04-29 0:20 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x25mr2pv4atl3gdxyrirenuw7kxb4bkltupp2cksjjekys3ckw@5epxael2alol \
--to=andi.shyti@kernel.org \
--cc=cobechen@zhaoxin.com \
--cc=hanshu-oc@zhaoxin.com \
--cc=hanshu@zhaoxin.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).