From: Andi Shyti <andi.shyti@kernel.org>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: Abhinav Jain <jain.abhinav177@gmail.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
"javier.carrasco.cruz@gmail.com"
<javier.carrasco.cruz@gmail.com>,
Julia Lawall <julia.lawall@inria.fr>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup
Date: Tue, 16 Apr 2024 16:09:01 +0200 [thread overview]
Message-ID: <y5yjitgjf3v4tui6wrg5x4ltuaieugzgkk7aiggefqxfbezdev@t36fwhrzrxsz> (raw)
In-Reply-To: <ctfgvm32ga232lcxlanyu2cvcbybfgkwj5ovxzha6rq7yrf2sn@xduhb3qnssao>
On Tue, Apr 16, 2024 at 04:07:48PM +0200, Andi Shyti wrote:
> On Tue, Apr 16, 2024 at 03:59:13AM +0000, Chris Packham wrote:
> > On 16/04/24 08:54, Andi Shyti wrote:
> > >> /* Enable I2C interrupts for mpc5121 */
> > >> - node_ctrl = of_find_compatible_node(NULL, NULL,
> > >> - "fsl,mpc5121-i2c-ctrl");
> > >> + struct device_node *node_ctrl __free(device_node) =
> > > How have you tested this?
> >
> > I'm not sure I know anyone that still has a mpc5121. Maybe someone on
> > linuxppc-dev?
>
> that's why I was asking, this would be the first driver in i2c
> using Rob's __free(device_node).
Jonathan's, of course :-)
Andi
next prev parent reply other threads:[~2024-04-16 14:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 16:12 [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup Abhinav Jain
2024-04-15 20:54 ` Andi Shyti
2024-04-16 3:59 ` Chris Packham
2024-04-16 14:07 ` Andi Shyti
2024-04-16 14:09 ` Andi Shyti [this message]
2024-04-19 7:22 ` Michael Ellerman
2024-04-16 4:00 ` Chris Packham
2024-04-16 22:46 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y5yjitgjf3v4tui6wrg5x4ltuaieugzgkk7aiggefqxfbezdev@t36fwhrzrxsz \
--to=andi.shyti@kernel.org \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=jain.abhinav177@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).