From: Conor Dooley <conor.dooley@microchip.com>
To: Eric DeVolder <eric.devolder@oracle.com>
Cc: <linux@armlinux.org.uk>, <catalin.marinas@arm.com>,
<will@kernel.org>, <chenhuacai@kernel.org>,
<geert@linux-m68k.org>, <tsbogend@alpha.franken.de>,
<James.Bottomley@hansenpartnership.com>, <deller@gmx.de>,
<ysato@users.sourceforge.jp>, <dalias@libc.org>,
<glaubitz@physik.fu-berlin.de>, <tglx@linutronix.de>,
<mingo@redhat.com>, <bp@alien8.de>, <dave.hansen@linux.intel.com>,
<x86@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-ia64@vger.kernel.org>, <loongarch@lists.linux.dev>,
<linux-m68k@lists.linux-m68k.org>, <linux-mips@vger.kernel.org>,
<linux-parisc@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
<linux-riscv@lists.infradead.org>, <linux-s390@vger.kernel.org>,
<linux-sh@vger.kernel.org>, <kernel@xen0n.name>,
<mpe@ellerman.id.au>, <npiggin@gmail.com>,
<christophe.leroy@csgroup.eu>, <paul.walmsley@sifive.com>,
<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<hca@linux.ibm.com>, <gor@linux.ibm.com>,
<agordeev@linux.ibm.com>, <borntraeger@linux.ibm.com>,
<svens@linux.ibm.com>, <hpa@zytor.com>, <keescook@chromium.org>,
<paulmck@kernel.org>, <peterz@infradead.org>,
<frederic@kernel.org>, <akpm@linux-foundation.org>,
<ardb@kernel.org>, <samitolvanen@google.com>,
<juerg.haefliger@canonical.com>, <arnd@arndb.de>,
<rmk+kernel@armlinux.org.uk>, <linus.walleij@linaro.org>,
<sebastian.reichel@collabora.com>, <rppt@kernel.org>,
<kirill.shutemov@linux.intel.com>, <anshuman.khandual@arm.com>,
<ziy@nvidia.com>, <masahiroy@kernel.org>,
<ndesaulniers@google.com>, <mhiramat@kernel.org>,
<ojeda@kernel.org>, <thunder.leizhen@huawei.com>,
<xin3.li@intel.com>, <tj@kernel.org>,
<gregkh@linuxfoundation.org>, <tsi@tuyoix.net>, <bhe@redhat.com>,
<hbathini@linux.ibm.com>, <sourabhjain@linux.ibm.com>,
<boris.ostrovsky@oracle.com>, <konrad.wilk@oracle.com>
Subject: Re: [PATCH v3 11/13] riscv/kexec: refactor for kernel/Kconfig.kexec
Date: Wed, 28 Jun 2023 09:20:36 +0100 [thread overview]
Message-ID: <20230628-urologist-faction-42ebe5372206@wendy> (raw)
In-Reply-To: <20230626161332.183214-12-eric.devolder@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 3124 bytes --]
Hey Eric,
On Mon, Jun 26, 2023 at 12:13:30PM -0400, Eric DeVolder wrote:
> The kexec and crash kernel options are provided in the common
> kernel/Kconfig.kexec. Utilize the common options and provide
> the ARCH_SUPPORTS_ and ARCH_SELECTS_ entries to recreate the
> equivalent set of KEXEC and CRASH options.
I find this diff a little hard to follow (since the other half off the
change is in another patch), so it may be me missing something, but are
you sure?
>
> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
> ---
> arch/riscv/Kconfig | 48 ++++++++++++++--------------------------------
> 1 file changed, 14 insertions(+), 34 deletions(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 5966ad97c30c..c484abd9bbfd 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -585,48 +585,28 @@ config RISCV_BOOT_SPINWAIT
>
> If unsure what to do here, say N.
>
> -config KEXEC
> - bool "Kexec system call"
> - depends on MMU
> +config ARCH_SUPPORTS_KEXEC
> + def_bool MMU
> +
> +config ARCH_SELECTS_KEXEC
> + def_bool y
> + depends on KEXEC
> select HOTPLUG_CPU if SMP
> - select KEXEC_CORE
> - help
> - kexec is a system call that implements the ability to shutdown your
> - current kernel, and to start another kernel. It is like a reboot
> - but it is independent of the system firmware. And like a reboot
> - you can start any kernel with it, not just Linux.
>
> - The name comes from the similarity to the exec system call.
> +config ARCH_SUPPORTS_KEXEC_FILE
> + def_bool 64BIT && MMU && CRYPTO=y && CRYPTO_SHA256=y
This looks like a change to me. Previously, only KEXEC_PURGATORY
required these crypto options to be like so, but now KEXEC_FILE needs
them too.
What am I missing?
Cheers,
Conor.
>
> -config KEXEC_FILE
> - bool "kexec file based systmem call"
> - depends on 64BIT && MMU
> - select HAVE_IMA_KEXEC if IMA
> - select KEXEC_CORE
> +config ARCH_SELECTS_KEXEC_FILE
> + def_bool y
> + depends on KEXEC_FILE
> select KEXEC_ELF
> - help
> - This is new version of kexec system call. This system call is
> - file based and takes file descriptors as system call argument
> - for kernel and initramfs as opposed to list of segments as
> - accepted by previous system call.
> -
> - If you don't know what to do here, say Y.
> + select HAVE_IMA_KEXEC if IMA
>
> config ARCH_HAS_KEXEC_PURGATORY
> def_bool KEXEC_FILE
> - depends on CRYPTO=y
> - depends on CRYPTO_SHA256=y
>
> -config CRASH_DUMP
> - bool "Build kdump crash kernel"
> - help
> - Generate crash dump after being started by kexec. This should
> - be normally only set in special crash dump kernels which are
> - loaded in the main kernel with kexec-tools into a specially
> - reserved region and then later executed after a crash by
> - kdump/kexec.
> -
> - For more details see Documentation/admin-guide/kdump/kdump.rst
> +config ARCH_SUPPORTS_CRASH_DUMP
> + def_bool y
>
> config COMPAT
> bool "Kernel support for 32-bit U-mode"
> --
> 2.31.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-06-28 8:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 16:13 [PATCH v3 00/13] refactor Kconfig to consolidate KEXEC and CRASH options Eric DeVolder
2023-06-26 16:13 ` [PATCH v3 01/13] kexec: consolidate kexec and crash options into kernel/Kconfig.kexec Eric DeVolder
2023-06-26 16:19 ` Russell King (Oracle)
2023-06-26 16:33 ` Eric DeVolder
2023-06-26 16:13 ` [PATCH v3 02/13] x86/kexec: refactor for kernel/Kconfig.kexec Eric DeVolder
2023-06-26 16:13 ` [PATCH v3 03/13] arm/kexec: " Eric DeVolder
2023-06-26 16:13 ` [PATCH v3 04/13] ia64/kexec: " Eric DeVolder
2023-06-26 16:13 ` [PATCH v3 05/13] arm64/kexec: " Eric DeVolder
2023-06-26 16:13 ` [PATCH v3 06/13] loongarch/kexec: " Eric DeVolder
2023-06-26 16:13 ` [PATCH v3 07/13] m68k/kexec: " Eric DeVolder
2023-06-26 16:13 ` [PATCH v3 08/13] mips/kexec: " Eric DeVolder
2023-06-26 16:13 ` [PATCH v3 09/13] parisc/kexec: " Eric DeVolder
2023-06-26 16:13 ` [PATCH v3 10/13] powerpc/kexec: " Eric DeVolder
2023-06-26 16:13 ` [PATCH v3 11/13] riscv/kexec: " Eric DeVolder
2023-06-28 8:20 ` Conor Dooley [this message]
2023-06-28 13:30 ` Eric DeVolder
2023-06-26 16:13 ` [PATCH v3 12/13] s390/kexec: " Eric DeVolder
2023-06-30 13:07 ` Alexander Gordeev
2023-06-30 14:33 ` Eric DeVolder
2023-06-26 16:13 ` [PATCH v3 13/13] sh/kexec: " Eric DeVolder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230628-urologist-faction-42ebe5372206@wendy \
--to=conor.dooley@microchip.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=deller@gmx.de \
--cc=eric.devolder@oracle.com \
--cc=frederic@kernel.org \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hbathini@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=juerg.haefliger@canonical.com \
--cc=keescook@chromium.org \
--cc=kernel@xen0n.name \
--cc=kirill.shutemov@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=ndesaulniers@google.com \
--cc=npiggin@gmail.com \
--cc=ojeda@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=sebastian.reichel@collabora.com \
--cc=sourabhjain@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
--cc=tj@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=tsi@tuyoix.net \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xin3.li@intel.com \
--cc=ysato@users.sourceforge.jp \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).