From: Nicolas Schier <nicolas@fjasle.eu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH] ia64: simplify esi object addition in Makefile
Date: Thu, 29 Sep 2022 19:44:36 +0000 [thread overview]
Message-ID: <YzX1pC8KpAwLFzfq@fjasle.eu> (raw)
In-Reply-To: <20220929181715.2504087-1-masahiroy@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
On Fri, Sep 30, 2022 at 03:17:15AM +0900, Masahiro Yamada wrote:
> CONFIG_IA64_ESI is a bool option. I do not know why the Makefile was
> written like this, but this should not have any functional change.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/ia64/kernel/Makefile | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/ia64/kernel/Makefile b/arch/ia64/kernel/Makefile
> index 4a1fcb121dda..ae9ff07de4ab 100644
> --- a/arch/ia64/kernel/Makefile
> +++ b/arch/ia64/kernel/Makefile
> @@ -34,10 +34,7 @@ mca_recovery-y += mca_drv.o mca_drv_asm.o
> obj-$(CONFIG_IA64_MC_ERR_INJECT)+= err_inject.o
> obj-$(CONFIG_STACKTRACE) += stacktrace.o
>
> -obj-$(CONFIG_IA64_ESI) += esi.o
> -ifneq ($(CONFIG_IA64_ESI),)
> -obj-y += esi_stub.o # must be in kernel proper
> -endif
> +obj-$(CONFIG_IA64_ESI) += esi.o esi_stub.o # must be in kernel proper
> obj-$(CONFIG_INTEL_IOMMU) += pci-dma.o
>
> obj-$(CONFIG_ELF_CORE) += elfcore.o
> --
> 2.34.1
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-09-29 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 18:17 [PATCH] ia64: simplify esi object addition in Makefile Masahiro Yamada
2022-09-29 19:44 ` Nicolas Schier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzX1pC8KpAwLFzfq@fjasle.eu \
--to=nicolas@fjasle.eu \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).