From: Baoquan He <bhe@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu,
agordeev@linux.ibm.com, wangkefeng.wang@huawei.com,
schnelle@linux.ibm.com, David.Laight@aculab.com,
shorne@gmail.com, willy@infradead.org, deller@gmx.de,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH v5 RESEND 08/17] ia64: mm: Convert to GENERIC_IOREMAP
Date: Thu, 18 May 2023 03:44:32 +0000 [thread overview]
Message-ID: <ZGWfIIi2aH8SMTfZ@MiWiFi-R3L-srv> (raw)
In-Reply-To: <ZGR1IlBpIDe6fQms@infradead.org>
On 05/16/23 at 11:33pm, Christoph Hellwig wrote:
> > +#define ioremap_prot ioremap_prot
> > +#define ioremap_cache ioremap
> > #define ioremap_uc ioremap_uc
> > #define iounmap iounmap
>
> Same comment about the placement here, I'm not going to repeat it if
> it shows up in more patches.
Sure, Will check all of them and change, thanks.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
prev parent reply other threads:[~2023-05-18 3:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230515090848.833045-1-bhe@redhat.com>
2023-05-15 9:08 ` [PATCH v5 RESEND 08/17] ia64: mm: Convert to GENERIC_IOREMAP Baoquan He
2023-05-16 6:49 ` Mike Rapoport
2023-05-17 6:33 ` Christoph Hellwig
2023-05-18 3:44 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGWfIIi2aH8SMTfZ@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=David.Laight@aculab.com \
--cc=agordeev@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=christophe.leroy@csgroup.eu \
--cc=deller@gmx.de \
--cc=hch@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=schnelle@linux.ibm.com \
--cc=shorne@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).