From: Frank Scheiner <frank.scheiner@web.de>
To: linux-ia64@vger.kernel.org, rafael.j.wysocki@intel.com,
michal.wilczynski@intel.com
Cc: debian-ia64 <debian-ia64@lists.debian.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ard Biesheuvel <ardb@kernel.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Build regression since v6.6-rc1
Date: Thu, 21 Sep 2023 12:14:36 +0200 [thread overview]
Message-ID: <adc65a97-2479-8779-0e09-4ec2fe946cb2@web.de> (raw)
Dear all,
since v6.6-rc1 (actually introduced with [1], specific commit on [2])
the kernel build for ia64 fails like that:
```
Making kernel...
time make -j24
LOCALVERSION="-0bb80ecc33a8fb5a682236443c1e740d5c917d1d-ia64" ARCH=ia64
CROSS_COMPILE=ia64-linux- all
Mon Sep 11 06:24:43 PM CEST 2023
[...]
LD [M] net/sunrpc/sunrpc.ko
ia64-linux-ld: drivers/acpi/acpi_processor.o: in function
`acpi_early_processor_osc':
/usr/src/linux-on-ramdisk/torvalds-linux/drivers/acpi/acpi_processor.c:596:
undefined reference to `acpi_proc_quirk_mwait_check'
ia64-linux-ld: drivers/acpi/processor_pdc.o: in function
`acpi_early_processor_set_pdc':
/usr/src/linux-on-ramdisk/torvalds-linux/drivers/acpi/processor_pdc.c:113:
undefined reference to `acpi_proc_quirk_mwait_check'
make[2]: *** [scripts/Makefile.vmlinux:36: vmlinux] Error 1
make[1]: *** [/usr/src/linux-on-ramdisk/torvalds-linux/Makefile:1165:
vmlinux] Error 2
make: *** [Makefile:234: __sub-make] Error 2
real 3m25.286s
user 69m26.895s
sys 6m37.619s
2
```
[1]:
https://github.com/torvalds/linux/commit/9bd0c413b90c6517b4a2fbedb74f50df3421b50c
[2]: https://github.com/torvalds/linux/commit/0a0e2ea642f6
In short, the change introduced a function call ([3]) in effect for ia64
without providing an implementation for that function for ia64. There's
a discussion thread on [4] that also includes a patch ([5]) to "fix" the
problem but that one unfortunately wasn't included in [1] or [2]:
```
---
drivers/acpi/internal.h | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
Index: linux-pm/drivers/acpi/internal.h
===================================================================
--- linux-pm.orig/drivers/acpi/internal.h
+++ linux-pm/drivers/acpi/internal.h
@@ -148,8 +148,11 @@ int acpi_wakeup_device_init(void);
#ifdef CONFIG_ARCH_MIGHT_HAVE_ACPI_PDC
void acpi_early_processor_control_setup(void);
void acpi_early_processor_set_pdc(void);
-
+#ifdef CONFIG_X86
void acpi_proc_quirk_mwait_check(void);
+#else
+static inline void acpi_proc_quirk_mwait_check(void) {}
+#endif
bool processor_physically_present(acpi_handle handle);
#else
static inline void acpi_early_processor_control_setup(void) {}
```
For me this patch solves the build problem for v6.6-rc1 and -rc2.
There's also another patch available for that specific problem by Ard
([6]) but I haven't seen this one included either up until 42dc814 and I
also haven't tested this one.
Could one ([5]) or the other ([6]) please be included in v6.6 (or
earlier) to "fix" the build problem for ia64?
Cheers,
Frank
[3]:
https://github.com/torvalds/linux/commit/0a0e2ea642f6#diff-80c82874cec85e9c2facf52535b929ec62284c001ab081bfd1c1d164bf2a1d66R179
[4]:
https://lore.kernel.org/lkml/c7a05a44-c0be-46c2-a21d-b242524d482b@roeck-us.net/T/#u
[5]:
https://lore.kernel.org/lkml/CAJZ5v0hnNK4O_HyinvTp01YxXR7V4vzpMhf85yW9M2=52-O2Fg@mail.gmail.com/
[6]:
https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/commit/?id=a0334bf78b95532cec54f56b53e8ae1bfe7e1ca1
next reply other threads:[~2023-09-21 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 10:14 Frank Scheiner [this message]
2023-09-21 11:53 ` Build regression since v6.6-rc1 Ard Biesheuvel
2023-09-21 12:07 ` Frank Scheiner
2023-09-21 19:42 ` Wysocki, Rafael J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adc65a97-2479-8779-0e09-4ec2fe946cb2@web.de \
--to=frank.scheiner@web.de \
--cc=ardb@kernel.org \
--cc=debian-ia64@lists.debian.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-ia64@vger.kernel.org \
--cc=michal.wilczynski@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).