From: "Arnd Bergmann" <arnd@arndb.de>
To: "Thomas Zimmermann" <tzimmermann@suse.de>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Helge Deller" <deller@gmx.de>
Cc: linuxppc-dev@lists.ozlabs.org, linux-fbdev@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, sparclinux@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH v4 0/5] ppc, fbdev: Clean up fbdev mmap helper
Date: Wed, 20 Sep 2023 11:06:48 -0400 [thread overview]
Message-ID: <df784a58-23f8-43d2-8506-ab1d351da8fe@app.fastmail.com> (raw)
In-Reply-To: <20230912135050.17155-1-tzimmermann@suse.de>
On Tue, Sep 12, 2023, at 09:48, Thomas Zimmermann wrote:
> Clean up and rename fb_pgprotect() to work without struct file. Then
> refactor the implementation for PowerPC. This change has been discussed
> at [1] in the context of refactoring fbdev's mmap code.
>
> The first two patches update fbdev and replace fbdev's fb_pgprotect()
> with pgprot_framebuffer() on all architectures. The new helper's stream-
> lined interface enables more refactoring within fbdev's mmap
> implementation.
>
> Patches 3 to 5 adapt PowerPC's internal interfaces to provide
> phys_mem_access_prot() that works without struct file. Neither the
> architecture code or fbdev helpers need the parameter.
>
> v4:
> * fix commit message (Christophe)
> v3:
> * rename fb_pgrotect() to pgprot_framebuffer() (Arnd)
I had another look today, and everything look good to me now.
Whole series
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2023-09-20 15:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 13:48 [PATCH v4 0/5] ppc, fbdev: Clean up fbdev mmap helper Thomas Zimmermann
2023-09-12 13:48 ` [PATCH v4 1/5] fbdev: Avoid file argument in fb_pgprotect() Thomas Zimmermann
2023-09-20 8:01 ` Javier Martinez Canillas
2023-09-22 7:40 ` Thomas Zimmermann
2023-09-12 13:49 ` [PATCH v4 2/5] fbdev: Replace fb_pgprotect() with pgprot_framebuffer() Thomas Zimmermann
2023-09-13 8:09 ` Geert Uytterhoeven
2023-09-20 8:09 ` Javier Martinez Canillas
2023-09-12 13:49 ` [PATCH v4 3/5] arch/powerpc: Remove trailing whitespaces Thomas Zimmermann
2023-09-13 6:34 ` Philippe Mathieu-Daudé
2023-09-12 13:49 ` [PATCH v4 4/5] arch/powerpc: Remove file parameter from phys_mem_access_prot code Thomas Zimmermann
2023-09-12 13:49 ` [PATCH v4 5/5] arch/powerpc: Call internal __phys_mem_access_prot() in fbdev code Thomas Zimmermann
2023-09-18 7:32 ` [PATCH v4 0/5] ppc, fbdev: Clean up fbdev mmap helper Thomas Zimmermann
2023-09-20 15:06 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df784a58-23f8-43d2-8506-ab1d351da8fe@app.fastmail.com \
--to=arnd@arndb.de \
--cc=christophe.leroy@csgroup.eu \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=sparclinux@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).