* [PATCH] pata_samsung_cf: fix ata_host_activate() failure handling
@ 2014-03-31 17:52 Bartlomiej Zolnierkiewicz
2014-04-01 1:18 ` Jingoo Han
2014-04-15 12:49 ` Tejun Heo
0 siblings, 2 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2014-03-31 17:52 UTC (permalink / raw
To: Tejun Heo
Cc: Ben Dooks, Kukjin Kim, linux-ide, linux-samsung-soc,
linux-arm-kernel, linux-kernel
Add missing clk_disable() call to ata_host_activate() failure path.
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
drivers/ata/pata_samsung_cf.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
Index: b/drivers/ata/pata_samsung_cf.c
===================================================================
--- a/drivers/ata/pata_samsung_cf.c 2014-03-14 16:45:04.344724378 +0100
+++ b/drivers/ata/pata_samsung_cf.c 2014-03-31 18:31:58.083631437 +0200
@@ -594,9 +594,13 @@ static int __init pata_s3c_probe(struct
platform_set_drvdata(pdev, host);
- return ata_host_activate(host, info->irq,
- info->irq ? pata_s3c_irq : NULL,
- 0, &pata_s3c_sht);
+ ret = ata_host_activate(host, info->irq,
+ info->irq ? pata_s3c_irq : NULL,
+ 0, &pata_s3c_sht);
+ if (ret)
+ goto stop_clk;
+
+ return 0;
stop_clk:
clk_disable(info->clk);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pata_samsung_cf: fix ata_host_activate() failure handling
2014-03-31 17:52 [PATCH] pata_samsung_cf: fix ata_host_activate() failure handling Bartlomiej Zolnierkiewicz
@ 2014-04-01 1:18 ` Jingoo Han
2014-04-15 11:45 ` Bartlomiej Zolnierkiewicz
2014-04-15 12:49 ` Tejun Heo
1 sibling, 1 reply; 4+ messages in thread
From: Jingoo Han @ 2014-04-01 1:18 UTC (permalink / raw
To: 'Bartlomiej Zolnierkiewicz', 'Tejun Heo'
Cc: 'Ben Dooks', 'Kukjin Kim', linux-ide,
linux-samsung-soc, linux-arm-kernel, linux-kernel,
'Jingoo Han'
On Tuesday, April 01, 2014 2:53 AM, Tejun Heo wrote:
>
> Add missing clk_disable() call to ata_host_activate() failure path.
>
> Cc: Ben Dooks <ben-linux@fluff.org>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/ata/pata_samsung_cf.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> Index: b/drivers/ata/pata_samsung_cf.c
> ===================================================================
> --- a/drivers/ata/pata_samsung_cf.c 2014-03-14 16:45:04.344724378 +0100
> +++ b/drivers/ata/pata_samsung_cf.c 2014-03-31 18:31:58.083631437 +0200
> @@ -594,9 +594,13 @@ static int __init pata_s3c_probe(struct
>
> platform_set_drvdata(pdev, host);
>
> - return ata_host_activate(host, info->irq,
> - info->irq ? pata_s3c_irq : NULL,
> - 0, &pata_s3c_sht);
> + ret = ata_host_activate(host, info->irq,
> + info->irq ? pata_s3c_irq : NULL,
> + 0, &pata_s3c_sht);
> + if (ret)
> + goto stop_clk;
> +
> + return 0;
>
> stop_clk:
> clk_disable(info->clk);
>
> --
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pata_samsung_cf: fix ata_host_activate() failure handling
2014-04-01 1:18 ` Jingoo Han
@ 2014-04-15 11:45 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2014-04-15 11:45 UTC (permalink / raw
To: Jingoo Han
Cc: linux-samsung-soc, linux-kernel, linux-ide, 'Kukjin Kim',
'Ben Dooks', 'Tejun Heo', linux-arm-kernel
Hi,
Tejun, could you please also pick this one?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
On Tuesday, April 01, 2014 10:18:46 AM Jingoo Han wrote:
> On Tuesday, April 01, 2014 2:53 AM, Tejun Heo wrote:
> >
> > Add missing clk_disable() call to ata_host_activate() failure path.
> >
> > Cc: Ben Dooks <ben-linux@fluff.org>
> > Cc: Kukjin Kim <kgene.kim@samsung.com>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>
> Reviewed-by: Jingoo Han <jg1.han@samsung.com>
>
> Best regards,
> Jingoo Han
>
> > ---
> > drivers/ata/pata_samsung_cf.c | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > Index: b/drivers/ata/pata_samsung_cf.c
> > ===================================================================
> > --- a/drivers/ata/pata_samsung_cf.c 2014-03-14 16:45:04.344724378 +0100
> > +++ b/drivers/ata/pata_samsung_cf.c 2014-03-31 18:31:58.083631437 +0200
> > @@ -594,9 +594,13 @@ static int __init pata_s3c_probe(struct
> >
> > platform_set_drvdata(pdev, host);
> >
> > - return ata_host_activate(host, info->irq,
> > - info->irq ? pata_s3c_irq : NULL,
> > - 0, &pata_s3c_sht);
> > + ret = ata_host_activate(host, info->irq,
> > + info->irq ? pata_s3c_irq : NULL,
> > + 0, &pata_s3c_sht);
> > + if (ret)
> > + goto stop_clk;
> > +
> > + return 0;
> >
> > stop_clk:
> > clk_disable(info->clk);
> >
> > --
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pata_samsung_cf: fix ata_host_activate() failure handling
2014-03-31 17:52 [PATCH] pata_samsung_cf: fix ata_host_activate() failure handling Bartlomiej Zolnierkiewicz
2014-04-01 1:18 ` Jingoo Han
@ 2014-04-15 12:49 ` Tejun Heo
1 sibling, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2014-04-15 12:49 UTC (permalink / raw
To: Bartlomiej Zolnierkiewicz
Cc: Ben Dooks, Kukjin Kim, linux-ide, linux-samsung-soc,
linux-arm-kernel, linux-kernel
On Mon, Mar 31, 2014 at 07:52:44PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Add missing clk_disable() call to ata_host_activate() failure path.
>
> Cc: Ben Dooks <ben-linux@fluff.org>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Applied to libata/for-3.15-fixes.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-15 12:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-31 17:52 [PATCH] pata_samsung_cf: fix ata_host_activate() failure handling Bartlomiej Zolnierkiewicz
2014-04-01 1:18 ` Jingoo Han
2014-04-15 11:45 ` Bartlomiej Zolnierkiewicz
2014-04-15 12:49 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).