From: Damien Le Moal <dlemoal@kernel.org>
To: linux-ide@vger.kernel.org
Cc: linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
John Garry <john.g.garry@oracle.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Paul Ausbeck <paula@soe.ucsc.edu>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Joe Breuer <linux-kernel@jmbreuer.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Chia-Lin Kao <acelan.kao@canonical.com>
Subject: [PATCH v7 00/23] Fix libata suspend/resume handling and code cleanup
Date: Tue, 26 Sep 2023 17:14:44 +0900 [thread overview]
Message-ID: <20230926081507.69346-1-dlemoal@kernel.org> (raw)
The first 9 patches of this series fix several issues with suspend/resume
power management operations in scsi and libata. The most significant
changes introduced are in patch 4 and 5, where the manage_start_stop
flag of scsi devices is split into the manage_system_start_stop and
manage_runtime_start_stop flags to allow keeping scsi runtime power
operations for spining up/down ATA devices but have libata do its own
system suspend/resume device power state management using EH.
The remaining patches are code cleanup that do not introduce any
significant functional change.
This series was tested on qemu and on various PCs and servers. I am
CC-ing people who recently reported issues with suspend/resume.
Additional testing would be much appreciated.
Changes from v6:
* Changed patch 9 to use a bool for the new suspended flag.
Changes from v5:
* Typo and style corrections in patch 4 commit message
* Changed patch 9 to use a new flag to track a disk suspended state
instead of using the scsi device state
* Added review tags
Changes from v4:
* Remove ata_scsi_dev_alloc() function in patch 3, coding it directly
in ata_scsi_slave_alloc()
* Correct typo in patch 19 commit message
* Added Tested and review tags
Changes from v3:
* Corrected patch 1 (typo in commit message and WARN_ON() removal)
* Changed path 3 as suggested by Niklas (moved definition of
->slave_alloc)
* Rebased on rc2
* Added review tags
Changes from v2:
* Added patch 4 as simply disabling manage_start_stop from libata was
breaking individual disk runtime suspend/autosuspend. Patch 5 was
reworked accordingly to the changes in patch 4.
* Fixed patch 3: applying the link creation was missing and the link
creation itself was also incorrect, preventing sd probe to execute
correctly. Thanks to Geert for testing and reporting this issue.
* Split the "Fix delayed scsi_rescan_device() execution" patch into
patch 6 (scsi part) and patch 7 (ata part).
* Modified patch 9 to not call sd_shutdown() from sd_remove() for
devices that are not running.
* Added Chia-Lin Tested tag to unchanged patches
Changes from v1:
* Added patch 8 and 9 to fix compilation warnings with W=1
* Addressed John comment in patch 19
* Fixed patch 20 commit message (Sergei)
* Added Hannes Review tag
Damien Le Moal (23):
ata: libata-core: Fix ata_port_request_pm() locking
ata: libata-core: Fix port and device removal
ata: libata-scsi: link ata port and scsi device
scsi: sd: Differentiate system and runtime start/stop management
ata: libata-scsi: Disable scsi device manage_system_start_stop
scsi: Do not attempt to rescan suspended devices
ata: libata-scsi: Fix delayed scsi_rescan_device() execution
ata: libata-core: Do not register PM operations for SAS ports
scsi: sd: Do not issue commands to suspended disks on shutdown
ata: libata-core: Fix compilation warning in ata_dev_config_ncq()
ata: libata-eh: Fix compilation warning in ata_eh_link_report()
scsi: Remove scsi device no_start_on_resume flag
ata: libata-scsi: Cleanup ata_scsi_start_stop_xlat()
ata: libata-core: Synchronize ata_port_detach() with hotplug
ata: libata-core: Detach a port devices on shutdown
ata: libata-core: Remove ata_port_suspend_async()
ata: libata-core: Remove ata_port_resume_async()
ata: libata-core: Do not poweroff runtime suspended ports
ata: libata-core: Do not resume runtime suspended ports
ata: libata-sata: Improve ata_sas_slave_configure()
ata: libata-eh: Improve reset error messages
ata: libata-eh: Reduce "disable device" message verbosity
ata: libata: Cleanup inline DMA helper functions
drivers/ata/libata-core.c | 242 +++++++++++++++++++++++++--------
drivers/ata/libata-eh.c | 76 +++++++++--
drivers/ata/libata-sata.c | 5 +-
drivers/ata/libata-scsi.c | 142 ++++++++++---------
drivers/ata/libata-transport.c | 9 +-
drivers/ata/libata.h | 6 +
drivers/firewire/sbp2.c | 9 +-
drivers/scsi/scsi_scan.c | 18 ++-
drivers/scsi/sd.c | 102 +++++++++++---
drivers/scsi/sd.h | 1 +
include/linux/libata.h | 26 ++--
include/scsi/scsi_device.h | 4 +-
include/scsi/scsi_host.h | 2 +-
13 files changed, 457 insertions(+), 185 deletions(-)
--
2.41.0
next reply other threads:[~2023-09-26 8:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 8:14 Damien Le Moal [this message]
2023-09-26 8:14 ` [PATCH v7 01/23] ata: libata-core: Fix ata_port_request_pm() locking Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 02/23] ata: libata-core: Fix port and device removal Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 03/23] ata: libata-scsi: link ata port and scsi device Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 04/23] scsi: sd: Differentiate system and runtime start/stop management Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 05/23] ata: libata-scsi: Disable scsi device manage_system_start_stop Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 06/23] scsi: Do not attempt to rescan suspended devices Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 07/23] ata: libata-scsi: Fix delayed scsi_rescan_device() execution Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 08/23] ata: libata-core: Do not register PM operations for SAS ports Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 09/23] scsi: sd: Do not issue commands to suspended disks on shutdown Damien Le Moal
2023-09-27 7:46 ` Hannes Reinecke
2023-09-27 14:55 ` Bart Van Assche
2023-09-27 15:52 ` Damien Le Moal
2023-09-27 16:29 ` Bart Van Assche
2023-09-26 8:14 ` [PATCH v7 10/23] ata: libata-core: Fix compilation warning in ata_dev_config_ncq() Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 11/23] ata: libata-eh: Fix compilation warning in ata_eh_link_report() Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 12/23] scsi: Remove scsi device no_start_on_resume flag Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 13/23] ata: libata-scsi: Cleanup ata_scsi_start_stop_xlat() Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 14/23] ata: libata-core: Synchronize ata_port_detach() with hotplug Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 15/23] ata: libata-core: Detach a port devices on shutdown Damien Le Moal
2023-09-26 8:15 ` [PATCH v7 16/23] ata: libata-core: Remove ata_port_suspend_async() Damien Le Moal
2023-09-26 8:15 ` [PATCH v7 17/23] ata: libata-core: Remove ata_port_resume_async() Damien Le Moal
2023-09-26 8:15 ` [PATCH v7 18/23] ata: libata-core: Do not poweroff runtime suspended ports Damien Le Moal
2023-09-26 8:15 ` [PATCH v7 19/23] ata: libata-core: Do not resume " Damien Le Moal
2023-09-26 8:15 ` [PATCH v7 20/23] ata: libata-sata: Improve ata_sas_slave_configure() Damien Le Moal
2023-09-26 8:15 ` [PATCH v7 21/23] ata: libata-eh: Improve reset error messages Damien Le Moal
2023-09-26 8:15 ` [PATCH v7 22/23] ata: libata-eh: Reduce "disable device" message verbosity Damien Le Moal
2023-09-26 8:15 ` [PATCH v7 23/23] ata: libata: Cleanup inline DMA helper functions Damien Le Moal
2023-09-28 12:26 ` [PATCH v7 00/23] Fix libata suspend/resume handling and code cleanup Geert Uytterhoeven
2023-09-28 12:39 ` Damien Le Moal
2023-09-29 13:37 ` Damien Le Moal
2023-09-29 13:56 ` Geert Uytterhoeven
2023-09-29 14:29 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926081507.69346-1-dlemoal@kernel.org \
--to=dlemoal@kernel.org \
--cc=acelan.kao@canonical.com \
--cc=geert@linux-m68k.org \
--cc=john.g.garry@oracle.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@jmbreuer.net \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=paula@soe.ucsc.edu \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).