From: Ondrej Zary <linux@zary.sk>
To: Damien Le Moal <dlemoal@kernel.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
Sergey Shtylyov <s.shtylyov@omp.ru>, Tim Waugh <tim@cyberelk.net>,
linux-parport@lists.infradead.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] ata: pata_parport: fix pata_parport_devchk
Date: Thu, 5 Oct 2023 22:55:56 +0200 [thread overview]
Message-ID: <20231005205559.6504-2-linux@zary.sk> (raw)
In-Reply-To: <20231005205559.6504-1-linux@zary.sk>
There's a 'x' missing in 0x55 in pata_parport_devchk(), causing the
detection to always fail. Fix it.
Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)")
Cc: stable@vger.kernel.org
Signed-off-by: Ondrej Zary <linux@zary.sk>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/ata/pata_parport/pata_parport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c
index 1af64d435d3c..258d189f42e5 100644
--- a/drivers/ata/pata_parport/pata_parport.c
+++ b/drivers/ata/pata_parport/pata_parport.c
@@ -64,7 +64,7 @@ static bool pata_parport_devchk(struct ata_port *ap, unsigned int device)
pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0xaa);
pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0x55);
- pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 055);
+ pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0x55);
pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0xaa);
nsect = pi->proto->read_regr(pi, 0, ATA_REG_NSECT);
--
Ondrej Zary
next prev parent reply other threads:[~2023-10-05 20:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 20:55 [PATCH v4 0/4] ata: pata_parport: fix EXP Computer CD-865 with MC-1285B EPP cable Ondrej Zary
2023-10-05 20:55 ` Ondrej Zary [this message]
2023-10-05 20:55 ` [PATCH 2/4] ata: pata_parport: implement set_devctl Ondrej Zary
2023-10-05 20:55 ` [PATCH 3/4] ata: pata_parport: add custom version of wait_after_reset Ondrej Zary
2023-10-05 20:55 ` [PATCH 4/4] ata: pata_parport: fit3: implement IDE command set registers Ondrej Zary
2023-10-06 9:47 ` [PATCH v4 0/4] ata: pata_parport: fix EXP Computer CD-865 with MC-1285B EPP cable Damien Le Moal
-- strict thread matches above, loose matches on Subject: below --
2023-10-05 19:24 [PATCH v3 " Ondrej Zary
2023-10-05 19:24 ` [PATCH 1/4] ata: pata_parport: fix pata_parport_devchk Ondrej Zary
2023-10-05 19:41 ` Sergei Shtylyov
2023-10-05 19:45 ` Sergey Shtylyov
2023-10-04 18:52 [PATCH v2 0/4] ata: pata_parport: fix EXP Computer CD-865 with MC-1285B EPP cable Ondrej Zary
2023-10-04 18:52 ` [PATCH 1/4] ata: pata_parport: fix pata_parport_devchk Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005205559.6504-2-linux@zary.sk \
--to=linux@zary.sk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=s.shtylyov@omp.ru \
--cc=sudipm.mukherjee@gmail.com \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).