From: Gustav Ekelund <gustav.ekelund@axis.com>
To: <dlemoal@kernel.org>, <cassel@kernel.org>, <hare@suse.de>,
<martin.petersen@oracle.com>
Cc: <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel@axis.com>, <gustav.ekelund@axis.com>
Subject: [PATCH] ata: Add sdev attribute to lower link speed in runtime
Date: Fri, 12 Apr 2024 15:48:38 +0200 [thread overview]
Message-ID: <20240412134838.788502-1-gustav.ekelund@axis.com> (raw)
Expose a new sysfs attribute to userspace that gives root the ability to
lower the link speed in a scsi_device at runtime. The handle enables
programs to, based on external circumstances that may be unbeknownst to
the kernel, determine if a link should slow down to perhaps achieve a
stabler signal. External circumstances could include the mission time
of the connected hardware or observations to temperature trends.
Writing 1 to /sys/block/*/device/down_link_spd signals the kernel to
first lower the link speed one step with sata_down_spd_limit and then
finish off with sata_link_hardreset.
Signed-off-by: Gustav Ekelund <gustav.ekelund@axis.com>
---
Documentation/ABI/testing/sysfs-block-device | 13 +++++++++
drivers/ata/libahci.c | 1 +
drivers/ata/libata-sata.c | 29 ++++++++++++++++++++
include/linux/libata.h | 1 +
4 files changed, 44 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-block-device b/Documentation/ABI/testing/sysfs-block-device
index 2d543cfa4079..dba537fdf787 100644
--- a/Documentation/ABI/testing/sysfs-block-device
+++ b/Documentation/ABI/testing/sysfs-block-device
@@ -117,3 +117,16 @@ Description:
Writing "1" to this file enables the use of command duration
limits for read and write commands in the kernel and turns on
the feature on the device. Writing "0" disables the feature.
+
+
+What: /sys/block/*/device/down_link_spd
+Date: Mar, 2024
+KernelVersion: v6.10
+Contact: linux-ide@vger.kernel.org
+Description:
+ (WO) Write 1 to the file to lower the SATA link speed one step
+ and then hard reset. Other values are rejected with -EINVAL.
+
+ Consider using libata.force for setting the link speed at boot.
+ Resort to down_link_spd in systems that deem it useful to lower
+ the link speed at runtime for particular links.
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 1a63200ea437..2622e965d98c 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -138,6 +138,7 @@ static struct attribute *ahci_sdev_attrs[] = {
&dev_attr_unload_heads.attr,
&dev_attr_ncq_prio_supported.attr,
&dev_attr_ncq_prio_enable.attr,
+ &dev_attr_down_link_spd.attr,
NULL
};
diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c
index 0fb1934875f2..5e1257b15f95 100644
--- a/drivers/ata/libata-sata.c
+++ b/drivers/ata/libata-sata.c
@@ -1538,3 +1538,32 @@ void ata_eh_analyze_ncq_error(struct ata_link *link)
ehc->i.err_mask &= ~AC_ERR_DEV;
}
EXPORT_SYMBOL_GPL(ata_eh_analyze_ncq_error);
+
+static ssize_t down_link_spd_store(struct device *device,
+ struct device_attribute *attr,
+ const char *buf, size_t len)
+{
+ struct scsi_device *sdev;
+ struct ata_port *ap;
+ long input;
+ int rc;
+
+ rc = kstrtol(buf, 10, &input);
+ if (rc)
+ return rc;
+ if ((input < 0) || (input > 1))
+ return -EINVAL;
+
+ sdev = to_scsi_device(device);
+ ap = ata_shost_to_port(sdev->host);
+
+ rc = sata_down_spd_limit(&ap->link, 0);
+ if (rc)
+ return rc;
+ rc = sata_link_hardreset(&ap->link, sata_deb_timing_normal,
+ ata_deadline(jiffies, ATA_TMOUT_INTERNAL_QUICK), NULL, NULL);
+
+ return rc ? rc : len;
+}
+DEVICE_ATTR_WO(down_link_spd);
+EXPORT_SYMBOL_GPL(dev_attr_down_link_spd);
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 26d68115afb8..51d23a60355b 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -510,6 +510,7 @@ extern struct device_attribute dev_attr_ncq_prio_enable;
extern struct device_attribute dev_attr_em_message_type;
extern struct device_attribute dev_attr_em_message;
extern struct device_attribute dev_attr_sw_activity;
+extern struct device_attribute dev_attr_down_link_spd;
#endif
enum sw_activity {
--
2.39.2
next reply other threads:[~2024-04-12 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 13:48 Gustav Ekelund [this message]
2024-04-12 16:59 ` [PATCH] ata: Add sdev attribute to lower link speed in runtime Niklas Cassel
2024-04-13 0:29 ` Damien Le Moal
2024-04-15 14:49 ` Gustav Ekelund
2024-04-16 22:59 ` Damien Le Moal
2024-04-17 9:20 ` Gustav Ekelund
2024-04-17 9:56 ` Niklas Cassel
2024-04-17 10:14 ` Niklas Cassel
2024-04-18 12:47 ` Gustav Ekelund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412134838.788502-1-gustav.ekelund@axis.com \
--to=gustav.ekelund@axis.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=kernel@axis.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).