Linux-ide Archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: ata: tegra: Disallow undefined properties
@ 2023-10-16 15:55 Rob Herring
  2023-10-17 10:50 ` Conor Dooley
  2023-10-17 23:08 ` Damien Le Moal
  0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2023-10-16 15:55 UTC (permalink / raw
  To: Damien Le Moal, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
	Jonathan Hunter
  Cc: linux-ide, devicetree, linux-tegra, linux-kernel

Device specific bindings should not allow undefined properties. This is
accomplished in json-schema with 'additionalProperties: false'.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
index 3c7a2425f3e6..a17297cbefcb 100644
--- a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
+++ b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
@@ -151,7 +151,7 @@ allOf:
         - interconnects
         - power-domains
 
-additionalProperties: true
+additionalProperties: false
 
 examples:
   - |
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: ata: tegra: Disallow undefined properties
  2023-10-16 15:55 [PATCH] dt-bindings: ata: tegra: Disallow undefined properties Rob Herring
@ 2023-10-17 10:50 ` Conor Dooley
  2023-10-17 23:08 ` Damien Le Moal
  1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-10-17 10:50 UTC (permalink / raw
  To: Rob Herring
  Cc: Damien Le Moal, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
	Jonathan Hunter, linux-ide, devicetree, linux-tegra, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

On Mon, Oct 16, 2023 at 10:55:54AM -0500, Rob Herring wrote:
> Device specific bindings should not allow undefined properties. This is
> accomplished in json-schema with 'additionalProperties: false'.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
> index 3c7a2425f3e6..a17297cbefcb 100644
> --- a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
> +++ b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
> @@ -151,7 +151,7 @@ allOf:
>          - interconnects
>          - power-domains
>  
> -additionalProperties: true
> +additionalProperties: false
>  
>  examples:
>    - |
> -- 
> 2.42.0
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: ata: tegra: Disallow undefined properties
  2023-10-16 15:55 [PATCH] dt-bindings: ata: tegra: Disallow undefined properties Rob Herring
  2023-10-17 10:50 ` Conor Dooley
@ 2023-10-17 23:08 ` Damien Le Moal
  1 sibling, 0 replies; 3+ messages in thread
From: Damien Le Moal @ 2023-10-17 23:08 UTC (permalink / raw
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
	Jonathan Hunter
  Cc: linux-ide, devicetree, linux-tegra, linux-kernel

On 10/17/23 00:55, Rob Herring wrote:
> Device specific bindings should not allow undefined properties. This is
> accomplished in json-schema with 'additionalProperties: false'.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Applied to for-6.7. Thanks !

-- 
Damien Le Moal
Western Digital Research


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-10-17 23:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-16 15:55 [PATCH] dt-bindings: ata: tegra: Disallow undefined properties Rob Herring
2023-10-17 10:50 ` Conor Dooley
2023-10-17 23:08 ` Damien Le Moal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).