From: Niklas Cassel <cassel@kernel.org>
To: Igor Pylypiv <ipylypiv@google.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
John Garry <john.g.garry@oracle.com>,
Jason Yan <yanaijie@huawei.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
Hannes Reinecke <hare@suse.de>,
Xiang Chen <chenxiang66@hisilicon.com>,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
Bart Van Assche <bvanassche@acm.org>,
TJ Adams <tadamsjr@google.com>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 6/7] scsi: aic94xx: Add libsas SATA sysfs attributes group
Date: Wed, 6 Mar 2024 11:55:48 +0100 [thread overview]
Message-ID: <ZehLtGYczWmIvcwy@ryzen> (raw)
In-Reply-To: <20240306012226.3398927-7-ipylypiv@google.com>
On Tue, Mar 05, 2024 at 05:22:25PM -0800, Igor Pylypiv wrote:
> The added sysfs attributes group enables the configuration of NCQ Priority
> feature for HBAs that rely on libsas to manage SATA devices.
>
> Reviewed-by: John Garry <john.g.garry@oracle.com>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> Reviewed-by: Jason Yan <yanaijie@huawei.com>
> Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
> ---
> drivers/scsi/aic94xx/aic94xx_init.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
> index 8a3340d8d7ad..ccccd0eb6275 100644
> --- a/drivers/scsi/aic94xx/aic94xx_init.c
> +++ b/drivers/scsi/aic94xx/aic94xx_init.c
> @@ -14,6 +14,7 @@
> #include <linux/firmware.h>
> #include <linux/slab.h>
>
> +#include <scsi/sas_ata.h>
> #include <scsi/scsi_host.h>
>
> #include "aic94xx.h"
> @@ -34,6 +35,7 @@ MODULE_PARM_DESC(use_msi, "\n"
> static struct scsi_transport_template *aic94xx_transport_template;
> static int asd_scan_finished(struct Scsi_Host *, unsigned long);
> static void asd_scan_start(struct Scsi_Host *);
> +static const struct attribute_group *asd_sdev_groups[];
>
> static const struct scsi_host_template aic94xx_sht = {
> .module = THIS_MODULE,
> @@ -60,6 +62,7 @@ static const struct scsi_host_template aic94xx_sht = {
> .compat_ioctl = sas_ioctl,
> #endif
> .track_queue_depth = 1,
> + .sdev_groups = asd_sdev_groups,
> };
>
> static int asd_map_memio(struct asd_ha_struct *asd_ha)
> @@ -951,6 +954,11 @@ static void asd_remove_driver_attrs(struct device_driver *driver)
> driver_remove_file(driver, &driver_attr_version);
> }
>
> +static const struct attribute_group *asd_sdev_groups[] = {
> + &sas_ata_sdev_attr_group,
> + NULL
> +};
If you move this in front of:
static const struct scsi_host_template aic94xx_sht = { };
I think that you can remove the forward declaration.
> +
> static struct sas_domain_function_template aic94xx_transport_functions = {
> .lldd_dev_found = asd_dev_found,
> .lldd_dev_gone = asd_dev_gone,
> --
> 2.44.0.278.ge034bb2e1d-goog
>
next prev parent reply other threads:[~2024-03-06 10:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 1:22 [PATCH v7 0/7] NCQ Priority sysfs sttributes for libsas Igor Pylypiv
2024-03-06 1:22 ` [PATCH v7 1/7] ata: libata-sata: Factor out NCQ Priority configuration helpers Igor Pylypiv
2024-03-06 10:54 ` Niklas Cassel
2024-03-06 1:22 ` [PATCH v7 2/7] scsi: libsas: Define NCQ Priority sysfs attributes for SATA devices Igor Pylypiv
2024-03-06 10:54 ` Niklas Cassel
2024-03-06 19:28 ` Igor Pylypiv
2024-03-07 9:51 ` Niklas Cassel
2024-03-07 21:41 ` Igor Pylypiv
2024-03-06 1:22 ` [PATCH v7 3/7] scsi: pm80xx: Add libsas SATA sysfs attributes group Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel
2024-03-06 1:22 ` [PATCH v7 4/7] scsi: mvsas: " Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel
2024-03-06 21:13 ` Igor Pylypiv
2024-03-07 9:52 ` Niklas Cassel
2024-03-07 20:35 ` Igor Pylypiv
2024-03-06 1:22 ` [PATCH v7 5/7] scsi: hisi_sas: " Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel
2024-03-06 20:56 ` Igor Pylypiv
2024-03-07 8:55 ` John Garry
2024-03-07 9:59 ` Niklas Cassel
2024-03-07 11:17 ` John Garry
2024-03-06 1:22 ` [PATCH v7 6/7] scsi: aic94xx: " Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel [this message]
2024-03-06 21:17 ` Igor Pylypiv
2024-03-06 1:22 ` [PATCH v7 7/7] scsi: isci: " Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel
2024-03-06 10:54 ` [PATCH v7 0/7] NCQ Priority sysfs sttributes for libsas Niklas Cassel
2024-03-06 21:33 ` Igor Pylypiv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZehLtGYczWmIvcwy@ryzen \
--to=cassel@kernel.org \
--cc=artur.paszkiewicz@intel.com \
--cc=bvanassche@acm.org \
--cc=chenxiang66@hisilicon.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=ipylypiv@google.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tadamsjr@google.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).