From: Igor Pylypiv <ipylypiv@google.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: Damien Le Moal <dlemoal@kernel.org>,
John Garry <john.g.garry@oracle.com>,
Jason Yan <yanaijie@huawei.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
Hannes Reinecke <hare@suse.de>,
Xiang Chen <chenxiang66@hisilicon.com>,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
Bart Van Assche <bvanassche@acm.org>,
TJ Adams <tadamsjr@google.com>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes group
Date: Wed, 6 Mar 2024 12:56:15 -0800 [thread overview]
Message-ID: <ZejYb4ykeF7Qx5a5@google.com> (raw)
In-Reply-To: <ZehLpV06mpHxjecc@ryzen>
On Wed, Mar 06, 2024 at 11:55:33AM +0100, Niklas Cassel wrote:
> On Tue, Mar 05, 2024 at 05:22:24PM -0800, Igor Pylypiv wrote:
> > The added sysfs attributes group enables the configuration of NCQ Priority
> > feature for HBAs that rely on libsas to manage SATA devices.
> >
> > Reviewed-by: John Garry <john.g.garry@oracle.com>
> > Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> > Reviewed-by: Jason Yan <yanaijie@huawei.com>
> > Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
> > ---
> > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++++++
> > drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++++++
>
> Is there a reason why you didn't patch:
> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c ?
>
I originally patched hisi_sas_v1_hw.c as well. John Garry pointed out
that v1 HW doesn't support SATA so I dropped the change.
>
> > 2 files changed, 12 insertions(+)
> >
> > diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> > index 73b378837da7..b5d379ebe05d 100644
> > --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> > +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> > @@ -3544,6 +3544,11 @@ static struct attribute *host_v2_hw_attrs[] = {
> >
> > ATTRIBUTE_GROUPS(host_v2_hw);
> >
> > +static const struct attribute_group *sdev_groups_v2_hw[] = {
> > + &sas_ata_sdev_attr_group,
> > + NULL
> > +};
> > +
> > static void map_queues_v2_hw(struct Scsi_Host *shost)
> > {
> > struct hisi_hba *hisi_hba = shost_priv(shost);
> > @@ -3585,6 +3590,7 @@ static const struct scsi_host_template sht_v2_hw = {
> > .compat_ioctl = sas_ioctl,
> > #endif
> > .shost_groups = host_v2_hw_groups,
> > + .sdev_groups = sdev_groups_v2_hw,
> > .host_reset = hisi_sas_host_reset,
> > .map_queues = map_queues_v2_hw,
> > .host_tagset = 1,
> > diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> > index b56fbc61a15a..9b69ea16a1e6 100644
> > --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> > +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> > @@ -2929,6 +2929,11 @@ static struct attribute *host_v3_hw_attrs[] = {
> >
> > ATTRIBUTE_GROUPS(host_v3_hw);
> >
> > +static const struct attribute_group *sdev_groups_v3_hw[] = {
> > + &sas_ata_sdev_attr_group,
> > + NULL
> > +};
> > +
> > #define HISI_SAS_DEBUGFS_REG(x) {#x, x}
> >
> > struct hisi_sas_debugfs_reg_lu {
> > @@ -3340,6 +3345,7 @@ static const struct scsi_host_template sht_v3_hw = {
> > .compat_ioctl = sas_ioctl,
> > #endif
> > .shost_groups = host_v3_hw_groups,
> > + .sdev_groups = sdev_groups_v3_hw,
> > .tag_alloc_policy = BLK_TAG_ALLOC_RR,
> > .host_reset = hisi_sas_host_reset,
> > .host_tagset = 1,
> > --
> > 2.44.0.278.ge034bb2e1d-goog
> >
next prev parent reply other threads:[~2024-03-06 20:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 1:22 [PATCH v7 0/7] NCQ Priority sysfs sttributes for libsas Igor Pylypiv
2024-03-06 1:22 ` [PATCH v7 1/7] ata: libata-sata: Factor out NCQ Priority configuration helpers Igor Pylypiv
2024-03-06 10:54 ` Niklas Cassel
2024-03-06 1:22 ` [PATCH v7 2/7] scsi: libsas: Define NCQ Priority sysfs attributes for SATA devices Igor Pylypiv
2024-03-06 10:54 ` Niklas Cassel
2024-03-06 19:28 ` Igor Pylypiv
2024-03-07 9:51 ` Niklas Cassel
2024-03-07 21:41 ` Igor Pylypiv
2024-03-06 1:22 ` [PATCH v7 3/7] scsi: pm80xx: Add libsas SATA sysfs attributes group Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel
2024-03-06 1:22 ` [PATCH v7 4/7] scsi: mvsas: " Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel
2024-03-06 21:13 ` Igor Pylypiv
2024-03-07 9:52 ` Niklas Cassel
2024-03-07 20:35 ` Igor Pylypiv
2024-03-06 1:22 ` [PATCH v7 5/7] scsi: hisi_sas: " Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel
2024-03-06 20:56 ` Igor Pylypiv [this message]
2024-03-07 8:55 ` John Garry
2024-03-07 9:59 ` Niklas Cassel
2024-03-07 11:17 ` John Garry
2024-03-06 1:22 ` [PATCH v7 6/7] scsi: aic94xx: " Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel
2024-03-06 21:17 ` Igor Pylypiv
2024-03-06 1:22 ` [PATCH v7 7/7] scsi: isci: " Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel
2024-03-06 10:54 ` [PATCH v7 0/7] NCQ Priority sysfs sttributes for libsas Niklas Cassel
2024-03-06 21:33 ` Igor Pylypiv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZejYb4ykeF7Qx5a5@google.com \
--to=ipylypiv@google.com \
--cc=artur.paszkiewicz@intel.com \
--cc=bvanassche@acm.org \
--cc=cassel@kernel.org \
--cc=chenxiang66@hisilicon.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tadamsjr@google.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).