From: Michal Simek <michal.simek@amd.com>
To: Jonathan Cameron <jic23@kernel.org>,
Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Cc: Pedro Mariano <pedro.mariano@usp.br>,
anand.ashok.dumbre@xilinx.com,
Roberto Bolgheroni <robertobolgheroni@usp.br>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] iio: adc: xilinx-ams: Use device_for_each_child_node_scoped()
Date: Mon, 29 Apr 2024 08:28:59 +0200 [thread overview]
Message-ID: <03a2d7e2-7feb-4b36-bd48-7a83a75cf118@amd.com> (raw)
In-Reply-To: <20240428171725.5c24b858@jic23-huawei>
On 4/28/24 18:17, Jonathan Cameron wrote:
> On Sat, 27 Apr 2024 06:13:01 -0300
> Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote:
>
>> Hi Pedro, Roberto,
>>
>> Patch looks overall good except for the _scoped() function name and arguments,
>> must have been miss-typed or miss-copied somehow.
>> Comment inline.
>>
>> Regards,
>> Marcelo
>>
>> On 04/24, Pedro Mariano wrote:
>>> Using device_for_each_child_node_scoped instead of
>>> device_for_each_child_node automatically releases the handle on early exit
>>> which reduces the chance of bugs that cause resource leaks.
>>>
>>> Co-developed-by: Roberto Bolgheroni <robertobolgheroni@usp.br>
>>> Signed-off-by: Roberto Bolgheroni <robertobolgheroni@usp.br>
>>> Signed-off-by: Pedro Mariano <pedro.mariano@usp.br>
>>> ---
>>> drivers/iio/adc/xilinx-ams.c | 7 ++-----
>>> 1 file changed, 2 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
>>> index f0b71a122..7f5571d9d 100644
>>> --- a/drivers/iio/adc/xilinx-ams.c
>>> +++ b/drivers/iio/adc/xilinx-ams.c
>>> @@ -1261,7 +1261,6 @@ static int ams_parse_firmware(struct iio_dev *indio_dev)
>>> struct ams *ams = iio_priv(indio_dev);
>>> struct iio_chan_spec *ams_channels, *dev_channels;
>>> struct device *dev = indio_dev->dev.parent;
>>> - struct fwnode_handle *child = NULL;
>>> struct fwnode_handle *fwnode = dev_fwnode(dev);
>>> size_t ams_size;
>>> int ret, ch_cnt = 0, i, rising_off, falling_off;
>>> @@ -1283,13 +1282,11 @@ static int ams_parse_firmware(struct iio_dev *indio_dev)
>>> num_channels += ret;
>>> }
>>>
>>> - fwnode_for_each_child_node(fwnode, child) {
>>> + fwnode_for_each_child_node_scoped(fwnode, child) {
>> should be
>> device_for_each_child_node_scoped(dev, child) {
>
> Yes, we didn't bother with a fwnode specific version of this macro because they
> aren't nearly as common. I'm not sure why this driver didn't always use the
> device form or why it needs the fwnode_device_is_available()
> I suspect this dates back to some confusion on why there were _available variants.
>
> Chances are this driver only cares about DT and in that case the callback used is
That's correct. We are using this driver on DT system.
Thanks,
Michal
prev parent reply other threads:[~2024-04-29 6:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 22:53 [PATCH] iio: adc: xilinx-ams: Use device_for_each_child_node_scoped() Pedro Mariano
2024-04-27 9:13 ` Marcelo Schmitt
2024-04-28 16:17 ` Jonathan Cameron
2024-04-29 6:28 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03a2d7e2-7feb-4b36-bd48-7a83a75cf118@amd.com \
--to=michal.simek@amd.com \
--cc=anand.ashok.dumbre@xilinx.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=pedro.mariano@usp.br \
--cc=robertobolgheroni@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).