From: David Lechner <dlechner@baylibre.com>
To: "Nuno Sá" <noname.nuno@gmail.com>, nuno.sa@analog.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Dragos Bogdan <dragos.bogdan@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Olivier Moysan <olivier.moysan@foss.st.com>
Subject: Re: [PATCH v3 07/10] dt-bindings: iio: dac: add docs for AD9739A
Date: Mon, 15 Apr 2024 08:51:25 -0500 [thread overview]
Message-ID: <179a795a-f012-4c0e-a615-c1ab3ba9093d@baylibre.com> (raw)
In-Reply-To: <304de7549627332ebdda77cd0c00b327f7a7c188.camel@gmail.com>
On 4/15/24 7:25 AM, Nuno Sá wrote:
> On Fri, 2024-04-12 at 18:47 -0500, David Lechner wrote:
>> On Fri, Apr 12, 2024 at 8:36 AM Nuno Sa via B4 Relay
>> <devnull+nuno.sa.analog.com@kernel.org> wrote:
>>>
>>> From: Nuno Sa <nuno.sa@analog.com>
>>>
>>
>> ...
>>
>>> + adi,full-scale-microamp:
>>> + description: This property represents the DAC full scale current.
>>
>> The description could be improved by saying what determines the value
>> that need to be entered here. (Also wondering if this is not something
>> that should be set at runtime using the _scale attribute instead.)
>>
>
> Hmm, not sure what you mean here? For anyone using a device like this, it should
> be clear what this is about :)
I never used a part like this before, but Jonathan explained it in his
reply to my comments on the LTC2672 bindings. It does sound like this
is a common property.
>
>>> + minimum: 8700
>>> + maximum: 31700
>>
>> Missing a default value since this is not a required property?
>>
>
> Hmm, yes. That could definitely be added.
>
> - Nuno Sá
>>
next prev parent reply other threads:[~2024-04-15 13:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 13:36 [PATCH v3 00/10] iio: dac: support IIO backends on the output direction Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 01/10] iio: buffer-dma: add iio_dmaengine_buffer_setup() Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 02/10] iio: buffer-dma: Rename iio_dma_buffer_data_available() Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 03/10] iio: buffer-dma: Enable buffer write support Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 04/10] iio: buffer-dmaengine: Support specifying buffer direction Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 05/10] iio: buffer-dmaengine: Enable write support Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 06/10] dt-bindings: iio: dac: add docs for AXI DAC IP Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 07/10] dt-bindings: iio: dac: add docs for AD9739A Nuno Sa via B4 Relay
2024-04-12 23:47 ` David Lechner
2024-04-15 12:25 ` Nuno Sá
2024-04-15 13:51 ` David Lechner [this message]
2024-04-12 13:36 ` [PATCH v3 08/10] iio: backend: add new functionality Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 09/10] iio: dac: add support for AXI DAC IP core Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 10/10] iio: dac: support the ad9739a RF DAC Nuno Sa via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179a795a-f012-4c0e-a615-c1ab3ba9093d@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dragos.bogdan@analog.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).