From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: David Lechner <dlechner@baylibre.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7944: use spi_optimize_message()
Date: Tue, 26 Mar 2024 17:21:49 +0000 [thread overview]
Message-ID: <20240326172149.00004247@Huawei.com> (raw)
In-Reply-To: <20240325-ad7944-spi-optimize-message-v1-1-cded69b9e27f@baylibre.com>
On Mon, 25 Mar 2024 17:03:13 -0500
David Lechner <dlechner@baylibre.com> wrote:
> This modifies the ad7944 driver to use spi_optimize_message() to reduce
> CPU usage and increase the max sample rate by avoiding repeating
> validation of the spi message on each transfer.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
One buglet inline. Otherwise looks fine to me.
Jonathan
> ---
> drivers/iio/adc/ad7944.c | 177 +++++++++++++++++++++++++++--------------------
> 1 file changed, 103 insertions(+), 74 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7944.c b/drivers/iio/adc/ad7944.c
> index 261a3f645fd8..c767401712af 100644
> --- a/drivers/iio/adc/ad7944.c
> +++ b/drivers/iio/adc/ad7944.c
> @@ -51,6 +51,8 @@ static const char * const ad7944_spi_modes[] = {
> struct ad7944_adc {
> struct spi_device *spi;
> enum ad7944_spi_mode spi_mode;
> + struct spi_transfer xfers[3];
> + struct spi_message msg;
> /* Chip-specific timing specifications. */
> const struct ad7944_timing_spec *timing_spec;
> /* GPIO connected to CNV pin. */
> @@ -130,6 +132,88 @@ AD7944_DEFINE_CHIP_INFO(ad7985, ad7944, 16, 0);
> /* fully differential */
> AD7944_DEFINE_CHIP_INFO(ad7986, ad7986, 18, 1);
>
> +static void ad7944_unoptimize_msg(void *msg)
> +{
> + spi_unoptimize_message(msg);
> +}
> +
> +static int ad7944_3wire_cs_mode_init_msg(struct device *dev, struct ad7944_adc *adc,
> + const struct iio_chan_spec *chan)
> +{
> + unsigned int t_conv_ns = adc->always_turbo ? adc->timing_spec->turbo_conv_ns
> + : adc->timing_spec->conv_ns;
> + struct spi_transfer *xfers = adc->xfers;
> + int ret;
> +
> + /*
> + * NB: can get better performance from some SPI controllers if we use
> + * the same bits_per_word in every transfer.
> + */
> + xfers[0].bits_per_word = chan->scan_type.realbits;
> + /*
> + * CS is tied to CNV and we need a low to high transition to start the
> + * conversion, so place CNV low for t_QUIET to prepare for this.
> + */
> + xfers[0].delay.value = T_QUIET_NS;
> + xfers[0].delay.unit = SPI_DELAY_UNIT_NSECS;
> +
> + /*
> + * CS has to be high for full conversion time to avoid triggering the
> + * busy indication.
> + */
> + xfers[1].cs_off = 1;
> + xfers[1].delay.value = t_conv_ns;
> + xfers[1].delay.unit = SPI_DELAY_UNIT_NSECS;
> + xfers[0].bits_per_word = chan->scan_type.realbits;
0 ?
> +
> + /* Then we can read the data during the acquisition phase */
> + xfers[2].rx_buf = &adc->sample.raw;
> + xfers[2].len = BITS_TO_BYTES(chan->scan_type.storagebits);
> + xfers[2].bits_per_word = chan->scan_type.realbits;
> +
> + spi_message_init_with_transfers(&adc->msg, xfers, 3);
> +
> + ret = spi_optimize_message(adc->spi, &adc->msg);
> + if (ret)
> + return ret;
> +
> + return devm_add_action_or_reset(dev, ad7944_unoptimize_msg, &adc->msg);
> +}
prev parent reply other threads:[~2024-03-26 17:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 22:03 [PATCH] iio: adc: ad7944: use spi_optimize_message() David Lechner
2024-03-26 17:21 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326172149.00004247@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).