From: Alisa-Dariana Roman <alisadariana@gmail.com>
To: michael.hennerich@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: alexandru.tachici@analog.com, lars@metafoo.de,
Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org, andy@kernel.org,
nuno.sa@analog.com, marcelo.schmitt@analog.com,
bigunclemax@gmail.com, dlechner@baylibre.com,
okan.sahin@analog.com, fr0st61te@gmail.com,
alisa.roman@analog.com, marcus.folkesson@gmail.com,
schnelle@linux.ibm.com, liambeguin@gmail.com
Subject: [PATCH v6 3/5] iio: adc: ad7192: Add aincom supply
Date: Wed, 17 Apr 2024 20:00:52 +0300 [thread overview]
Message-ID: <20240417170054.140587-4-alisa.roman@analog.com> (raw)
In-Reply-To: <20240417170054.140587-1-alisa.roman@analog.com>
AINCOM should actually be a supply. AINx inputs are referenced to AINCOM
in pseduo-differential operation mode. AINCOM voltage represets the
offset of corresponding channels.
Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>
---
drivers/iio/adc/ad7192.c | 37 +++++++++++++++++++++++++++++++++++--
1 file changed, 35 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
index fe8dbb68a8ba..8d56cf889973 100644
--- a/drivers/iio/adc/ad7192.c
+++ b/drivers/iio/adc/ad7192.c
@@ -186,6 +186,7 @@ struct ad7192_state {
struct regulator *vref;
struct clk *mclk;
u16 int_vref_mv;
+ u32 aincom_mv;
u32 fclk;
u32 mode;
u32 conf;
@@ -742,10 +743,19 @@ static int ad7192_read_raw(struct iio_dev *indio_dev,
*val = -(1 << (chan->scan_type.realbits - 1));
else
*val = 0;
+ switch (chan->type) {
+ case IIO_VOLTAGE:
+ if (st->aincom_mv && !chan->differential)
+ *val += DIV_ROUND_CLOSEST_ULL((u64)st->aincom_mv * 1000000000,
+ st->scale_avail[gain][1]);
+ return IIO_VAL_INT;
/* Kelvin to Celsius */
- if (chan->type == IIO_TEMP)
+ case IIO_TEMP:
*val -= 273 * ad7192_get_temp_scale(unipolar);
- return IIO_VAL_INT;
+ return IIO_VAL_INT;
+ default:
+ return -EINVAL;
+ }
case IIO_CHAN_INFO_SAMP_FREQ:
*val = DIV_ROUND_CLOSEST(ad7192_get_f_adc(st), 1024);
return IIO_VAL_INT;
@@ -1052,6 +1062,7 @@ static int ad7192_probe(struct spi_device *spi)
{
struct ad7192_state *st;
struct iio_dev *indio_dev;
+ struct regulator *aincom;
int ret;
if (!spi->irq) {
@@ -1067,6 +1078,27 @@ static int ad7192_probe(struct spi_device *spi)
mutex_init(&st->lock);
+ aincom = devm_regulator_get_optional(&spi->dev, "aincom");
+ if (!IS_ERR(aincom)) {
+ ret = regulator_enable(aincom);
+ if (ret) {
+ dev_err(&spi->dev, "Failed to enable specified AINCOM supply\n");
+ return ret;
+ }
+
+ ret = devm_add_action_or_reset(&spi->dev, ad7192_reg_disable, aincom);
+ if (ret)
+ return ret;
+
+ ret = regulator_get_voltage(aincom);
+ if (ret < 0)
+ return dev_err_probe(&spi->dev, ret,
+ "Device tree error, AINCOM voltage undefined\n");
+ st->aincom_mv = ret / 1000;
+ } else {
+ st->aincom_mv = 0;
+ }
+
st->avdd = devm_regulator_get(&spi->dev, "avdd");
if (IS_ERR(st->avdd))
return PTR_ERR(st->avdd);
@@ -1113,6 +1145,7 @@ static int ad7192_probe(struct spi_device *spi)
st->int_vref_mv = ret / 1000;
st->chip_info = spi_get_device_match_data(spi);
+
indio_dev->name = st->chip_info->name;
indio_dev->modes = INDIO_DIRECT_MODE;
indio_dev->channels = st->chip_info->channels;
--
2.34.1
next prev parent reply other threads:[~2024-04-17 17:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 17:00 [PATCH v6 0/5] iio: adc: ad7192: Add AD7194 support Alisa-Dariana Roman
2024-04-17 17:00 ` [PATCH v6 1/5] iio: adc: ad7192: Use standard attribute Alisa-Dariana Roman
2024-04-20 10:37 ` Jonathan Cameron
2024-04-17 17:00 ` [PATCH v6 2/5] dt-bindings: iio: adc: ad7192: Add aincom supply Alisa-Dariana Roman
2024-04-19 21:35 ` Rob Herring
2024-04-17 17:00 ` Alisa-Dariana Roman [this message]
2024-04-17 17:08 ` [PATCH v6 3/5] " Andy Shevchenko
2024-04-20 10:42 ` Jonathan Cameron
2024-04-17 17:00 ` [PATCH v6 4/5] dt-bindings: iio: adc: ad7192: Add AD7194 support Alisa-Dariana Roman
2024-04-18 14:40 ` Rob Herring
2024-04-20 10:52 ` Jonathan Cameron
2024-04-17 17:00 ` [PATCH v6 5/5] " Alisa-Dariana Roman
2024-04-17 17:06 ` Andy Shevchenko
2024-04-20 10:55 ` Jonathan Cameron
2024-04-20 11:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417170054.140587-4-alisa.roman@analog.com \
--to=alisadariana@gmail.com \
--cc=alexandru.tachici@analog.com \
--cc=alisa.roman@analog.com \
--cc=andy@kernel.org \
--cc=bigunclemax@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=fr0st61te@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=marcus.folkesson@gmail.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=okan.sahin@analog.com \
--cc=robh@kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).