From: Jonathan Cameron <jic23@kernel.org>
To: "Paller, Kim Seer" <KimSeer.Paller@analog.com>
Cc: David Lechner <dlechner@baylibre.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>
Subject: Re: [PATCH 3/4] iio: ABI: add ABI file for the LTC2672 DAC
Date: Sat, 20 Apr 2024 11:23:47 +0100 [thread overview]
Message-ID: <20240420112347.6bd1daa4@jic23-huawei> (raw)
In-Reply-To: <PH0PR03MB7141B4F4DBF3D77F7384B555F9082@PH0PR03MB7141.namprd03.prod.outlook.com>
On Tue, 16 Apr 2024 14:18:23 +0000
"Paller, Kim Seer" <KimSeer.Paller@analog.com> wrote:
> > -----Original Message-----
> > From: Jonathan Cameron <jic23@kernel.org>
> > Sent: Saturday, April 13, 2024 11:27 PM
> > To: Paller, Kim Seer <KimSeer.Paller@analog.com>
> > Cc: linux-iio@vger.kernel.org; devicetree@vger.kernel.org; linux-
> > kernel@vger.kernel.org; Lars-Peter Clausen <lars@metafoo.de>; Rob Herring
> > <robh@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>;
> > Conor Dooley <conor+dt@kernel.org>; Liam Girdwood
> > <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>; David Lechner
> > <dlechner@baylibre.com>; Hennerich, Michael
> > <Michael.Hennerich@analog.com>
> > Subject: Re: [PATCH 3/4] iio: ABI: add ABI file for the LTC2672 DAC
> >
> > [External]
> >
> > On Fri, 12 Apr 2024 11:21:01 +0800
> > Kim Seer Paller <kimseer.paller@analog.com> wrote:
> >
> > > Define the sysfs interface for toggle capable channels.
> > >
> > > Toggle enabled channels will have:
> > >
> > > * out_currentY_toggle_en
> > > * out_currentY_raw0
> > > * out_currentY_raw1
> > > * out_currentY_symbol
> > >
> > > The common interface present in all channels is:
> > >
> > > * out_currentY_raw (not present in toggle enabled channels)
> > > * out_currentY_raw_available
> > > * out_currentY_powerdown
> > > * out_currentY_scale
> > > * out_currentY_offset
> > >
> > > Co-developed-by: Michael Hennerich <michael.hennerich@analog.com>
> > > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> > > Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
> > > ---
> > > .../ABI/testing/sysfs-bus-iio-dac-ltc2672 | 30 +++++++++++++++++++
> >
> > You can only have per device ABI defined if that is the only user
> > of the ABI. That may actually be true here but given I've asked you to
> > generalize
> > the voltage equivalent, I think we've shown this is general enough that the
> > current
> > version should also be raised to sysfs-bus-iio-dac
>
> I'm still getting familiar with ABI documentation. If I understand correctly,
> generalizing the documentation to cover both parts would also mean we remove
> the overlapping sections from the ltc2688 ABI. Is that the correct approach?
>
>
Yes. To test this build the html docs. IIRC that will complain about duplicate
ABI definitions. I'm sure there is a way to test just ABI docs build but
I've never really looked into it.
Jonathan
next prev parent reply other threads:[~2024-04-20 10:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 3:20 [PATCH 0/4] Add driver for LTC2664 and LTC2672 Kim Seer Paller
2024-04-12 3:20 ` [PATCH 1/4] dt-bindings: iio: dac: Add adi,ltc2664.yaml Kim Seer Paller
2024-04-12 5:50 ` Krzysztof Kozlowski
2024-04-13 14:54 ` Jonathan Cameron
2024-04-16 14:16 ` Paller, Kim Seer
2024-04-12 21:23 ` David Lechner
2024-04-13 15:06 ` Jonathan Cameron
2024-04-13 15:11 ` Jonathan Cameron
2024-04-13 16:21 ` David Lechner
2024-04-13 17:10 ` Jonathan Cameron
2024-04-16 14:40 ` Paller, Kim Seer
2024-04-20 10:13 ` Jonathan Cameron
2024-04-12 3:21 ` [PATCH 2/4] iio: ABI: add ABI file for the LTC2664 DAC Kim Seer Paller
2024-04-12 21:26 ` David Lechner
2024-04-13 15:25 ` Jonathan Cameron
2024-04-13 20:38 ` David Lechner
2024-04-15 12:45 ` Nuno Sá
2024-04-20 10:22 ` Jonathan Cameron
2024-04-12 3:21 ` [PATCH 3/4] iio: ABI: add ABI file for the LTC2672 DAC Kim Seer Paller
2024-04-13 15:26 ` Jonathan Cameron
2024-04-16 14:18 ` Paller, Kim Seer
2024-04-20 10:23 ` Jonathan Cameron [this message]
2024-04-12 3:21 ` [PATCH 4/4] iio: dac: ltc2664: Add driver for LTC2664 and LTC2672 Kim Seer Paller
2024-04-13 15:55 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240420112347.6bd1daa4@jic23-huawei \
--to=jic23@kernel.org \
--cc=KimSeer.Paller@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).