Linux-IIO Archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org>
Cc: nuno.sa@analog.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org,
	Dragos Bogdan <dragos.bogdan@analog.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Olivier Moysan <olivier.moysan@foss.st.com>,
	Paul Cercueil <paul@crapouillou.net>,
	Alexandru Ardelean <ardeleanalex@gmail.com>
Subject: Re: [PATCH v4 04/10] iio: buffer-dmaengine: Support specifying buffer direction
Date: Sat, 20 Apr 2024 15:42:05 +0100	[thread overview]
Message-ID: <20240420154205.2ee50324@jic23-huawei> (raw)
In-Reply-To: <20240419-iio-backend-axi-dac-v4-4-5ca45b4de294@analog.com>


> @@ -268,20 +282,21 @@ static void __devm_iio_dmaengine_buffer_free(void *buffer)
>   * It also appends the INDIO_BUFFER_HARDWARE mode to the supported modes of the
>   * IIO device.
>   */
> -int devm_iio_dmaengine_buffer_setup(struct device *dev,
> -				    struct iio_dev *indio_dev,
> -				    const char *channel)
> +int devm_iio_dmaengine_buffer_setup_ext(struct device *dev,
> +					struct iio_dev *indio_dev,
> +					const char *channel,
> +					enum iio_buffer_direction dir)
Missing updates to the docs immediately above. I fixed that up.

>  {
>  	struct iio_buffer *buffer;
>  
> -	buffer = iio_dmaengine_buffer_setup(dev, indio_dev, channel);
> +	buffer = iio_dmaengine_buffer_setup_ext(dev, indio_dev, channel, dir);
>  	if (IS_ERR(buffer))
>  		return PTR_ERR(buffer);
>  
>  	return devm_add_action_or_reset(dev, __devm_iio_dmaengine_buffer_free,
>  					buffer);
>  }
> -EXPORT_SYMBOL_NS_GPL(devm_iio_dmaengine_buffer_setup, IIO_DMAENGINE_BUFFER);


  reply	other threads:[~2024-04-20 14:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19  8:25 [PATCH v4 00/10] iio: dac: support IIO backends on the output direction Nuno Sa via B4 Relay
2024-04-19  8:25 ` [PATCH v4 01/10] iio: buffer-dma: add iio_dmaengine_buffer_setup() Nuno Sa via B4 Relay
2024-04-19  8:25 ` [PATCH v4 02/10] iio: buffer-dma: Rename iio_dma_buffer_data_available() Nuno Sa via B4 Relay
2024-04-19  8:25 ` [PATCH v4 03/10] iio: buffer-dma: Enable buffer write support Nuno Sa via B4 Relay
2024-04-19  8:25 ` [PATCH v4 04/10] iio: buffer-dmaengine: Support specifying buffer direction Nuno Sa via B4 Relay
2024-04-20 14:42   ` Jonathan Cameron [this message]
2024-04-19  8:25 ` [PATCH v4 05/10] iio: buffer-dmaengine: Enable write support Nuno Sa via B4 Relay
2024-04-19  8:25 ` [PATCH v4 06/10] dt-bindings: iio: dac: add docs for AXI DAC IP Nuno Sa via B4 Relay
2024-04-19  8:25 ` [PATCH v4 07/10] dt-bindings: iio: dac: add docs for AD9739A Nuno Sa via B4 Relay
2024-04-19  8:25 ` [PATCH v4 08/10] iio: backend: add new functionality Nuno Sa via B4 Relay
2024-04-19  8:25 ` [PATCH v4 09/10] iio: dac: add support for AXI DAC IP core Nuno Sa via B4 Relay
2024-04-19  8:25 ` [PATCH v4 10/10] iio: dac: support the ad9739a RF DAC Nuno Sa via B4 Relay
2024-04-20 14:38 ` [PATCH v4 00/10] iio: dac: support IIO backends on the output direction Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240420154205.2ee50324@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=ardeleanalex@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=devnull+nuno.sa.analog.com@kernel.org \
    --cc=dragos.bogdan@analog.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=paul@crapouillou.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).