From: Jonathan Cameron <jic23@kernel.org>
To: Lorenzo Bertin Salvador <lorenzobs@usp.br>
Cc: Briza Mel Dias de Sousa <brizamel.dias@usp.br>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: adc: ti-ads131e08: Fix a style problem in struct declaration.
Date: Sun, 21 Apr 2024 18:27:26 +0100 [thread overview]
Message-ID: <20240421182726.6ec2af1f@jic23-huawei> (raw)
In-Reply-To: <20240420182744.153184-3-lorenzobs@usp.br>
On Sat, 20 Apr 2024 15:27:44 -0300
Lorenzo Bertin Salvador <lorenzobs@usp.br> wrote:
> There was a blank line missing after declarations in struct tmp_buf.
>
> Co-developed-by: Briza Mel Dias de Sousa <brizamel.dias@usp.br>
> Signed-off-by: Briza Mel Dias de Sousa <brizamel.dias@usp.br>
> Signed-off-by: Lorenzo Bertin Salvador <lorenzobs@usp.br>
That's a checkpatch.pl (I assume) bug.
These are both declarations, just the second one is more complex than most :)
Feel free to try and fix check patch but this isn't something we are going
to 'fix' in code.
Thanks,
Jonathan
> ---
> drivers/iio/adc/ti-ads131e08.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/ti-ads131e08.c b/drivers/iio/adc/ti-ads131e08.c
> index cb04a29b3..fcc0276bf 100644
> --- a/drivers/iio/adc/ti-ads131e08.c
> +++ b/drivers/iio/adc/ti-ads131e08.c
> @@ -102,6 +102,7 @@ struct ads131e08_state {
> struct completion completion;
> struct {
> u8 data[ADS131E08_NUM_DATA_BYTES_MAX];
> +
> s64 ts __aligned(8);
> } tmp_buf;
>
next prev parent reply other threads:[~2024-04-21 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 18:27 [PATCH 0/2] IIO: Use of device_for_each_child_node_scoped() in ti-ads131e08 Lorenzo Bertin Salvador
2024-04-20 18:27 ` [PATCH 1/2] iio: adc: ti-ads131e08: Use device_for_each_child_node_scoped() to simplify error paths Lorenzo Bertin Salvador
2024-04-21 17:43 ` Jonathan Cameron
2024-04-20 18:27 ` [PATCH 2/2] iio: adc: ti-ads131e08: Fix a style problem in struct declaration Lorenzo Bertin Salvador
2024-04-21 17:27 ` Jonathan Cameron [this message]
2024-04-21 17:40 ` [PATCH 0/2] IIO: Use of device_for_each_child_node_scoped() in ti-ads131e08 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240421182726.6ec2af1f@jic23-huawei \
--to=jic23@kernel.org \
--cc=brizamel.dias@usp.br \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzobs@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).