From: Jonathan Cameron <jic23@kernel.org>
To: Lincoln Yuji <lincolnyuji@usp.br>
Cc: Luiza Soezima <lbrsoezima@usp.br>,
Sabrina Araujo <sabrinaaraujo@usp.br>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ti-ads1015: use device_for_each_child_node_scoped()
Date: Sun, 28 Apr 2024 12:39:11 +0100 [thread overview]
Message-ID: <20240428123911.73f54c08@jic23-huawei> (raw)
In-Reply-To: <20240427121055.5639-1-lincolnyuji@usp.br>
On Sat, 27 Apr 2024 09:10:55 -0300
Lincoln Yuji <lincolnyuji@usp.br> wrote:
> This loop definition removes the need for manual releasing of the
> fwnode_handle in early exit paths (here an error path) allow
> simplification of the code and reducing the chance of future
> modifications not releasing fwnode_handle correctly.
>
> Co-developed-by: Luiza Soezima <lbrsoezima@usp.br>
> Signed-off-by: Luiza Soezima <lbrsoezima@usp.br>
> Co-developed-by: Sabrina Araujo <sabrinaaraujo@usp.br>
> Signed-off-by: Sabrina Araujo <sabrinaaraujo@usp.br>
> Signed-off-by: Lincoln Yuji <lincolnyuji@usp.br>
> ---
I think this is a response to Marcelo's review of v1.
If so, a couple of process things you have gotten wrong.
1) You should pick up tags, assuming you've made the changes
suggested. So should include
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
in the block above.
2) It should be clearly marked as v2. Pass -v2 to git format
patch is the easiest way to do this, or edit the patch title
so it says something like
[PATCH V2] ...
Otherwise the patch looks fine.
Please do a v3, correcting the above.
Thanks,
Jonathan
> drivers/iio/adc/ti-ads1015.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
> index 6ae967e4d..d3363d02f 100644
> --- a/drivers/iio/adc/ti-ads1015.c
> +++ b/drivers/iio/adc/ti-ads1015.c
> @@ -902,10 +902,9 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> struct iio_dev *indio_dev = i2c_get_clientdata(client);
> struct ads1015_data *data = iio_priv(indio_dev);
> struct device *dev = &client->dev;
> - struct fwnode_handle *node;
> int i = -1;
>
> - device_for_each_child_node(dev, node) {
> + device_for_each_child_node_scoped(dev, node) {
> u32 pval;
> unsigned int channel;
> unsigned int pga = ADS1015_DEFAULT_PGA;
> @@ -927,7 +926,6 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> pga = pval;
> if (pga > 5) {
> dev_err(dev, "invalid gain on %pfw\n", node);
> - fwnode_handle_put(node);
> return -EINVAL;
> }
> }
> @@ -936,7 +934,6 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> data_rate = pval;
> if (data_rate > 7) {
> dev_err(dev, "invalid data_rate on %pfw\n", node);
> - fwnode_handle_put(node);
> return -EINVAL;
> }
> }
next prev parent reply other threads:[~2024-04-28 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 12:10 [PATCH] iio: adc: ti-ads1015: use device_for_each_child_node_scoped() Lincoln Yuji
2024-04-28 11:39 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-26 13:19 Lincoln Yuji
2024-04-27 11:14 ` Marcelo Schmitt
2024-04-28 15:36 ` Jonathan Cameron
2024-04-28 15:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240428123911.73f54c08@jic23-huawei \
--to=jic23@kernel.org \
--cc=lbrsoezima@usp.br \
--cc=lincolnyuji@usp.br \
--cc=linux-iio@vger.kernel.org \
--cc=sabrinaaraujo@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).