From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jonathan Cameron <jic23@kernel.org>, <linux-iio@vger.kernel.org>
Subject: Re: [PULL] IIO: 2nd set of new device support, features and cleanup for the 6.10 cycle
Date: Fri, 3 May 2024 09:32:16 +0100 [thread overview]
Message-ID: <20240503093216.00001d6e@Huawei.com> (raw)
In-Reply-To: <20240503092513.00001f88@Huawei.com>
On Fri, 3 May 2024 09:25:13 +0100
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> On Fri, 3 May 2024 07:23:31 +0200
> Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > On Fri, May 03, 2024 at 07:22:10AM +0200, Greg KH wrote:
> > > On Fri, May 03, 2024 at 07:21:43AM +0200, Greg KH wrote:
> > > > On Fri, May 03, 2024 at 07:16:02AM +0200, Greg KH wrote:
> > > > > On Thu, May 02, 2024 at 08:15:09PM +0100, Jonathan Cameron wrote:
> > > > > > The following changes since commit 84e79a7f63e8caeac0c1a0817408860875a9b23e:
> > > > > >
> > > > > > Merge tag 'peci-next-6.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/iwi/linux into char-misc-next (2024-04-23 21:31:45 -0700)
> > > > > >
> > > > > > are available in the Git repository at:
> > > > > >
> > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git tags/iio-for-6.10b
> > > > >
> > > > > Pulled and pushed out now, thanks.
> > > >
> > > > Oops, nope, got the following error:
> > > >
> > > > Fixes tag: Fixes: 0ecc363ccea7 ("iio: make invensense timestamp module generic)
> > > > Has these problem(s):
> > > > - Subject has leading but no trailing quotes
> > > >
> > > > I'll rewrite this one, but note that you will have to rebase your tree
> > > > now, sorry.
> > >
> > > Here's the full error, was cut off one line:
> > > Commit: a5918cecaec3 ("iio: invensense: fix timestamp glitches when switching frequency")
> > > Fixes tag: Fixes: 0ecc363ccea7 ("iio: make invensense timestamp module generic)
> > > Has these problem(s):
> > > - Subject has leading but no trailing quotes
> > >
> >
> > Nope, no fixup on my side, that just messed the whole tree up. Can you
> > fix this on your end and send a new pull request?
>
> Sorry! I messed up fixing that tag and I guess it didn't get flagged because there
> was a very similar issue the day before in next or I didn't leave it long enough
> for next checks to find it again.
>
> I obviously need to check why the checking script / workflow I use didn't catch this.
>
> I've fixed up the tree up, but it will be this evening before I have my signing key
> available to send a revised pull request.
>
> Thanks and sorry for wasting your time :(
Having caught up with another thread I not only messed up the tag, the
rebase of that patch I did to resolve a clash between my two branches is wrong
as well. Will sort it out before I send the pull request.
Definitely not my finest hour :(
J
>
> Jonathan
>
>
>
> >
> > thanks,
> >
> > greg k-h
> >
>
>
prev parent reply other threads:[~2024-05-03 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 19:15 [PULL] IIO: 2nd set of new device support, features and cleanup for the 6.10 cycle Jonathan Cameron
2024-05-03 5:16 ` Greg KH
2024-05-03 5:21 ` Greg KH
2024-05-03 5:22 ` Greg KH
2024-05-03 5:23 ` Greg KH
2024-05-03 8:25 ` Jonathan Cameron
2024-05-03 8:32 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240503093216.00001d6e@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).