From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad9467: fix scan type sign
Date: Sat, 4 May 2024 12:28:36 +0100 [thread overview]
Message-ID: <20240504122836.51277cfb@jic23-huawei> (raw)
In-Reply-To: <20240503-ad9467-fix-scan-type-sign-v1-1-c7a1a066ebb9@baylibre.com>
On Fri, 3 May 2024 14:45:05 -0500
David Lechner <dlechner@baylibre.com> wrote:
> According to the IIO documentation, the sign in the scan type should be
> lower case. The ad9467 driver was incorrectly using upper case.
>
> Fix by changing to lower case.
>
> Fixes: 4606d0f4b05f ("iio: adc: ad9467: add support for AD9434 high-speed ADC")
> Fixes: ad6797120238 ("iio: adc: ad9467: add support AD9467 ADC")
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Applied to the fixes-togreg branch of iio.git.
I'll probably sit on this until after the merge window though.
Marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/adc/ad9467.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c
> index e85b763b9ffc..8f5b9c3f6e3d 100644
> --- a/drivers/iio/adc/ad9467.c
> +++ b/drivers/iio/adc/ad9467.c
> @@ -243,11 +243,11 @@ static void __ad9467_get_scale(struct ad9467_state *st, int index,
> }
>
> static const struct iio_chan_spec ad9434_channels[] = {
> - AD9467_CHAN(0, 0, 12, 'S'),
> + AD9467_CHAN(0, 0, 12, 's'),
> };
>
> static const struct iio_chan_spec ad9467_channels[] = {
> - AD9467_CHAN(0, 0, 16, 'S'),
> + AD9467_CHAN(0, 0, 16, 's'),
> };
>
> static const struct ad9467_chip_info ad9467_chip_tbl = {
>
> ---
> base-commit: 827dca3129708a8465bde90c86c2e3c38e62dd4f
> change-id: 20240503-ad9467-fix-scan-type-sign-425daca1bb83
prev parent reply other threads:[~2024-05-04 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 19:45 [PATCH] iio: adc: ad9467: fix scan type sign David Lechner
2024-05-04 11:28 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240504122836.51277cfb@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=dlechner@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).