From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Lars-Peter Clausen <lars@metafoo.de>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Chenyuan Yang <chenyuan0y@gmail.com>
Subject: Re: [PATCH v2 0/2] Fix the iio-gts-helpers available times table sorting
Date: Thu, 9 May 2024 13:15:16 +0100 [thread overview]
Message-ID: <20240509131516.000049d4@Huawei.com> (raw)
In-Reply-To: <f5215081-c993-4147-8c50-fba1f56279b4@gmail.com>
On Tue, 7 May 2024 09:14:15 +0300
Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> On 5/6/24 15:53, Jonathan Cameron wrote:
> > On Mon, 6 May 2024 08:09:27 +0300
> > Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> >
> >> On 5/5/24 20:50, Jonathan Cameron wrote:
> >>> On Tue, 30 Apr 2024 15:44:26 +0300
> >>> Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> >>>
> >>>> Fix the available times table sorting in iio-gts-helpers
> >>>>
> >>>> This series contains a fix and test for the sorting of the available times in
> >>>> IIO-gts helpers. Fix was originally developed and posted by Chenyuan Yang.
> >>>>
> >>>> Revision history:
> >>>> v1 => v2:
> >>>> - Fix the sender for patch 1/2 (Sic!)
> >>>> - Fix Co-Developed-by tag (drop this from Chenyuan who
> >>>> is the original author)
> >>>> - Fix the From: tag as instructed in:
> >>>> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> >>>
> >>> Am I right in thinking this doesn't matter for existing drivers?
> >>
> >> I think this is right. Only couple of in-tree drivers are using these
> >> helpers for now, and all of them sorted the tables already in driver.
> >>
> >>> As such not high priority for back porting?
> >>
> >> The bug is pretty nasty as it causes invalid memory accesses. Hence I'd
> >> like to see this landing in the longterm kernels. It seems to me the GTS
> >> helpers got merged in 6.4, so getting the fix backported to 6.6 might
> >> make sense.
> >>
> >>> I'll assume that and queue it up for 6.11. If someone shouts I can pull the fix
> >>> forwards, but then we have the mess of chasing the testing in later.
> >>
> >> I am sorry Jonathan but I'm not quite sure what you mean by "pulling fix
> >> forward", or what is the "mess of chasing the testing in later" :)
> >
> > Hmm. That was an odd choice of words :) I just meant that I could send
> > the fix in the first set of fixes after 6.10-rc1 rather than waiting for 6.11.
>
> Oh, right :)
>
> > For now I'll leave it queued for 6.11 on the basis there are a lot of ways
> > a driver writer can cause similar out of bounds accesses and they should
> > notice it not working during testing. So it 'should' not be a problem to
> > not rush this in.
> >
>
> I guess this means the 6.10 won't have the fix? I believe this is fine -
> assuming the 6.10 is not going to be an LTS. Thanks for taking care of
> this! :)
It may well get backported anyway, but after 6.11 merge window.
J
>
> Yours,
> -- Matti
>
>
next prev parent reply other threads:[~2024-05-09 12:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 12:44 [PATCH v2 0/2] Fix the iio-gts-helpers available times table sorting Matti Vaittinen
2024-04-30 12:44 ` [PATCH v2 1/2] iio: Fix the sorting functionality in iio_gts_build_avail_time_table Matti Vaittinen
2024-04-30 12:45 ` [PATCH v2 2/2] iio: test: gts: test available times and gains sorting Matti Vaittinen
2024-05-05 17:50 ` [PATCH v2 0/2] Fix the iio-gts-helpers available times table sorting Jonathan Cameron
2024-05-06 5:09 ` Matti Vaittinen
2024-05-06 12:53 ` Jonathan Cameron
2024-05-07 6:14 ` Matti Vaittinen
2024-05-09 12:15 ` Jonathan Cameron [this message]
2024-05-10 5:14 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509131516.000049d4@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=chenyuan0y@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).