* [PATCH] dt-bindings: iio: adc: adi,axi-adc: tweak example node name
@ 2024-05-10 21:04 David Lechner
2024-05-11 13:00 ` Conor Dooley
2024-05-13 14:19 ` Rob Herring
0 siblings, 2 replies; 5+ messages in thread
From: David Lechner @ 2024-05-10 21:04 UTC (permalink / raw
To: Jonathan Cameron
Cc: David Lechner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Michael Hennerich, linux-iio, devicetree, linux-kernel
It is always recommended to use generic node names for devicetree nodes.
The documentation [1] of the AXI ADC IP core says "The most important
part of the core is the Receiver PHY module.", so using phy as the node
name seems appropriate.
[1]: https://wiki.analog.com/resources/fpga/docs/axi_adc_ip
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
index e1f450b80db2..9cad4c439045 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
@@ -57,7 +57,7 @@ additionalProperties: false
examples:
- |
- axi-adc@44a00000 {
+ phy@44a00000 {
compatible = "adi,axi-adc-10.0.a";
reg = <0x44a00000 0x10000>;
dmas = <&rx_dma 0>;
---
base-commit: 5e3c5871138da700796587aa5f096d39135f9d36
change-id: 20240510-b4-iio-axi-adc-dt-binding-tweak-054f97a78bff
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: adi,axi-adc: tweak example node name
2024-05-10 21:04 [PATCH] dt-bindings: iio: adc: adi,axi-adc: tweak example node name David Lechner
@ 2024-05-11 13:00 ` Conor Dooley
2024-05-12 11:52 ` Jonathan Cameron
2024-05-13 14:19 ` Rob Herring
1 sibling, 1 reply; 5+ messages in thread
From: Conor Dooley @ 2024-05-11 13:00 UTC (permalink / raw
To: David Lechner
Cc: Jonathan Cameron, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Michael Hennerich, linux-iio, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 516 bytes --]
On Fri, May 10, 2024 at 04:04:38PM -0500, David Lechner wrote:
> It is always recommended to use generic node names for devicetree nodes.
> The documentation [1] of the AXI ADC IP core says "The most important
> part of the core is the Receiver PHY module.", so using phy as the node
> name seems appropriate.
>
> [1]: https://wiki.analog.com/resources/fpga/docs/axi_adc_ip
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: adi,axi-adc: tweak example node name
2024-05-11 13:00 ` Conor Dooley
@ 2024-05-12 11:52 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2024-05-12 11:52 UTC (permalink / raw
To: Conor Dooley
Cc: David Lechner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Michael Hennerich, linux-iio, devicetree, linux-kernel
On Sat, 11 May 2024 14:00:40 +0100
Conor Dooley <conor@kernel.org> wrote:
> On Fri, May 10, 2024 at 04:04:38PM -0500, David Lechner wrote:
> > It is always recommended to use generic node names for devicetree nodes.
> > The documentation [1] of the AXI ADC IP core says "The most important
> > part of the core is the Receiver PHY module.", so using phy as the node
> > name seems appropriate.
> >
> > [1]: https://wiki.analog.com/resources/fpga/docs/axi_adc_ip
> >
> > Signed-off-by: David Lechner <dlechner@baylibre.com>
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
Sure, I guess phy is sort of applicable here.
Applied,
> Cheers,
> Conor.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: adi,axi-adc: tweak example node name
2024-05-10 21:04 [PATCH] dt-bindings: iio: adc: adi,axi-adc: tweak example node name David Lechner
2024-05-11 13:00 ` Conor Dooley
@ 2024-05-13 14:19 ` Rob Herring
2024-05-19 17:41 ` Jonathan Cameron
1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2024-05-13 14:19 UTC (permalink / raw
To: David Lechner
Cc: Jonathan Cameron, Krzysztof Kozlowski, Conor Dooley,
Michael Hennerich, linux-iio, devicetree, linux-kernel
On Fri, May 10, 2024 at 04:04:38PM -0500, David Lechner wrote:
> It is always recommended to use generic node names for devicetree nodes.
> The documentation [1] of the AXI ADC IP core says "The most important
> part of the core is the Receiver PHY module.", so using phy as the node
> name seems appropriate.
>
> [1]: https://wiki.analog.com/resources/fpga/docs/axi_adc_ip
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> index e1f450b80db2..9cad4c439045 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> @@ -57,7 +57,7 @@ additionalProperties: false
>
> examples:
> - |
> - axi-adc@44a00000 {
> + phy@44a00000 {
phy should be used when there's #phy-cells which is not the case here.
'adc' is somewhat standard. Or maybe it should be tied to
#io-backend-cells.
Until we have something defined as ti what it should be, we should just
leave node names alone.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: adi,axi-adc: tweak example node name
2024-05-13 14:19 ` Rob Herring
@ 2024-05-19 17:41 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2024-05-19 17:41 UTC (permalink / raw
To: Rob Herring
Cc: David Lechner, Krzysztof Kozlowski, Conor Dooley,
Michael Hennerich, linux-iio, devicetree, linux-kernel
On Mon, 13 May 2024 09:19:06 -0500
Rob Herring <robh@kernel.org> wrote:
> On Fri, May 10, 2024 at 04:04:38PM -0500, David Lechner wrote:
> > It is always recommended to use generic node names for devicetree nodes.
> > The documentation [1] of the AXI ADC IP core says "The most important
> > part of the core is the Receiver PHY module.", so using phy as the node
> > name seems appropriate.
> >
> > [1]: https://wiki.analog.com/resources/fpga/docs/axi_adc_ip
> >
> > Signed-off-by: David Lechner <dlechner@baylibre.com>
> > ---
> > Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> > index e1f450b80db2..9cad4c439045 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> > @@ -57,7 +57,7 @@ additionalProperties: false
> >
> > examples:
> > - |
> > - axi-adc@44a00000 {
> > + phy@44a00000 {
>
> phy should be used when there's #phy-cells which is not the case here.
> 'adc' is somewhat standard. Or maybe it should be tied to
> #io-backend-cells.
>
> Until we have something defined as ti what it should be, we should just
> leave node names alone.
>
> Rob
>
Unapplied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-19 17:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-10 21:04 [PATCH] dt-bindings: iio: adc: adi,axi-adc: tweak example node name David Lechner
2024-05-11 13:00 ` Conor Dooley
2024-05-12 11:52 ` Jonathan Cameron
2024-05-13 14:19 ` Rob Herring
2024-05-19 17:41 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).