From: Angelo Dureghello <adureghello@baylibre.com>
To: Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
nuno.sa@analog.com, lars@metafoo.de,
Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: iio: dac: add ad35xxr single output variants
Date: Thu, 16 May 2024 15:20:57 +0200 [thread overview]
Message-ID: <2699ec89-29a1-4b9d-b3ec-7792713041c4@baylibre.com> (raw)
In-Reply-To: <20240511170529.742e6e6f@jic23-huawei>
Hi,
On 11/05/24 6:05 PM, Jonathan Cameron wrote:
> On Fri, 10 May 2024 10:39:31 -0500
> David Lechner <dlechner@baylibre.com> wrote:
>
>> On Fri, May 10, 2024 at 9:19 AM Angelo Dureghello
>> <adureghello@baylibre.com> wrote:
>>> From: Angelo Dureghello <adureghello@baylibre.com>
>>>
>>> Add support for ad3541r and ad3551r single output variants.
>>>
>>> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
>>> ---
>>> .../devicetree/bindings/iio/dac/adi,ad3552r.yaml | 10 ++++++++--
>>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
>>> index 8265d709094d..17442cdfbe27 100644
>>> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
>>> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
>> It would be nice to also add the datasheet links in the description.
ack,
>>> @@ -19,7 +19,9 @@ description: |
>>> properties:
>>> compatible:
>>> enum:
>>> + - adi,ad3541r
>>> - adi,ad3542r
>>> + - adi,ad3551r
>>> - adi,ad3552r
>>>
>>> reg:
>>> @@ -128,7 +130,9 @@ allOf:
>>> properties:
>>> compatible:
>>> contains:
>>> - const: adi,ad3542r
>>> + enum:
>>> + - adi,ad3541r
>>> + - adi,ad3542r
>>> then:
>>> patternProperties:
>>> "^channel@([0-1])$":
>>> @@ -158,7 +162,9 @@ allOf:
>>> properties:
>>> compatible:
>>> contains:
>>> - const: adi,ad3552r
>>> + enum:
>>> + - adi,ad3551r
>>> + - adi,ad3552r
>>> then:
>>> patternProperties:
>>> "^channel@([0-1])$":
>>> --
>>> 2.45.0.rc1
>>>
>>>
>> Since these are single channel, it would not hurt to restrict the
>> `reg` property of of the `channel@` nodes to 1.
ack,
> Ah. I missed David's email because threading goes weird without a cover letter
> and hence duplicated his comment.
> Please add a cover letter with a brief description of the series to
> your v2. Means we get a nice title in patchwork as well!
>
> Thanks,
>
> Jonathan
>
>
Thanks for the feedbacks, will fix all in v2.
Regards,
angelo
next prev parent reply other threads:[~2024-05-16 13:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 14:18 [PATCH 1/3] dt-bindings: iio: dac: add ad35xxr single output variants Angelo Dureghello
2024-05-10 14:18 ` [PATCH 2/3] iio: dac: ad3552r: add support for ad3541r and ad3551r Angelo Dureghello
2024-05-10 15:42 ` David Lechner
2024-05-16 13:17 ` Angelo Dureghello
2024-05-10 14:18 ` [PATCH 3/3] dt-bindings: iio: dac: fix ad3552r gain parameter names Angelo Dureghello
2024-05-10 15:43 ` David Lechner
2024-05-13 18:52 ` Rob Herring
2024-05-13 19:03 ` David Lechner
2024-05-10 15:39 ` [PATCH 1/3] dt-bindings: iio: dac: add ad35xxr single output variants David Lechner
2024-05-11 16:05 ` Jonathan Cameron
2024-05-16 13:20 ` Angelo Dureghello [this message]
2024-05-11 16:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2699ec89-29a1-4b9d-b3ec-7792713041c4@baylibre.com \
--to=adureghello@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).