From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andrej Picej <andrej.picej@norik.com>,
haibo.chen@nxp.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Cc: jic23@kernel.org, lars@metafoo.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
upstream@lists.phytec.de
Subject: Re: [PATCH 2/2] dt-bindings: iio: adc: nxp,imx93-adc.yaml: Add calibration properties
Date: Wed, 20 Mar 2024 11:26:31 +0100 [thread overview]
Message-ID: <38637621-1611-4268-ae79-7ac93a72c5ee@linaro.org> (raw)
In-Reply-To: <20240320100407.1639082-3-andrej.picej@norik.com>
On 20/03/2024 11:04, Andrej Picej wrote:
> Document calibration properties and how to set them.
Bindings are before users.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
There is no file extension in prefixes.
>
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> ---
> .../bindings/iio/adc/nxp,imx93-adc.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> index dacc526dc695..64958be62a6a 100644
> --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> @@ -46,6 +46,21 @@ properties:
> "#io-channel-cells":
> const: 1
>
> + nxp,calib-avg-en:
> + description:
> + Enable or disable averaging of calibration time.
> + enum: [ 0, 1 ]
> +
> + nxp,calib-nr-samples:
> + description:
> + Selects the number of averaging samples to be used during calibration.
> + enum: [ 16, 32, 128, 512 ]
> +
> + nxp,calib-t-samples:
> + description:
> + Specifies the sample time of calibration conversions.
> + enum: [ 8, 16, 22, 32 ]
No, use existing, generic properties. Open other bindings for this.
Also, none of these were tested. I am not going to review such untested
code.
It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-20 10:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 10:04 [PATCH 0/2] i.MX93 ADC calibration settings Andrej Picej
2024-03-20 10:04 ` [PATCH 1/2] iio: adc: imx93: Make calibration properties configurable Andrej Picej
2024-03-24 14:02 ` Jonathan Cameron
2024-03-20 10:04 ` [PATCH 2/2] dt-bindings: iio: adc: nxp,imx93-adc.yaml: Add calibration properties Andrej Picej
2024-03-20 10:26 ` Krzysztof Kozlowski [this message]
2024-03-20 12:05 ` Andrej Picej
2024-03-20 12:15 ` Krzysztof Kozlowski
2024-03-22 7:39 ` Andrej Picej
2024-03-22 8:14 ` Krzysztof Kozlowski
2024-03-22 9:58 ` Andrej Picej
2024-03-24 13:54 ` Jonathan Cameron
2024-03-25 9:58 ` Krzysztof Kozlowski
2024-03-25 14:38 ` Jonathan Cameron
2024-03-20 21:41 ` Rob Herring
2024-03-22 6:47 ` kernel test robot
2024-03-24 13:55 ` [PATCH 0/2] i.MX93 ADC calibration settings Jonathan Cameron
2024-03-25 8:32 ` Andrej Picej
2024-03-25 8:55 ` [Upstream] " Primoz Fiser
2024-03-25 14:45 ` Jonathan Cameron
2024-03-29 7:58 ` Primoz Fiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38637621-1611-4268-ae79-7ac93a72c5ee@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrej.picej@norik.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=upstream@lists.phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).