Linux-IIO Archive mirror
 help / color / mirror / Atom feed
From: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
	INV Git Commit <INV.git-commit@tdk.com>
Cc: "jic23@kernel.org" <jic23@kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: imu: inv_icm42600: fix timestamp patch integration
Date: Fri, 3 May 2024 16:58:25 +0000	[thread overview]
Message-ID: <BE1P281MB17451D71F7DA272440D1FCD0CE1F2@BE1P281MB1745.DEUP281.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240503111124.000070c1@Huawei.com>

Hello Jonathan,

this is OK, problem resolved now.

Sorry for the mess. I will try to warn about that next time.

Thanks a lot,
JB

________________________________________
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Sent: Friday, May 3, 2024 12:11
To: INV Git Commit <INV.git-commit@tdk.com>
Cc: jic23@kernel.org <jic23@kernel.org>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>
Subject: Re: [PATCH] iio: imu: inv_icm42600: fix timestamp patch integration
 
This Message Is From an External Sender
This message came from outside your organization.
 
On Fri,  3 May 2024 09:07:00 +0000
inv.git-commit@tdk.com wrote:

> From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> 
> For fixing commit a5918cecaec3650df in iio tree.
> 
> Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Squashed in and togreg tree updated. Please check it!

I'm not having a good run with this patch, so maybe this is 3rd time lucky ;)

Jonathan

> ---
>  drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
> index bce25ff57ecd..63b85ec88c13 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
> @@ -503,6 +503,8 @@ int inv_icm42600_buffer_fifo_read(struct inv_icm42600_state *st,
>  
>  int inv_icm42600_buffer_fifo_parse(struct inv_icm42600_state *st)
>  {
> +	struct inv_icm42600_sensor_state *gyro_st = iio_priv(st->indio_gyro);
> +	struct inv_icm42600_sensor_state *accel_st = iio_priv(st->indio_accel);
>  	struct inv_sensors_timestamp *ts;
>  	int ret;
>  
> @@ -511,7 +513,7 @@ int inv_icm42600_buffer_fifo_parse(struct inv_icm42600_state *st)
>  
>  	/* handle gyroscope timestamp and FIFO data parsing */
>  	if (st->fifo.nb.gyro > 0) {
> -		ts = iio_priv(st->indio_gyro);
> +		ts = &gyro_st->ts;
>  		inv_sensors_timestamp_interrupt(ts, st->fifo.nb.gyro,
>  						st->timestamp.gyro);
>  		ret = inv_icm42600_gyro_parse_fifo(st->indio_gyro);
> @@ -521,7 +523,7 @@ int inv_icm42600_buffer_fifo_parse(struct inv_icm42600_state *st)
>  
>  	/* handle accelerometer timestamp and FIFO data parsing */
>  	if (st->fifo.nb.accel > 0) {
> -		ts = iio_priv(st->indio_accel);
> +		ts = &accel_st->ts;
>  		inv_sensors_timestamp_interrupt(ts, st->fifo.nb.accel,
>  						st->timestamp.accel);
>  		ret = inv_icm42600_accel_parse_fifo(st->indio_accel);
> @@ -535,6 +537,8 @@ int inv_icm42600_buffer_fifo_parse(struct inv_icm42600_state *st)
>  int inv_icm42600_buffer_hwfifo_flush(struct inv_icm42600_state *st,
>  				     unsigned int count)
>  {
> +	struct inv_icm42600_sensor_state *gyro_st = iio_priv(st->indio_gyro);
> +	struct inv_icm42600_sensor_state *accel_st = iio_priv(st->indio_accel);
>  	struct inv_sensors_timestamp *ts;
>  	int64_t gyro_ts, accel_ts;
>  	int ret;
> @@ -550,7 +554,7 @@ int inv_icm42600_buffer_hwfifo_flush(struct inv_icm42600_state *st,
>  		return 0;
>  
>  	if (st->fifo.nb.gyro > 0) {
> -		ts = iio_priv(st->indio_gyro);
> +		ts = &gyro_st->ts;
>  		inv_sensors_timestamp_interrupt(ts, st->fifo.nb.gyro, gyro_ts);
>  		ret = inv_icm42600_gyro_parse_fifo(st->indio_gyro);
>  		if (ret)
> @@ -558,7 +562,7 @@ int inv_icm42600_buffer_hwfifo_flush(struct inv_icm42600_state *st,
>  	}
>  
>  	if (st->fifo.nb.accel > 0) {
> -		ts = iio_priv(st->indio_accel);
> +		ts = &accel_st->ts;
>  		inv_sensors_timestamp_interrupt(ts, st->fifo.nb.accel, accel_ts);
>  		ret = inv_icm42600_accel_parse_fifo(st->indio_accel);
>  		if (ret)


      reply	other threads:[~2024-05-03 16:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03  9:07 [PATCH] iio: imu: inv_icm42600: fix timestamp patch integration inv.git-commit
2024-05-03 10:11 ` Jonathan Cameron
2024-05-03 16:58   ` Jean-Baptiste Maneyrol [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BE1P281MB17451D71F7DA272440D1FCD0CE1F2@BE1P281MB1745.DEUP281.PROD.OUTLOOK.COM \
    --to=jean-baptiste.maneyrol@tdk.com \
    --cc=INV.git-commit@tdk.com \
    --cc=Jonathan.Cameron@Huawei.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).