From: Petar Stoykov <pd.pstoykov@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Angel Iglesias <ang.iglesiasg@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Add support for Sensirion SDP500
Date: Wed, 1 May 2024 12:58:10 +0200 [thread overview]
Message-ID: <CADFWO8Gz__4s2h6Led=oGAObjzkymc=vPsHzZ07HUFU_VCGfTw@mail.gmail.com> (raw)
In-Reply-To: <eb9538fe-1d1a-40e0-a46f-3b4b5da3e8d7@linaro.org>
On Wed, May 1, 2024 at 11:45 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 30/04/2024 17:27, Petar Stoykov wrote:
> > functions in use so it should be fine here too.
> >
> > All feedback is appreciated! Thank you for taking the time to review this.
> >
> > v1->v2:
> > Many fixes suggested by Jonathan Cameron and Krzysztof Kozlowsk.
>
> No, be specific. What EXACTLY changed. This is way too generic.
> Considering entire indentation is broken, I could assume you actually
> did not implement feedback.
>
> Best regards,
> Krzysztof
>
Hi Krzysztof, I'll include all changes in v3 then (or as a response here?).
I just thought it was too much to list all changes.
And about the indentation, can you elaborate please?
prev parent reply other threads:[~2024-05-01 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 15:27 [PATCH v2 0/3] Add support for Sensirion SDP500 Petar Stoykov
2024-04-30 15:37 ` Andy Shevchenko
2024-04-30 16:45 ` Conor Dooley
2024-05-01 10:47 ` Petar Stoykov
2024-05-01 16:39 ` Conor Dooley
2024-05-01 9:45 ` Krzysztof Kozlowski
2024-05-01 10:58 ` Petar Stoykov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADFWO8Gz__4s2h6Led=oGAObjzkymc=vPsHzZ07HUFU_VCGfTw@mail.gmail.com' \
--to=pd.pstoykov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ang.iglesiasg@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).