From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: nuno.sa@analog.com, Petr Mladek <pmladek@suse.com>,
Chris Down <chris@chrisdown.name>,
John Ogness <john.ogness@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Andi Shyti <andi.shyti@kernel.org>,
Jyoti Bhayana <jbhayana@google.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dev_printk: add new dev_err_probe() helpers
Date: Thu, 2 May 2024 18:37:16 +0300 [thread overview]
Message-ID: <ZjOzLJ69qjT5CVQU@smile.fi.intel.com> (raw)
In-Reply-To: <d827817909756e4b65a3bb5753d0243e344109de.camel@gmail.com>
On Thu, May 02, 2024 at 01:54:36PM +0200, Nuno Sá wrote:
> On Tue, 2024-04-23 at 18:45 +0300, Andy Shevchenko wrote:
> > On Tue, Apr 23, 2024 at 06:31:20PM +0300, Andy Shevchenko wrote:
> > > On Tue, Apr 23, 2024 at 05:20:30PM +0200, Nuno Sa via B4 Relay wrote:
> > > > From: Nuno Sa <nuno.sa@analog.com>
...
> > > > +#define dev_err_cast_probe(dev, ___err_ptr, fmt,
> > > > ...) ({ \
> > > > + ERR_PTR(dev_err_probe(dev, PTR_ERR(___err_ptr), fmt,
> > > > ##__VA_ARGS__)); \
> > > > +})
> >
> > After looking into the next patch I think this should be rewritten to use %pe,
> > hence should be an exported function. Or dev_err_probe() should be split to
> > a version that makes the difference between int and const void * (maybe using
> > _Generic()).
>
> I replied a bit in the other patch but I'm of the opinion that's likely just more
> complicated than it needs to be (IMO). Why is the PTR_ERR(___err_ptr) that bad? If we
> really want to have a version that takes pointer why not just:
>
> #define dev_err_ptr_probe(dev, ___err, fmt, ...) \
> dev_err_probe(dev, PTR_ERR(__err), fmt, ##__VA_ARGS__)
>
>
> (yes, while _Generic() could be fun I'm trying to avoid it. In this case, I think
> having explicit defines is more helpful)
It seems dev_err_probe() already uses %pe, so we are fine.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-02 15:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 15:20 [PATCH v2 0/4] dev_printk: add dev_errp_probe() helper Nuno Sa via B4 Relay
2024-04-23 15:20 ` [PATCH v2 1/4] dev_printk: add new dev_err_probe() helpers Nuno Sa via B4 Relay
2024-04-23 15:31 ` Andy Shevchenko
2024-04-23 15:45 ` Andy Shevchenko
2024-05-02 11:54 ` Nuno Sá
2024-05-02 15:37 ` Andy Shevchenko [this message]
2024-05-02 11:34 ` Nuno Sá
2024-04-23 15:20 ` [PATCH v2 2/4] iio: temperature: ltc2983: convert to dev_err_probe() Nuno Sa via B4 Relay
2024-04-23 15:42 ` Andy Shevchenko
2024-05-02 11:41 ` Nuno Sá
2024-04-23 15:20 ` [PATCH v2 3/4] iio: backend: make use of dev_err_cast_probe() Nuno Sa via B4 Relay
2024-04-23 15:20 ` [PATCH v2 4/4] iio: common: scmi_iio: convert to dev_err_probe() Nuno Sa via B4 Relay
2024-04-23 15:50 ` Andy Shevchenko
2024-05-02 11:33 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjOzLJ69qjT5CVQU@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=chris@chrisdown.name \
--cc=gregkh@linuxfoundation.org \
--cc=jbhayana@google.com \
--cc=jic23@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).