From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 2/3] HID: hid-sensor-custom: Convert to platform remove callback returning void
Date: Wed, 06 Mar 2024 10:40:52 -0800 [thread overview]
Message-ID: <bf4206ee5c69c73d487502837b30d0accce85a51.camel@linux.intel.com> (raw)
In-Reply-To: <f4c8334ea1548d911862ede881ab0d90a408c156.1709747164.git.u.kleine-koenig@pengutronix.de>
On Wed, 2024-03-06 at 18:50 +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which
> makes
> many driver authors wrongly assume it's possible to do error handling
> by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource
> leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all
> drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the
> remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/hid-sensor-custom.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> sensor-custom.c
> index d85398721659..de7287f3af61 100644
> --- a/drivers/hid/hid-sensor-custom.c
> +++ b/drivers/hid/hid-sensor-custom.c
> @@ -1032,14 +1032,14 @@ static int hid_sensor_custom_probe(struct
> platform_device *pdev)
> return ret;
> }
>
> -static int hid_sensor_custom_remove(struct platform_device *pdev)
> +static void hid_sensor_custom_remove(struct platform_device *pdev)
> {
> struct hid_sensor_custom *sensor_inst =
> platform_get_drvdata(pdev);
> struct hid_sensor_hub_device *hsdev = pdev-
> >dev.platform_data;
>
> if (sensor_inst->custom_pdev) {
> platform_device_unregister(sensor_inst->custom_pdev);
> - return 0;
> + return;
> }
>
> hid_sensor_custom_dev_if_remove(sensor_inst);
> @@ -1047,8 +1047,6 @@ static int hid_sensor_custom_remove(struct
> platform_device *pdev)
> sysfs_remove_group(&sensor_inst->pdev->dev.kobj,
> &enable_sensor_attr_group);
> sensor_hub_remove_callback(hsdev, hsdev->usage);
> -
> - return 0;
> }
>
> static const struct platform_device_id hid_sensor_custom_ids[] = {
> @@ -1068,7 +1066,7 @@ static struct platform_driver
> hid_sensor_custom_platform_driver = {
> .name = KBUILD_MODNAME,
> },
> .probe = hid_sensor_custom_probe,
> - .remove = hid_sensor_custom_remove,
> + .remove_new = hid_sensor_custom_remove,
> };
> module_platform_driver(hid_sensor_custom_platform_driver);
>
next prev parent reply other threads:[~2024-03-06 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 17:50 [PATCH 0/3] HID: Convert to platform remove callback returning void Uwe Kleine-König
2024-03-06 17:50 ` [PATCH 2/3] HID: hid-sensor-custom: " Uwe Kleine-König
2024-03-06 18:40 ` srinivas pandruvada [this message]
2024-03-09 18:40 ` Jonathan Cameron
2024-04-03 11:23 ` [PATCH 0/3] HID: " Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf4206ee5c69c73d487502837b30d0accce85a51.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).