From: Rob Herring <robh@kernel.org>
To: Allen_Lin <allencl_lin@hotmail.com>
Cc: benjamin.tissoires@redhat.com, krzysztof.kozlowski+dt@linaro.org,
jikos@kernel.org, linux-input@vger.kernel.org, conor@kernel.org,
dmitry.torokhov@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: input: Add Himax HX83102J touchscreen
Date: Mon, 15 Apr 2024 22:31:06 -0500 [thread overview]
Message-ID: <171323826551.687221.15997746992976614579.robh@kernel.org> (raw)
In-Reply-To: <TY0PR06MB56112682F500F8761F76DBA99E082@TY0PR06MB5611.apcprd06.prod.outlook.com>
On Tue, 16 Apr 2024 10:12:25 +0800, Allen_Lin wrote:
> Add the HX83102j touchscreen device tree bindings documents.
> HX83102j is a Himax TDDI touchscreen controller.
> It's power sequence should be bound with a lcm driver, thus it
> needs to be a panel follower. Others are the same as normal SPI
> touchscreen controller.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> Signed-off-by: Allen_Lin <allencl_lin@hotmail.com>
> ---
> .../input/touchscreen/himax,hx83102j.yaml | 93 +++++++++++++++++++
> MAINTAINERS | 6 ++
> 2 files changed, 99 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/himax,hx83102j.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/input/touchscreen/himax,hx83102j.yaml:93:7: [error] no new line character at the end of file (new-line-at-end-of-file)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/TY0PR06MB56112682F500F8761F76DBA99E082@TY0PR06MB5611.apcprd06.prod.outlook.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-04-16 3:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240416021228.1092678-1-allencl_lin@hotmail.com>
2024-04-16 2:12 ` [PATCH v3 1/4] dt-bindings: input: Add Himax HX83102J touchscreen Allen_Lin
2024-04-16 3:31 ` Rob Herring [this message]
2024-04-16 2:12 ` [PATCH v3 2/4] HID: Add Himax HX83102J touchscreen driver Allen_Lin
2024-04-16 2:12 ` [PATCH v3 3/4] HID: Add DRM panel follower function Allen_Lin
2024-04-16 2:12 ` [PATCH v3 4/4] HID: Load firmware directly from file to IC Allen_Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171323826551.687221.15997746992976614579.robh@kernel.org \
--to=robh@kernel.org \
--cc=allencl_lin@hotmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).