* [PATCH 0/7] HID: unused struct members cleanup
@ 2024-02-01 11:53 Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 1/7] HID: apple: remove unused members from struct apple_sc_backlight Jiri Slaby (SUSE)
` (7 more replies)
0 siblings, 8 replies; 11+ messages in thread
From: Jiri Slaby (SUSE) @ 2024-02-01 11:53 UTC (permalink / raw
To: jikos; +Cc: linux-input, linux-kernel, Jiri Slaby (SUSE)
Hi,
the patches deal with unused members of structures as found by
clang-struct.
Sometimes even whole structures are removed.
Jiri Slaby (SUSE) (7):
HID: apple: remove unused members from struct apple_sc_backlight
HID: wacom: remove unused hid_data::pressure
HID: protect hid_device::bpf by CONFIG_HID_BPF
HID: hid-lg3ff: remove unused struct lg3ff_device
HID: hid-multitouch: remove unused mt_application::dev_time
HID: hid-prodikeys: remove unused struct pcmidi_snd members
HID: hid-prodikeys: remove struct pk_device
drivers/hid/hid-apple.c | 1 -
drivers/hid/hid-lg3ff.c | 4 --
drivers/hid/hid-multitouch.c | 1 -
drivers/hid/hid-prodikeys.c | 115 ++++++++++++-----------------------
drivers/hid/wacom_wac.h | 1 -
include/linux/hid.h | 4 +-
6 files changed, 42 insertions(+), 84 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/7] HID: apple: remove unused members from struct apple_sc_backlight
2024-02-01 11:53 [PATCH 0/7] HID: unused struct members cleanup Jiri Slaby (SUSE)
@ 2024-02-01 11:53 ` Jiri Slaby (SUSE)
2024-02-14 12:54 ` Aditya Garg
2024-02-01 11:53 ` [PATCH 2/7] HID: wacom: remove unused hid_data::pressure Jiri Slaby (SUSE)
` (6 subsequent siblings)
7 siblings, 1 reply; 11+ messages in thread
From: Jiri Slaby (SUSE) @ 2024-02-01 11:53 UTC (permalink / raw
To: jikos
Cc: linux-input, linux-kernel, Jiri Slaby (SUSE), Paul Pawlowski,
Aun-Ali Zaidi, Aditya Garg, Benjamin Tissoires
The backlight members in struct apple_sc_backlight are unused. They were
added in commit 9018eacbe623 (HID: apple: Add support for keyboard
backlight on certain T2 Macs.), but never used.
As this is not a struct to communicate with the HW, remove these.
Found by https://github.com/jirislaby/clang-struct.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Paul Pawlowski <paul@mrarm.io>
Cc: Aun-Ali Zaidi <admin@kodeit.net>
Cc: Aditya Garg <gargaditya08@live.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/hid-apple.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index b9c7c0ed7bcc..bd022e004356 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -79,7 +79,6 @@ struct apple_non_apple_keyboard {
struct apple_sc_backlight {
struct led_classdev cdev;
struct hid_device *hdev;
- unsigned short backlight_off, backlight_on_min, backlight_on_max;
};
struct apple_sc {
--
2.43.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/7] HID: wacom: remove unused hid_data::pressure
2024-02-01 11:53 [PATCH 0/7] HID: unused struct members cleanup Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 1/7] HID: apple: remove unused members from struct apple_sc_backlight Jiri Slaby (SUSE)
@ 2024-02-01 11:53 ` Jiri Slaby (SUSE)
2024-02-02 2:30 ` Ping Cheng
2024-02-01 11:53 ` [PATCH 3/7] HID: protect hid_device::bpf by CONFIG_HID_BPF Jiri Slaby (SUSE)
` (5 subsequent siblings)
7 siblings, 1 reply; 11+ messages in thread
From: Jiri Slaby (SUSE) @ 2024-02-01 11:53 UTC (permalink / raw
To: jikos
Cc: linux-input, linux-kernel, Jiri Slaby (SUSE), Ping Cheng,
Jason Gerecke, Benjamin Tissoires
The pressure member in struct hid_data is unused. It was
added in commit 5ae6e89f7409 (HID: wacom: implement the finger part of
the HID generic handling), but never used.
As this is not a struct to communicate with the HW, remove that member.
Found by https://github.com/jirislaby/clang-struct.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Ping Cheng <ping.cheng@wacom.com>
Cc: Jason Gerecke <jason.gerecke@wacom.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/wacom_wac.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hid/wacom_wac.h b/drivers/hid/wacom_wac.h
index e63b1e806e34..6ec499841f70 100644
--- a/drivers/hid/wacom_wac.h
+++ b/drivers/hid/wacom_wac.h
@@ -309,7 +309,6 @@ struct hid_data {
bool confidence;
int x;
int y;
- int pressure;
int width;
int height;
int id;
--
2.43.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/7] HID: protect hid_device::bpf by CONFIG_HID_BPF
2024-02-01 11:53 [PATCH 0/7] HID: unused struct members cleanup Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 1/7] HID: apple: remove unused members from struct apple_sc_backlight Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 2/7] HID: wacom: remove unused hid_data::pressure Jiri Slaby (SUSE)
@ 2024-02-01 11:53 ` Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 4/7] HID: hid-lg3ff: remove unused struct lg3ff_device Jiri Slaby (SUSE)
` (4 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Jiri Slaby (SUSE) @ 2024-02-01 11:53 UTC (permalink / raw
To: jikos; +Cc: linux-input, linux-kernel, Jiri Slaby (SUSE), Benjamin Tissoires
And not by CONFIG_BPF. BPF can be selected while HID_BPF does not have
to. It actually cannot be on some platforms due to Kconfig dependences.
This saves quite some bytes on those setups.
Found by https://github.com/jirislaby/clang-struct.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
include/linux/hid.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/hid.h b/include/linux/hid.h
index 7c26db874ff0..b12cb1c8e682 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -683,9 +683,9 @@ struct hid_device { /* device report descriptor */
unsigned int id; /* system unique id */
-#ifdef CONFIG_BPF
+#ifdef CONFIG_HID_BPF
struct hid_bpf bpf; /* hid-bpf data */
-#endif /* CONFIG_BPF */
+#endif /* CONFIG_HID_BPF */
};
void hiddev_free(struct kref *ref);
--
2.43.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/7] HID: hid-lg3ff: remove unused struct lg3ff_device
2024-02-01 11:53 [PATCH 0/7] HID: unused struct members cleanup Jiri Slaby (SUSE)
` (2 preceding siblings ...)
2024-02-01 11:53 ` [PATCH 3/7] HID: protect hid_device::bpf by CONFIG_HID_BPF Jiri Slaby (SUSE)
@ 2024-02-01 11:53 ` Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 5/7] HID: hid-multitouch: remove unused mt_application::dev_time Jiri Slaby (SUSE)
` (3 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Jiri Slaby (SUSE) @ 2024-02-01 11:53 UTC (permalink / raw
To: jikos
Cc: linux-input, linux-kernel, Jiri Slaby (SUSE), Gary Stein,
Benjamin Tissoires
struct lg3ff_device is present in the driver since its addition by
commit 74f292ca8c7a (HID: add driver for the Logitech Flight System
G940).
But it was never used, remove it.
Found by https://github.com/jirislaby/clang-struct.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Gary Stein <LordCnidarian@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/hid-lg3ff.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/hid/hid-lg3ff.c b/drivers/hid/hid-lg3ff.c
index b7e1949f3cf7..109735b89b7a 100644
--- a/drivers/hid/hid-lg3ff.c
+++ b/drivers/hid/hid-lg3ff.c
@@ -41,10 +41,6 @@
* I'm sure these are effects that I don't know enough about them
*/
-struct lg3ff_device {
- struct hid_report *report;
-};
-
static int hid_lg3ff_play(struct input_dev *dev, void *data,
struct ff_effect *effect)
{
--
2.43.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 5/7] HID: hid-multitouch: remove unused mt_application::dev_time
2024-02-01 11:53 [PATCH 0/7] HID: unused struct members cleanup Jiri Slaby (SUSE)
` (3 preceding siblings ...)
2024-02-01 11:53 ` [PATCH 4/7] HID: hid-lg3ff: remove unused struct lg3ff_device Jiri Slaby (SUSE)
@ 2024-02-01 11:53 ` Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 6/7] HID: hid-prodikeys: remove unused struct pcmidi_snd members Jiri Slaby (SUSE)
` (2 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Jiri Slaby (SUSE) @ 2024-02-01 11:53 UTC (permalink / raw
To: jikos; +Cc: linux-input, linux-kernel, Jiri Slaby (SUSE), Benjamin Tissoires
dev_time was moved to struct mt_application in commit f146d1c4d7ea (HID:
multitouch: Store per collection multitouch data), but is not used since
then. Remove it.
Found by https://github.com/jirislaby/clang-struct.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/hid-multitouch.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index fd5b0637dad6..40475c42b9f6 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -130,7 +130,6 @@ struct mt_application {
* > 1 means hybrid (multitouch) protocol
*/
- __s32 dev_time; /* the scan time provided by the device */
unsigned long jiffies; /* the frame's jiffies */
int timestamp; /* the timestamp to be sent */
int prev_scantime; /* scantime reported previously */
--
2.43.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 6/7] HID: hid-prodikeys: remove unused struct pcmidi_snd members
2024-02-01 11:53 [PATCH 0/7] HID: unused struct members cleanup Jiri Slaby (SUSE)
` (4 preceding siblings ...)
2024-02-01 11:53 ` [PATCH 5/7] HID: hid-multitouch: remove unused mt_application::dev_time Jiri Slaby (SUSE)
@ 2024-02-01 11:53 ` Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 7/7] HID: hid-prodikeys: remove struct pk_device Jiri Slaby (SUSE)
2024-02-13 10:44 ` [PATCH 0/7] HID: unused struct members cleanup Jiri Kosina
7 siblings, 0 replies; 11+ messages in thread
From: Jiri Slaby (SUSE) @ 2024-02-01 11:53 UTC (permalink / raw
To: jikos; +Cc: linux-input, linux-kernel, Jiri Slaby (SUSE), Benjamin Tissoires
struct pcmidi_snd contains two unused members: out_substream and
out_active. They were added along the driver in commit 3a370ca1dcf8
(HID: Prodikeys PC-MIDI HID Driver), but not used.
Drop them.
Found by https://github.com/jirislaby/clang-struct.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/hid-prodikeys.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c
index c16d2ba6ea16..439f4320f1d2 100644
--- a/drivers/hid/hid-prodikeys.c
+++ b/drivers/hid/hid-prodikeys.c
@@ -66,9 +66,7 @@ struct pcmidi_snd {
struct snd_card *card;
struct snd_rawmidi *rwmidi;
struct snd_rawmidi_substream *in_substream;
- struct snd_rawmidi_substream *out_substream;
unsigned long in_triggered;
- unsigned long out_active;
};
#define PK_QUIRK_NOGET 0x00010000
--
2.43.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 7/7] HID: hid-prodikeys: remove struct pk_device
2024-02-01 11:53 [PATCH 0/7] HID: unused struct members cleanup Jiri Slaby (SUSE)
` (5 preceding siblings ...)
2024-02-01 11:53 ` [PATCH 6/7] HID: hid-prodikeys: remove unused struct pcmidi_snd members Jiri Slaby (SUSE)
@ 2024-02-01 11:53 ` Jiri Slaby (SUSE)
2024-02-13 10:44 ` [PATCH 0/7] HID: unused struct members cleanup Jiri Kosina
7 siblings, 0 replies; 11+ messages in thread
From: Jiri Slaby (SUSE) @ 2024-02-01 11:53 UTC (permalink / raw
To: jikos; +Cc: linux-input, linux-kernel, Jiri Slaby (SUSE), Benjamin Tissoires
First, quirks was unused in struct pk_device.
And I see no reason for this additional level of indirection. struct
pcmidi_snd is far enough for the driver. Unless I am missing something?
So drop struct pk_device and convert all the users to use struct
pcmidi_snd directly. No need for doubled kmalloc+kfrees now.
Found by https://github.com/jirislaby/clang-struct.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/hid-prodikeys.c | 113 +++++++++++++-----------------------
1 file changed, 40 insertions(+), 73 deletions(-)
diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c
index 439f4320f1d2..a593ed62c969 100644
--- a/drivers/hid/hid-prodikeys.c
+++ b/drivers/hid/hid-prodikeys.c
@@ -32,13 +32,6 @@
struct pcmidi_snd;
-struct pk_device {
- unsigned long quirks;
-
- struct hid_device *hdev;
- struct pcmidi_snd *pm; /* pcmidi device context */
-};
-
struct pcmidi_sustain {
unsigned long in_use;
struct pcmidi_snd *pm;
@@ -50,7 +43,7 @@ struct pcmidi_sustain {
#define PCMIDI_SUSTAINED_MAX 32
struct pcmidi_snd {
- struct pk_device *pk;
+ struct hid_device *hdev;
unsigned short ifnum;
struct hid_report *pcmidi_report6;
struct input_dev *input_ep82;
@@ -98,11 +91,11 @@ static ssize_t show_channel(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct hid_device *hdev = to_hid_device(dev);
- struct pk_device *pk = hid_get_drvdata(hdev);
+ struct pcmidi_snd *pm = hid_get_drvdata(hdev);
- dbg_hid("pcmidi sysfs read channel=%u\n", pk->pm->midi_channel);
+ dbg_hid("pcmidi sysfs read channel=%u\n", pm->midi_channel);
- return sprintf(buf, "%u (min:%u, max:%u)\n", pk->pm->midi_channel,
+ return sprintf(buf, "%u (min:%u, max:%u)\n", pm->midi_channel,
PCMIDI_CHANNEL_MIN, PCMIDI_CHANNEL_MAX);
}
@@ -111,13 +104,13 @@ static ssize_t store_channel(struct device *dev,
struct device_attribute *attr, const char *buf, size_t count)
{
struct hid_device *hdev = to_hid_device(dev);
- struct pk_device *pk = hid_get_drvdata(hdev);
+ struct pcmidi_snd *pm = hid_get_drvdata(hdev);
unsigned channel = 0;
if (sscanf(buf, "%u", &channel) > 0 && channel <= PCMIDI_CHANNEL_MAX) {
dbg_hid("pcmidi sysfs write channel=%u\n", channel);
- pk->pm->midi_channel = channel;
+ pm->midi_channel = channel;
return strlen(buf);
}
return -EINVAL;
@@ -135,11 +128,11 @@ static ssize_t show_sustain(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct hid_device *hdev = to_hid_device(dev);
- struct pk_device *pk = hid_get_drvdata(hdev);
+ struct pcmidi_snd *pm = hid_get_drvdata(hdev);
- dbg_hid("pcmidi sysfs read sustain=%u\n", pk->pm->midi_sustain);
+ dbg_hid("pcmidi sysfs read sustain=%u\n", pm->midi_sustain);
- return sprintf(buf, "%u (off:%u, max:%u (ms))\n", pk->pm->midi_sustain,
+ return sprintf(buf, "%u (off:%u, max:%u (ms))\n", pm->midi_sustain,
PCMIDI_SUSTAIN_MIN, PCMIDI_SUSTAIN_MAX);
}
@@ -148,15 +141,14 @@ static ssize_t store_sustain(struct device *dev,
struct device_attribute *attr, const char *buf, size_t count)
{
struct hid_device *hdev = to_hid_device(dev);
- struct pk_device *pk = hid_get_drvdata(hdev);
+ struct pcmidi_snd *pm = hid_get_drvdata(hdev);
unsigned sustain = 0;
if (sscanf(buf, "%u", &sustain) > 0 && sustain <= PCMIDI_SUSTAIN_MAX) {
dbg_hid("pcmidi sysfs write sustain=%u\n", sustain);
- pk->pm->midi_sustain = sustain;
- pk->pm->midi_sustain_mode =
- (0 == sustain || !pk->pm->midi_mode) ? 0 : 1;
+ pm->midi_sustain = sustain;
+ pm->midi_sustain_mode = (0 == sustain || !pm->midi_mode) ? 0 : 1;
return strlen(buf);
}
return -EINVAL;
@@ -174,11 +166,11 @@ static ssize_t show_octave(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct hid_device *hdev = to_hid_device(dev);
- struct pk_device *pk = hid_get_drvdata(hdev);
+ struct pcmidi_snd *pm = hid_get_drvdata(hdev);
- dbg_hid("pcmidi sysfs read octave=%d\n", pk->pm->midi_octave);
+ dbg_hid("pcmidi sysfs read octave=%d\n", pm->midi_octave);
- return sprintf(buf, "%d (min:%d, max:%d)\n", pk->pm->midi_octave,
+ return sprintf(buf, "%d (min:%d, max:%d)\n", pm->midi_octave,
PCMIDI_OCTAVE_MIN, PCMIDI_OCTAVE_MAX);
}
@@ -187,14 +179,14 @@ static ssize_t store_octave(struct device *dev,
struct device_attribute *attr, const char *buf, size_t count)
{
struct hid_device *hdev = to_hid_device(dev);
- struct pk_device *pk = hid_get_drvdata(hdev);
+ struct pcmidi_snd *pm = hid_get_drvdata(hdev);
int octave = 0;
if (sscanf(buf, "%d", &octave) > 0 &&
octave >= PCMIDI_OCTAVE_MIN && octave <= PCMIDI_OCTAVE_MAX) {
dbg_hid("pcmidi sysfs write octave=%d\n", octave);
- pk->pm->midi_octave = octave;
+ pm->midi_octave = octave;
return strlen(buf);
}
return -EINVAL;
@@ -268,7 +260,7 @@ static void stop_sustain_timers(struct pcmidi_snd *pm)
static int pcmidi_get_output_report(struct pcmidi_snd *pm)
{
- struct hid_device *hdev = pm->pk->hdev;
+ struct hid_device *hdev = pm->hdev;
struct hid_report *report;
list_for_each_entry(report,
@@ -293,7 +285,7 @@ static int pcmidi_get_output_report(struct pcmidi_snd *pm)
static void pcmidi_submit_output_report(struct pcmidi_snd *pm, int state)
{
- struct hid_device *hdev = pm->pk->hdev;
+ struct hid_device *hdev = pm->hdev;
struct hid_report *report = pm->pcmidi_report6;
report->field[0]->value[0] = 0x01;
report->field[0]->value[1] = state;
@@ -620,7 +612,7 @@ static int pcmidi_snd_initialise(struct pcmidi_snd *pm)
/* Setup sound card */
- err = snd_card_new(&pm->pk->hdev->dev, index[dev], id[dev],
+ err = snd_card_new(&pm->hdev->dev, index[dev], id[dev],
THIS_MODULE, 0, &card);
if (err < 0) {
pk_error("failed to create pc-midi sound card\n");
@@ -658,7 +650,7 @@ static int pcmidi_snd_initialise(struct pcmidi_snd *pm)
&pcmidi_in_ops);
/* create sysfs variables */
- err = device_create_file(&pm->pk->hdev->dev,
+ err = device_create_file(&pm->hdev->dev,
sysfs_device_attr_channel);
if (err < 0) {
pk_error("failed to create sysfs attribute channel: error %d\n",
@@ -666,7 +658,7 @@ static int pcmidi_snd_initialise(struct pcmidi_snd *pm)
goto fail;
}
- err = device_create_file(&pm->pk->hdev->dev,
+ err = device_create_file(&pm->hdev->dev,
sysfs_device_attr_sustain);
if (err < 0) {
pk_error("failed to create sysfs attribute sustain: error %d\n",
@@ -674,7 +666,7 @@ static int pcmidi_snd_initialise(struct pcmidi_snd *pm)
goto fail_attr_sustain;
}
- err = device_create_file(&pm->pk->hdev->dev,
+ err = device_create_file(&pm->hdev->dev,
sysfs_device_attr_octave);
if (err < 0) {
pk_error("failed to create sysfs attribute octave: error %d\n",
@@ -704,11 +696,11 @@ static int pcmidi_snd_initialise(struct pcmidi_snd *pm)
fail_register:
stop_sustain_timers(pm);
- device_remove_file(&pm->pk->hdev->dev, sysfs_device_attr_octave);
+ device_remove_file(&pm->hdev->dev, sysfs_device_attr_octave);
fail_attr_octave:
- device_remove_file(&pm->pk->hdev->dev, sysfs_device_attr_sustain);
+ device_remove_file(&pm->hdev->dev, sysfs_device_attr_sustain);
fail_attr_sustain:
- device_remove_file(&pm->pk->hdev->dev, sysfs_device_attr_channel);
+ device_remove_file(&pm->hdev->dev, sysfs_device_attr_channel);
fail:
if (pm->card) {
snd_card_free(pm->card);
@@ -722,12 +714,9 @@ static int pcmidi_snd_terminate(struct pcmidi_snd *pm)
if (pm->card) {
stop_sustain_timers(pm);
- device_remove_file(&pm->pk->hdev->dev,
- sysfs_device_attr_channel);
- device_remove_file(&pm->pk->hdev->dev,
- sysfs_device_attr_sustain);
- device_remove_file(&pm->pk->hdev->dev,
- sysfs_device_attr_octave);
+ device_remove_file(&pm->hdev->dev, sysfs_device_attr_channel);
+ device_remove_file(&pm->hdev->dev, sysfs_device_attr_sustain);
+ device_remove_file(&pm->hdev->dev, sysfs_device_attr_octave);
snd_card_disconnect(pm->card);
snd_card_free_when_closed(pm->card);
@@ -757,10 +746,7 @@ static int pk_input_mapping(struct hid_device *hdev, struct hid_input *hi,
struct hid_field *field, struct hid_usage *usage,
unsigned long **bit, int *max)
{
- struct pk_device *pk = hid_get_drvdata(hdev);
- struct pcmidi_snd *pm;
-
- pm = pk->pm;
+ struct pcmidi_snd *pm = hid_get_drvdata(hdev);
if (HID_UP_MSVENDOR == (usage->hid & HID_USAGE_PAGE) &&
1 == pm->ifnum) {
@@ -775,16 +761,16 @@ static int pk_input_mapping(struct hid_device *hdev, struct hid_input *hi,
static int pk_raw_event(struct hid_device *hdev, struct hid_report *report,
u8 *data, int size)
{
- struct pk_device *pk = hid_get_drvdata(hdev);
+ struct pcmidi_snd *pm = hid_get_drvdata(hdev);
int ret = 0;
- if (1 == pk->pm->ifnum) {
+ if (1 == pm->ifnum) {
if (report->id == data[0])
switch (report->id) {
case 0x01: /* midi keys (qwerty)*/
case 0x03: /* midi keyboard (musical)*/
case 0x04: /* extra/midi keys (qwerty)*/
- ret = pcmidi_handle_report(pk->pm,
+ ret = pcmidi_handle_report(pm,
report->id, data, size);
break;
}
@@ -799,8 +785,7 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)
struct usb_interface *intf;
unsigned short ifnum;
unsigned long quirks = id->driver_data;
- struct pk_device *pk;
- struct pcmidi_snd *pm = NULL;
+ struct pcmidi_snd *pm;
if (!hid_is_usb(hdev))
return -EINVAL;
@@ -808,26 +793,16 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)
intf = to_usb_interface(hdev->dev.parent);
ifnum = intf->cur_altsetting->desc.bInterfaceNumber;
- pk = kzalloc(sizeof(*pk), GFP_KERNEL);
- if (pk == NULL) {
- hid_err(hdev, "can't alloc descriptor\n");
- return -ENOMEM;
- }
-
- pk->hdev = hdev;
-
pm = kzalloc(sizeof(*pm), GFP_KERNEL);
if (pm == NULL) {
hid_err(hdev, "can't alloc descriptor\n");
- ret = -ENOMEM;
- goto err_free_pk;
+ return -ENOMEM;
}
- pm->pk = pk;
- pk->pm = pm;
+ pm->hdev = hdev;
pm->ifnum = ifnum;
- hid_set_drvdata(hdev, pk);
+ hid_set_drvdata(hdev, pm);
ret = hid_parse(hdev);
if (ret) {
@@ -854,26 +829,18 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)
hid_hw_stop(hdev);
err_free:
kfree(pm);
-err_free_pk:
- kfree(pk);
return ret;
}
static void pk_remove(struct hid_device *hdev)
{
- struct pk_device *pk = hid_get_drvdata(hdev);
- struct pcmidi_snd *pm;
-
- pm = pk->pm;
- if (pm) {
- pcmidi_snd_terminate(pm);
- kfree(pm);
- }
+ struct pcmidi_snd *pm = hid_get_drvdata(hdev);
+ pcmidi_snd_terminate(pm);
hid_hw_stop(hdev);
- kfree(pk);
+ kfree(pm);
}
static const struct hid_device_id pk_devices[] = {
--
2.43.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 2/7] HID: wacom: remove unused hid_data::pressure
2024-02-01 11:53 ` [PATCH 2/7] HID: wacom: remove unused hid_data::pressure Jiri Slaby (SUSE)
@ 2024-02-02 2:30 ` Ping Cheng
0 siblings, 0 replies; 11+ messages in thread
From: Ping Cheng @ 2024-02-02 2:30 UTC (permalink / raw
To: Jiri Slaby (SUSE)
Cc: jikos, linux-input, linux-kernel, Ping Cheng, Jason Gerecke,
Benjamin Tissoires
On Thu, Feb 1, 2024 at 3:53 AM Jiri Slaby (SUSE) <jirislaby@kernel.org> wrote:
>
> The pressure member in struct hid_data is unused. It was
> added in commit 5ae6e89f7409 (HID: wacom: implement the finger part of
> the HID generic handling), but never used.
>
> As this is not a struct to communicate with the HW, remove that member.
>
> Found by https://github.com/jirislaby/clang-struct.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Wacom current touch devices do not support pressure. We could add pressure
back when it is necessary in the future. Thank you Jiri.
Acked-by: Ping Cheng <ping.cheng@wacom.com>
Cheers,
Ping
> Cc: Ping Cheng <ping.cheng@wacom.com>
> Cc: Jason Gerecke <jason.gerecke@wacom.com>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
> drivers/hid/wacom_wac.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hid/wacom_wac.h b/drivers/hid/wacom_wac.h
> index e63b1e806e34..6ec499841f70 100644
> --- a/drivers/hid/wacom_wac.h
> +++ b/drivers/hid/wacom_wac.h
> @@ -309,7 +309,6 @@ struct hid_data {
> bool confidence;
> int x;
> int y;
> - int pressure;
> int width;
> int height;
> int id;
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/7] HID: unused struct members cleanup
2024-02-01 11:53 [PATCH 0/7] HID: unused struct members cleanup Jiri Slaby (SUSE)
` (6 preceding siblings ...)
2024-02-01 11:53 ` [PATCH 7/7] HID: hid-prodikeys: remove struct pk_device Jiri Slaby (SUSE)
@ 2024-02-13 10:44 ` Jiri Kosina
7 siblings, 0 replies; 11+ messages in thread
From: Jiri Kosina @ 2024-02-13 10:44 UTC (permalink / raw
To: Jiri Slaby (SUSE); +Cc: linux-input, linux-kernel
On Thu, 1 Feb 2024, Jiri Slaby (SUSE) wrote:
> Hi,
>
> the patches deal with unused members of structures as found by
> clang-struct.
>
> Sometimes even whole structures are removed.
Good stuff, thanks. Applied to hid.git#for-6.9/unused-struct-removal.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/7] HID: apple: remove unused members from struct apple_sc_backlight
2024-02-01 11:53 ` [PATCH 1/7] HID: apple: remove unused members from struct apple_sc_backlight Jiri Slaby (SUSE)
@ 2024-02-14 12:54 ` Aditya Garg
0 siblings, 0 replies; 11+ messages in thread
From: Aditya Garg @ 2024-02-14 12:54 UTC (permalink / raw
To: Jiri Slaby (SUSE)
Cc: jikos@kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, Paul Pawlowski, Aun-Ali Zaidi,
Benjamin Tissoires
Hi Jiri
I got this patch tested by a user and no regression was reported.
Thanks
> On 01-Feb-2024, at 5:23 PM, Jiri Slaby (SUSE) <jirislaby@kernel.org> wrote:
>
> The backlight members in struct apple_sc_backlight are unused. They were
> added in commit 9018eacbe623 (HID: apple: Add support for keyboard
> backlight on certain T2 Macs.), but never used.
>
> As this is not a struct to communicate with the HW, remove these.
>
> Found by https://github.com/jirislaby/clang-struct.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Paul Pawlowski <paul@mrarm.io>
> Cc: Aun-Ali Zaidi <admin@kodeit.net>
> Cc: Aditya Garg <gargaditya08@live.com>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
> drivers/hid/hid-apple.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index b9c7c0ed7bcc..bd022e004356 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -79,7 +79,6 @@ struct apple_non_apple_keyboard {
> struct apple_sc_backlight {
> struct led_classdev cdev;
> struct hid_device *hdev;
> - unsigned short backlight_off, backlight_on_min, backlight_on_max;
> };
>
> struct apple_sc {
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2024-02-14 12:54 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-01 11:53 [PATCH 0/7] HID: unused struct members cleanup Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 1/7] HID: apple: remove unused members from struct apple_sc_backlight Jiri Slaby (SUSE)
2024-02-14 12:54 ` Aditya Garg
2024-02-01 11:53 ` [PATCH 2/7] HID: wacom: remove unused hid_data::pressure Jiri Slaby (SUSE)
2024-02-02 2:30 ` Ping Cheng
2024-02-01 11:53 ` [PATCH 3/7] HID: protect hid_device::bpf by CONFIG_HID_BPF Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 4/7] HID: hid-lg3ff: remove unused struct lg3ff_device Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 5/7] HID: hid-multitouch: remove unused mt_application::dev_time Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 6/7] HID: hid-prodikeys: remove unused struct pcmidi_snd members Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 7/7] HID: hid-prodikeys: remove struct pk_device Jiri Slaby (SUSE)
2024-02-13 10:44 ` [PATCH 0/7] HID: unused struct members cleanup Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).