* gamecube adapter driver
@ 2024-05-06 16:19 Carson
2024-05-06 19:32 ` Milas Robin
0 siblings, 1 reply; 4+ messages in thread
From: Carson @ 2024-05-06 16:19 UTC (permalink / raw
To: dmitry.torokhov, milas.robin; +Cc: linux-input
Hi everyone! I wanted to ask if the driver for the gamecube adapter has been
merged. I was going to create one but I see it's already done, is there a
subsystem tree I can clone and build somewhere?
^ permalink raw reply [flat|nested] 4+ messages in thread
* gamecube adapter driver
2024-05-06 16:19 gamecube adapter driver Carson
@ 2024-05-06 19:32 ` Milas Robin
2024-05-07 18:04 ` Carson
0 siblings, 1 reply; 4+ messages in thread
From: Milas Robin @ 2024-05-06 19:32 UTC (permalink / raw
To: crange76; +Cc: dmitry.torokhov, linux-input, milas.robin
Hi,
I don't think so, I didn't received any reply so I guess it is not ?
If you have some time to review the code I would be grateful.
As I said in the cover letter (which didn't linked correctly), this is
my first kernel module so there might be some basic architecture notably
on race conditions.
Also due to the way I've implemented it, if it is build as a module
it lose priority over the usb-hid generic driver as the device report
supporting hid it.
One other thing which might make the code heavier to read is properly detecting
if the controller really support rumbles, I actually ignore the bit signalling
it cause I don't know if the adapter could change it without unplugging the
controller which might lead to have to recreate the device to switch it's
rumbling capability
The patch seems to have no conflict with the current input/next branch.
If you need a branch I've uploaded it on https://github.com/Hinara/linux.git
The branch is called ngc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: gamecube adapter driver
2024-05-06 19:32 ` Milas Robin
@ 2024-05-07 18:04 ` Carson
2024-05-07 19:04 ` Milas Robin
0 siblings, 1 reply; 4+ messages in thread
From: Carson @ 2024-05-07 18:04 UTC (permalink / raw
To: Milas Robin; +Cc: dmitry.torokhov, linux-input, milas.robin
On Monday, May 6, 2024 3:32:20 PM EDT Milas Robin wrote:
> Hi,
>
> I don't think so, I didn't received any reply so I guess it is not ?
> If you have some time to review the code I would be grateful.
> As I said in the cover letter (which didn't linked correctly), this is
> my first kernel module so there might be some basic architecture notably
> on race conditions.
>
> Also due to the way I've implemented it, if it is build as a module
> it lose priority over the usb-hid generic driver as the device report
> supporting hid it.
>
> One other thing which might make the code heavier to read is properly
> detecting if the controller really support rumbles, I actually ignore the
> bit signalling it cause I don't know if the adapter could change it without
> unplugging the controller which might lead to have to recreate the device
> to switch it's rumbling capability
>
> The patch seems to have no conflict with the current input/next branch.
> If you need a branch I've uploaded it on https://github.com/Hinara/linux.git
> The branch is called ngc.
I've built the kernel but it won't boot, its likely a issue with my config but
could you rebase the patch to a newer kernel. Also I believe we are not
contacting the correct person for a merge.
https://github.com/torvalds/linux/blob/master/MAINTAINERS#L15595
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: gamecube adapter driver
2024-05-07 18:04 ` Carson
@ 2024-05-07 19:04 ` Milas Robin
0 siblings, 0 replies; 4+ messages in thread
From: Milas Robin @ 2024-05-07 19:04 UTC (permalink / raw
To: crange76; +Cc: dmitry.torokhov, linux-input, milas.robin
> I've built the kernel but it won't boot, its likely a issue with my config but
> could you rebase the patch to a newer kernel.
This patch is based on next branch from the input repo:
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
The patch I submitted still compatible with their latest next branch.
Just to be sure I even updated my GitHub repository again to be based on the
latest commit from their branch, so I do not understand what do you mean by
"newer kernel" as it is up to date with the upstream branch on which it should
be merge.
Try to check in your config again ? I'm able to succesfully boot and test the
driver with a buildroot crafted image based on the input kernel tree and qemu.
If there is any issue related to boot with the driver it would be usefull at
least to get the kernel panic to debug it.
> Also I believe we are not
> contacting the correct person for a merge.
This kernel driver is not an HID driver but a USB driver, as such I don't think
the "NINTENDO HID DRIVER" maintainer is the appropriate to contact.
I might be mistaken but that also what the "get_maintainer.pl" script tells me.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-07 19:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-06 16:19 gamecube adapter driver Carson
2024-05-06 19:32 ` Milas Robin
2024-05-07 18:04 ` Carson
2024-05-07 19:04 ` Milas Robin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).