From: Jiri Kosina <jikos@kernel.org>
To: Allan Sandfeld Jensen <kde@carewolf.com>
Cc: lains@riseup.net, hadess@hadess.net,
benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org,
Allan Sandfeld Jensen <allan.jensen@qt.io>
Subject: Re: [PATCH] Add Logitech HID++ devices
Date: Mon, 6 May 2024 23:25:12 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2405062323420.16865@cbobk.fhfr.pm> (raw)
In-Reply-To: <20240424113130.60386-1-kde@carewolf.com>
On Wed, 24 Apr 2024, kde@carewolf.com wrote:
> From: Allan Sandfeld Jensen <allan.jensen@qt.io>
>
> Adds a few recognized Logitech HID++ capable mice over USB and Bluetooth
>
> Signed-off-by: Allan Sandfeld Jensen <kde@carewolf.com>
Thanks for the patch!
Two nits:
- the shortlog (subject) of the patch didn't really follow the pattern we
are using in HID subsystem. I have fixed it, but please take care of
that in your next submissions.
- the patch was against some old version of the code, so it didn't apply
cleanly (more entries are now present in hidpp_devices[]). I've fixed
that manually, please cross-check the end result in the git branch
Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2024-05-06 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 11:31 [PATCH] Add Logitech HID++ devices kde
2024-05-06 21:25 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2405062323420.16865@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=allan.jensen@qt.io \
--cc=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=kde@carewolf.com \
--cc=lains@riseup.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).