From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
To: Jarkko Sakkinen <jarkko@kernel.org>,
Alexander Steffen <Alexander.Steffen@infineon.com>,
"Daniel P. Smith" <dpsmith@apertussolutions.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Sasha Levin <sashal@kernel.org>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ross Philipson <ross.philipson@oracle.com>,
Kanth Ghatraju <kanth.ghatraju@oracle.com>,
Peter Huewe <peterhuewe@gmx.de>
Subject: Re: [PATCH 1/3] tpm: protect against locality counter underflow
Date: Wed, 21 Feb 2024 00:26:08 +0100 [thread overview]
Message-ID: <9da1855b-eca2-4c11-a69d-e01494c985d1@kunbus.com> (raw)
In-Reply-To: <CZA9GMC718HA.1JFHTTWV563IE@seitikki>
On 20.02.24 23:31, Jarkko Sakkinen wrote:
> ATTENTION: This e-mail is from an external sender. Please check attachments and links before opening e.g. with mouseover.
>
>
> On Tue Feb 20, 2024 at 10:26 PM UTC, Jarkko Sakkinen wrote:
>> On Tue Feb 20, 2024 at 8:54 PM UTC, Lino Sanfilippo wrote:
>>> for (i = 0; i <= MAX_LOCALITY; i++)
>>> __tpm_tis_relinquish_locality(priv, i);
>>
>> I'm pretty unfamiliar with Intel TXT so asking a dummy question:
>> if Intel TXT uses locality 2 I suppose we should not try to
>> relinquish it, or?
>>
>> AFAIK, we don't have a symbol called MAX_LOCALITY.
>
> OK it was called TPM_MAX_LOCALITY :-) I had the patch set applied
> in one branch but looked up with wrong symbol name.
>
Sorry for the confusion. The code was just meant to sketch a solution, it was
written out of my head and I just remembered that Daniels patch set introduced
some define for the max number of the localities. I did not look up the correct
name though.
next prev parent reply other threads:[~2024-02-20 23:26 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240131170824.6183-1-dpsmith@apertussolutions.com>
2024-01-31 17:08 ` [PATCH 1/3] tpm: protect against locality counter underflow Daniel P. Smith
2024-02-01 22:21 ` Jarkko Sakkinen
2024-02-02 3:08 ` Lino Sanfilippo
2024-02-12 20:05 ` Jarkko Sakkinen
2024-02-19 17:54 ` Daniel P. Smith
2024-02-20 18:42 ` Alexander Steffen
2024-02-20 19:04 ` Jarkko Sakkinen
2024-02-20 20:54 ` Lino Sanfilippo
2024-02-20 22:23 ` Jarkko Sakkinen
2024-02-20 23:19 ` Lino Sanfilippo
2024-02-21 0:40 ` Jarkko Sakkinen
2024-02-23 1:58 ` Daniel P. Smith
2024-02-23 12:58 ` Jarkko Sakkinen
2024-02-25 11:23 ` Daniel P. Smith
2024-02-26 9:39 ` Jarkko Sakkinen
2024-02-20 22:26 ` Jarkko Sakkinen
2024-02-20 22:31 ` Jarkko Sakkinen
2024-02-20 23:26 ` Lino Sanfilippo [this message]
2024-02-21 0:42 ` Jarkko Sakkinen
2024-02-21 12:37 ` James Bottomley
2024-02-21 19:43 ` Jarkko Sakkinen
2024-02-21 19:45 ` Jarkko Sakkinen
2024-02-22 9:06 ` James Bottomley
2024-02-22 23:49 ` Jarkko Sakkinen
2024-02-23 1:57 ` Daniel P. Smith
2024-02-23 20:40 ` Jarkko Sakkinen
2024-02-23 20:42 ` Jarkko Sakkinen
2024-02-23 1:57 ` Daniel P. Smith
2024-02-23 20:50 ` Jarkko Sakkinen
2024-02-20 22:57 ` ross.philipson
2024-02-20 23:10 ` Jarkko Sakkinen
2024-02-20 23:13 ` Jarkko Sakkinen
2024-02-23 1:56 ` Daniel P. Smith
2024-02-23 20:44 ` Jarkko Sakkinen
2024-02-24 2:34 ` Lino Sanfilippo
2024-02-26 9:38 ` Jarkko Sakkinen
2024-02-23 1:55 ` Daniel P. Smith
2024-02-26 12:43 ` Alexander Steffen
2024-02-24 2:06 ` Lino Sanfilippo
2024-02-23 0:01 ` Jarkko Sakkinen
2024-01-31 17:08 ` [PATCH 2/3] tpm: ensure tpm is in known state at startup Daniel P. Smith
2024-02-01 22:33 ` Jarkko Sakkinen
2024-02-19 19:17 ` Daniel P. Smith
2024-02-19 20:17 ` Jarkko Sakkinen
2024-01-31 17:08 ` [PATCH 3/3] tpm: make locality request return value consistent Daniel P. Smith
2024-02-01 22:49 ` Jarkko Sakkinen
2024-02-19 20:29 ` Daniel P. Smith
2024-02-19 20:45 ` Jarkko Sakkinen
2024-02-20 18:57 ` Alexander Steffen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9da1855b-eca2-4c11-a69d-e01494c985d1@kunbus.com \
--to=l.sanfilippo@kunbus.com \
--cc=Alexander.Steffen@infineon.com \
--cc=dpsmith@apertussolutions.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kanth.ghatraju@oracle.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=ross.philipson@oracle.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).