From: Ada Couprie Diaz <ada.coupriediaz@arm.com>
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
Cc: nathan@kernel.org, arnd@arndb.de, broonie@kernel.org,
Liam.Howlett@oracle.com, urezki@gmail.com, will@kernel.org,
kaleshsingh@google.com, rppt@kernel.org, leitao@debian.org,
coxu@redhat.com, surenb@google.com, akpm@linux-foundation.org,
luto@kernel.org, jpoimboe@kernel.org, changyuanl@google.com,
hpa@zytor.com, dvyukov@google.com, kas@kernel.org,
corbet@lwn.net, vincenzo.frascino@arm.com, smostafa@google.com,
nick.desaulniers+lkml@gmail.com, morbo@google.com,
andreyknvl@gmail.com, alexander.shishkin@linux.intel.com,
thiago.bauermann@linaro.org, catalin.marinas@arm.com,
ryabinin.a.a@gmail.com, jan.kiszka@siemens.com, jbohac@suse.cz,
dan.j.williams@intel.com, joel.granados@kernel.org,
baohua@kernel.org, kevin.brodsky@arm.com,
nicolas.schier@linux.dev, pcc@google.com,
andriy.shevchenko@linux.intel.com, wei.liu@kernel.org,
bp@alien8.de, xin@zytor.com, pankaj.gupta@amd.com,
vbabka@suse.cz, glider@google.com, jgross@suse.com,
kees@kernel.org, jhubbard@nvidia.com, joey.gouly@arm.com,
ardb@kernel.org, thuth@redhat.com, pasha.tatashin@soleen.com,
kristina.martsenko@arm.com, bigeasy@linutronix.de,
lorenzo.stoakes@oracle.com, jason.andryuk@amd.com,
david@redhat.com, graf@amazon.com, wangkefeng.wang@huawei.com,
ziy@nvidia.com, mark.rutland@arm.com,
dave.hansen@linux.intel.com, samuel.holland@sifive.com,
kbingham@kernel.org, trintaeoitogc@gmail.com,
scott@os.amperecomputing.com, justinstitt@google.com,
kuan-ying.lee@canonical.com, maz@kernel.org, tglx@linutronix.de,
samitolvanen@google.com, mhocko@suse.com,
nunodasneves@linux.microsoft.com, brgerst@gmail.com,
willy@infradead.org, ubizjak@gmail.com, peterz@infradead.org,
mingo@redhat.com, sohil.mehta@intel.com, linux-mm@kvack.org,
linux-kbuild@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org,
llvm@lists.linux.dev, kasan-dev@googlegroups.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Ada Couprie Diaz <ada.coupriediaz@arm.com>
Subject: Re: [PATCH v4 00/18] kasan: x86: arm64: KASAN tag-based mode for x86
Date: Thu, 21 Aug 2025 13:30:28 +0100 [thread overview]
Message-ID: <9eb211ee-94bf-431b-981c-e305c8ea5e0b@arm.com> (raw)
In-Reply-To: <cover.1755004923.git.maciej.wieczor-retman@intel.com>
Hi,
On 12/08/2025 14:23, Maciej Wieczor-Retman wrote:
> [...]
> ======= Testing
> Checked all the kunits for both software tags and generic KASAN after
> making changes.
>
> In generic mode the results were:
>
> kasan: pass:59 fail:0 skip:13 total:72
> Totals: pass:59 fail:0 skip:13 total:72
> ok 1 kasan
>
> and for software tags:
>
> kasan: pass:63 fail:0 skip:9 total:72
> Totals: pass:63 fail:0 skip:9 total:72
> ok 1 kasan
I tested the series on arm64 and after fixing the build issues mentioned
I was able to boot without issues and did not observe any regressions
in the KASAN KUnit tests with either generic or software tags.
So this is Tested-by: Ada Couprie Diaz <ada.coupriediaz@arm.com> (For arm64)
I will note that the tests `kmalloc_memmove_negative_size` and
`kmalloc_memmove_invalid_size` seem to be able to corrupt memory
and lead to kernel crashes if `memmove()` is not properly instrumented,
which I discovered while investigating [0].
> [...]
> ======= Compilation
> Clang was used to compile the series (make LLVM=1) since gcc doesn't
> seem to have support for KASAN tag-based compiler instrumentation on
> x86.
Interestingly, while investigating [0], this comment slipped by me and
I managed to compile your series for x86 with software tags using GCC,
though it is a bit hacky.
You need to update the CC_HAS_KASAN_SW_TAGS to pass `-mlam=u48`
or `-mlam=u57`, as it is disabled by default, and pass `-march=arrowlake`
for compilation (the support for software tags depends on the arch).
You could then test with GCC (though the issue in [0] also applies to x86).
Best,
Ada
[0]: https://groups.google.com/g/kasan-dev/c/v1PYeoitg88
> ======= Dependencies
> The base branch for the series is the mainline kernel, tag 6.17-rc1.
>
> ======= Enabling LAM for testing
> Since LASS is needed for LAM and it can't be compiled without it I
> applied the LASS series [1] first, then applied my patches.
>
> [1] https://lore.kernel.org/all/20250707080317.3791624-1-kirill.shutemov@linux.intel.com/
>
> Changes v4:
> - Revert x86 kasan_mem_to_shadow() scheme to the same on used in generic
> KASAN. Keep the arithmetic shift idea for the KASAN in general since
> it makes more sense for arm64 and in risc-v.
> - Fix inline mode but leave it unavailable until a complementary
> compiler patch can be merged.
> - Apply Dave Hansen's comments on series formatting, patch style and
> code simplifications.
>
> Changes v3:
> - Remove the runtime_const patch and setup a unified offset for both 5
> and 4 paging levels.
> - Add a fix for inline mode on x86 tag-based KASAN. Add a handler for
> int3 that is generated on inline tag mismatches.
> - Fix scripts/gdb/linux/kasan.py so the new signed mem_to_shadow() is
> reflected there.
> - Fix Documentation/arch/arm64/kasan-offsets.sh to take new offsets into
> account.
> - Made changes to the kasan_non_canonical_hook() according to upstream
> discussion.
> - Remove patches 2 and 3 since they related to risc-v and this series
> adds only x86 related things.
> - Reorder __tag_*() functions so they're before arch_kasan_*(). Remove
> CONFIG_KASAN condition from __tag_set().
>
> Changes v2:
> - Split the series into one adding KASAN tag-based mode (this one) and
> another one that adds the dense mode to KASAN (will post later).
> - Removed exporting kasan_poison() and used a wrapper instead in
> kasan_init_64.c
> - Prepended series with 4 patches from the risc-v series and applied
> review comments to the first patch as the rest already are reviewed.
>
> Maciej Wieczor-Retman (16):
> kasan: Fix inline mode for x86 tag-based mode
> x86: Add arch specific kasan functions
> kasan: arm64: x86: Make special tags arch specific
> x86: Reset tag for virtual to physical address conversions
> mm: x86: Untag addresses in EXECMEM_ROX related pointer arithmetic
> x86: Physical address comparisons in fill_p*d/pte
> x86: KASAN raw shadow memory PTE init
> x86: LAM compatible non-canonical definition
> x86: LAM initialization
> x86: Minimal SLAB alignment
> kasan: arm64: x86: Handle int3 for inline KASAN reports
> kasan: x86: Apply multishot to the inline report handler
> kasan: x86: Logical bit shift for kasan_mem_to_shadow
> mm: Unpoison pcpu chunks with base address tag
> mm: Unpoison vms[area] addresses with a common tag
> x86: Make software tag-based kasan available
>
> Samuel Holland (2):
> kasan: sw_tags: Use arithmetic shift for shadow computation
> kasan: sw_tags: Support tag widths less than 8 bits
>
> Documentation/arch/arm64/kasan-offsets.sh | 8 ++-
> Documentation/arch/x86/x86_64/mm.rst | 6 +-
> MAINTAINERS | 4 +-
> arch/arm64/Kconfig | 10 ++--
> arch/arm64/include/asm/kasan-tags.h | 9 +++
> arch/arm64/include/asm/kasan.h | 6 +-
> arch/arm64/include/asm/memory.h | 14 ++++-
> arch/arm64/include/asm/uaccess.h | 1 +
> arch/arm64/kernel/traps.c | 17 +-----
> arch/arm64/mm/kasan_init.c | 7 ++-
> arch/x86/Kconfig | 4 +-
> arch/x86/boot/compressed/misc.h | 1 +
> arch/x86/include/asm/cache.h | 4 ++
> arch/x86/include/asm/kasan-tags.h | 9 +++
> arch/x86/include/asm/kasan.h | 71 ++++++++++++++++++++++-
> arch/x86/include/asm/page.h | 24 +++++++-
> arch/x86/include/asm/page_64.h | 2 +-
> arch/x86/kernel/alternative.c | 4 +-
> arch/x86/kernel/head_64.S | 3 +
> arch/x86/kernel/setup.c | 2 +
> arch/x86/kernel/traps.c | 4 ++
> arch/x86/mm/Makefile | 2 +
> arch/x86/mm/init.c | 3 +
> arch/x86/mm/init_64.c | 11 ++--
> arch/x86/mm/kasan_init_64.c | 19 +++++-
> arch/x86/mm/kasan_inline.c | 26 +++++++++
> arch/x86/mm/pat/set_memory.c | 1 +
> arch/x86/mm/physaddr.c | 1 +
> include/linux/kasan-tags.h | 21 +++++--
> include/linux/kasan.h | 51 +++++++++++++++-
> include/linux/mm.h | 6 +-
> include/linux/mmzone.h | 1 -
> include/linux/page-flags-layout.h | 9 +--
> lib/Kconfig.kasan | 3 +-
> mm/execmem.c | 4 +-
> mm/kasan/hw_tags.c | 11 ++++
> mm/kasan/report.c | 45 ++++++++++++--
> mm/kasan/shadow.c | 18 ++++++
> mm/vmalloc.c | 8 +--
> scripts/Makefile.kasan | 3 +
> scripts/gdb/linux/kasan.py | 5 +-
> scripts/gdb/linux/mm.py | 5 +-
> 42 files changed, 381 insertions(+), 82 deletions(-)
> mode change 100644 => 100755 Documentation/arch/arm64/kasan-offsets.sh
> create mode 100644 arch/arm64/include/asm/kasan-tags.h
> create mode 100644 arch/x86/include/asm/kasan-tags.h
> create mode 100644 arch/x86/mm/kasan_inline.c
>
next prev parent reply other threads:[~2025-08-21 12:31 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 13:23 [PATCH v4 00/18] kasan: x86: arm64: KASAN tag-based mode for x86 Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 01/18] kasan: sw_tags: Use arithmetic shift for shadow computation Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 02/18] kasan: sw_tags: Support tag widths less than 8 bits Maciej Wieczor-Retman
2025-08-13 14:48 ` Ada Couprie Diaz
2025-08-18 4:24 ` Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 03/18] kasan: Fix inline mode for x86 tag-based mode Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 04/18] x86: Add arch specific kasan functions Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 05/18] kasan: arm64: x86: Make special tags arch specific Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 06/18] x86: Reset tag for virtual to physical address conversions Maciej Wieczor-Retman
2025-08-14 7:15 ` Mike Rapoport
2025-08-18 5:29 ` Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 07/18] mm: x86: Untag addresses in EXECMEM_ROX related pointer arithmetic Maciej Wieczor-Retman
2025-08-14 7:26 ` Mike Rapoport
2025-08-18 5:47 ` Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 08/18] x86: Physical address comparisons in fill_p*d/pte Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 09/18] x86: KASAN raw shadow memory PTE init Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 10/18] x86: LAM compatible non-canonical definition Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 11/18] x86: LAM initialization Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 12/18] x86: Minimal SLAB alignment Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 13/18] kasan: arm64: x86: Handle int3 for inline KASAN reports Maciej Wieczor-Retman
2025-08-13 14:49 ` Ada Couprie Diaz
2025-08-18 5:57 ` Maciej Wieczor-Retman
2025-08-13 15:17 ` Peter Zijlstra
2025-08-18 6:26 ` Maciej Wieczor-Retman
2025-09-08 15:40 ` Peter Zijlstra
2025-09-09 8:47 ` Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 14/18] kasan: x86: Apply multishot to the inline report handler Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 15/18] kasan: x86: Logical bit shift for kasan_mem_to_shadow Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 16/18] mm: Unpoison pcpu chunks with base address tag Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 17/18] mm: Unpoison vms[area] addresses with a common tag Maciej Wieczor-Retman
2025-08-12 13:23 ` [PATCH v4 18/18] x86: Make software tag-based kasan available Maciej Wieczor-Retman
2025-08-13 8:16 ` [PATCH v4 00/18] kasan: x86: arm64: KASAN tag-based mode for x86 Kiryl Shutsemau
2025-08-13 10:39 ` Maciej Wieczor-Retman
2025-08-13 11:05 ` Kiryl Shutsemau
2025-08-13 11:44 ` Maciej Wieczor-Retman
2025-08-21 12:30 ` Ada Couprie Diaz [this message]
2025-08-22 7:36 ` Maciej Wieczor-Retman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9eb211ee-94bf-431b-981c-e305c8ea5e0b@arm.com \
--to=ada.coupriediaz@arm.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andreyknvl@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=baohua@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=changyuanl@google.com \
--cc=corbet@lwn.net \
--cc=coxu@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=graf@amazon.com \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=jason.andryuk@amd.com \
--cc=jbohac@suse.cz \
--cc=jgross@suse.com \
--cc=jhubbard@nvidia.com \
--cc=joel.granados@kernel.org \
--cc=joey.gouly@arm.com \
--cc=jpoimboe@kernel.org \
--cc=justinstitt@google.com \
--cc=kaleshsingh@google.com \
--cc=kas@kernel.org \
--cc=kasan-dev@googlegroups.com \
--cc=kbingham@kernel.org \
--cc=kees@kernel.org \
--cc=kevin.brodsky@arm.com \
--cc=kristina.martsenko@arm.com \
--cc=kuan-ying.lee@canonical.com \
--cc=leitao@debian.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=lorenzo.stoakes@oracle.com \
--cc=luto@kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas.schier@linux.dev \
--cc=nunodasneves@linux.microsoft.com \
--cc=pankaj.gupta@amd.com \
--cc=pasha.tatashin@soleen.com \
--cc=pcc@google.com \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=ryabinin.a.a@gmail.com \
--cc=samitolvanen@google.com \
--cc=samuel.holland@sifive.com \
--cc=scott@os.amperecomputing.com \
--cc=smostafa@google.com \
--cc=sohil.mehta@intel.com \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=thiago.bauermann@linaro.org \
--cc=thuth@redhat.com \
--cc=trintaeoitogc@gmail.com \
--cc=ubizjak@gmail.com \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
--cc=vincenzo.frascino@arm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).