From: Rae Moar <rmoar@google.com>
To: "Sergio González Collado" <sergio.collado@gmail.com>
Cc: David Gow <davidgow@google.com>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
Miguel Ojeda <ojeda@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
Randy Dunlap <rdunlap@infradead.org>,
rust-for-linux@vger.kernel.org,
Josh Poimboeuf <jpoimboe@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Nathan Chancellor <nathan@kernel.org>,
David Laight <david.laight.linux@gmail.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Martin Rodriguez Reboredo <yakoyoku@gmail.com>,
x86@kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v3 RESEND] kunit: fix longest symbol length test
Date: Thu, 10 Jul 2025 15:30:05 -0400 [thread overview]
Message-ID: <CA+GJov5eXsoKG2eYch8h5HgLCwnE8+9RA0v-+9DW9TpP5SordA@mail.gmail.com> (raw)
In-Reply-To: <20250706201855.232451-1-sergio.collado@gmail.com>
On Sun, Jul 6, 2025 at 4:19 PM Sergio González Collado
<sergio.collado@gmail.com> wrote:
>
> The kunit test that checks the longests symbol length [1], has triggered
> warnings in some pilelines when symbol prefixes are used [2][3]. The test
> will to depend on !PREFIX_SYMBOLS and !CFI_CLANG as sujested in [4] and
> on !GCOV_KERNEL.
>
> [1] https://lore.kernel.org/rust-for-linux/CABVgOSm=5Q0fM6neBhxSbOUHBgNzmwf2V22vsYC10YRBT=kN1g@mail.gmail.com/T/#t
> [2] https://lore.kernel.org/all/20250328112156.2614513-1-arnd@kernel.org/T/#u
> [3] https://lore.kernel.org/rust-for-linux/bbd03b37-c4d9-4a92-9be2-75aaf8c19815@infradead.org/T/#t
> [4] https://lore.kernel.org/linux-kselftest/20250427200916.GA1661412@ax162/T/#t
>
> Reviewed-by: Rae Moar <rmoar@google.com>
> Signed-off-by: Sergio González Collado <sergio.collado@gmail.com>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
Hello!
Thanks for resending! I don't believe this has been accepted yet. So
I've added it to the list of patches to get accepted for the
kselftest/kunit branch.
Thanks!
-Rae
> ---
> lib/Kconfig.debug | 1 +
> lib/tests/longest_symbol_kunit.c | 3 +--
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index ebe33181b6e6..4a75a52803b6 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -2885,6 +2885,7 @@ config FORTIFY_KUNIT_TEST
> config LONGEST_SYM_KUNIT_TEST
> tristate "Test the longest symbol possible" if !KUNIT_ALL_TESTS
> depends on KUNIT && KPROBES
> + depends on !PREFIX_SYMBOLS && !CFI_CLANG && !GCOV_KERNEL
> default KUNIT_ALL_TESTS
> help
> Tests the longest symbol possible
> diff --git a/lib/tests/longest_symbol_kunit.c b/lib/tests/longest_symbol_kunit.c
> index e3c28ff1807f..9b4de3050ba7 100644
> --- a/lib/tests/longest_symbol_kunit.c
> +++ b/lib/tests/longest_symbol_kunit.c
> @@ -3,8 +3,7 @@
> * Test the longest symbol length. Execute with:
> * ./tools/testing/kunit/kunit.py run longest-symbol
> * --arch=x86_64 --kconfig_add CONFIG_KPROBES=y --kconfig_add CONFIG_MODULES=y
> - * --kconfig_add CONFIG_RETPOLINE=n --kconfig_add CONFIG_CFI_CLANG=n
> - * --kconfig_add CONFIG_MITIGATION_RETPOLINE=n
> + * --kconfig_add CONFIG_CPU_MITIGATIONS=n --kconfig_add CONFIG_GCOV_KERNEL=n
> */
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> base-commit: 772b78c2abd85586bb90b23adff89f7303c704c7
> --
> 2.39.2
>
prev parent reply other threads:[~2025-07-10 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-06 20:18 [PATCH v3 RESEND] kunit: fix longest symbol length test Sergio González Collado
2025-07-07 9:38 ` Peter Zijlstra
2025-07-07 17:09 ` Sergio González Collado
2025-07-10 19:30 ` Rae Moar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+GJov5eXsoKG2eYch8h5HgLCwnE8+9RA0v-+9DW9TpP5SordA@mail.gmail.com \
--to=rmoar@google.com \
--cc=arnd@arndb.de \
--cc=boqun.feng@gmail.com \
--cc=david.laight.linux@gmail.com \
--cc=davidgow@google.com \
--cc=jpoimboe@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sergio.collado@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=x86@kernel.org \
--cc=yakoyoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).