From: Masahiro Yamada <masahiroy@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Tony Finch <dot@dotat.at>, Sam Ravnborg <sam@ravnborg.org>,
Arnd Bergmann <arnd@arndb.de>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
linux-kbuild@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/unifdef: avoid constexpr keyword
Date: Fri, 29 Mar 2024 18:59:26 +0900 [thread overview]
Message-ID: <CAK7LNATQJ6HXwsY2ziDPnQ5AdhFHL=M=qPW2idyPQrumsXmkrQ@mail.gmail.com> (raw)
In-Reply-To: <20240320180134.100863-1-arnd@kernel.org>
On Thu, Mar 21, 2024 at 3:01 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Starting with c23, 'constexpr' is a keyword in C like in C++ and cannot
> be used as an identifier:
>
> scripts/unifdef.c:206:25: error: 'constexpr' can only be used in variable declarations
> 206 | static bool constexpr; /* constant #if expression */
> | ^
> scripts/unifdef.c:880:13: error: expected identifier or '('
> 880 | constexpr = false;
> | ^
>
> Rename this instance to allow changing to C23 at some point in the future.
>
> Fixes: d8379ab1dde3 ("unifdef: update to upstream revision 1.190")
This can be a problem only for future kernels.
Is it worth adding Fixes?
Even if the kernel bumps to C23 at some point,
such a patch will not be backported.
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2024-03-29 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 17:59 [PATCH] scripts/unifdef: avoid constexpr keyword Arnd Bergmann
2024-03-21 15:53 ` Tony Finch
2024-03-29 9:59 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNATQJ6HXwsY2ziDPnQ5AdhFHL=M=qPW2idyPQrumsXmkrQ@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dot@dotat.at \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).